Fix logging logic on mdn processing completion (#484)

* Version updates

* Enhance MDN processing to produce more logging when an MDN response is
not what is expected.

* Release notes

* Fix logging WARN message that should have been a trace log.

* Update release version number.

* Fix log level on logging record meant for TRACE level logging.

* Documentation minor additions.

* Release notes

Author: uhurusurfa

RELEASE-NOTES.md

@@ -1,19 +1,20 @@
 #              OpenAS2 Server
-#              Version 4.7.0
+#              Version 4.7.1
 #              RELEASE NOTES
 -----
-The OpenAS2 project is pleased to announce the release of OpenAS2 4.7.0
+The OpenAS2 project is pleased to announce the release of OpenAS2 4.7.1
 
-The release download file is: OpenAS2Server-4.7.0.zip
+The release download file is: OpenAS2Server-4.7.1.zip
 
 The zip file contains a PDF document (OpenAS2HowTo.pdf) providing information on installing and using the application.
 ## NOTE: Testing covers Java 11 to 21.
 ##       Java 8 is NO LONGER SUPPORTED.
 
-Version 4.7.0 - 2025-10-28
+Version 4.7.1 - 2025-10-20
 
-This is a minor enhancement release.
-1. Enhance MDN processing to extract possible responses from partner that provide information on why the partner rejected the AS2 transaction.
+This is a minor bufix release.
+1. Fix boolean return values from processMDN method causing wrong log message.
+2. Fix logging WARN message that should have been a TRACE log.
 
 
 ##Upgrade Notes

Server/pom.xml

@@ -7,7 +7,7 @@
         <!-- DO NOT CHANGE THIS "groupId" WITHOUT CHANGING XMLSession.getManifestAttributes.MANIFEST_VENDOR_ID_ATTRIB -->
         <groupId>net.sf.openas2</groupId>
         <artifactId>OpenAS2</artifactId>
-        <version>4.7.0</version>
+        <version>4.7.1</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 

Server/src/main/java/org/openas2/processor/sender/AS2SenderModule.java

@@ -237,7 +237,7 @@ private void processResponse(Message msg, ResponseWrapper response) {
                 // Assume that appropriate logging and state handling was done upstream if an error occurred so only log state change for success
                 boolean mdnResponseIssue = AS2Util.processMDN((AS2Message) msg, response.getBody(), null, false, getSession(), this.getClass());
                 if (mdnResponseIssue) {
-                    logger.warn("There was an issue identified processing the response fropm the p[artner. Review upstream log messages for details on the probklem.");
+                    logger.warn("There was an issue identified processing the response from the partner. Review upstream log messages for details on the problem.");
                 }
             } catch (Exception e) {
                 /* Processing of the MDN would have done extensive error handling so only log an error if the error

Server/src/main/java/org/openas2/util/AS2Util.java

@@ -535,7 +535,8 @@ public static boolean processMDN(AS2Message msg, byte[] data, OutputStream out,
         } catch (MessagingException e1) {
             msg.setLogMsg("Failed to create mimebodypart from received MDN data for partnership " + mdn.getPartnership().getName() + ": " + org.openas2.util.Logging.getExceptionMsg(e1));
             logger.error(msg.getLogMsg(), e1);
-            return AS2Util.resend(session, sourceClass, SenderModule.DO_SEND, msg, new OpenAS2Exception(e1), true, false);
+            AS2Util.resend(session, sourceClass, SenderModule.DO_SEND, msg, new OpenAS2Exception(e1), true, false);
+            return true;
         }
         CertificateFactory cFx = session.getCertificateFactory(CertificateFactory.COMPID_AS2_CERTIFICATE_FACTORY);
         String x509_alias = mdn.getPartnership().getAlias(Partnership.PTYPE_RECEIVER);
@@ -617,7 +618,7 @@ public static boolean processMDN(AS2Message msg, byte[] data, OutputStream out,
         logger.info(msg.getLogMsg());
 
         cleanupFiles(msg, false);
-        return true;
+        return false;
 
     }
 

Server/src/main/java/org/openas2/util/HTTPUtil.java

@@ -430,7 +430,9 @@ private static SSLConnectionSocketFactory buildSslFactory(URL urlObj, Map<String
         String selfSignedCN = System.getProperty("org.openas2.cert.TrustSelfSignedCN");
         boolean isTrustSelfSignedCNHandling = (selfSignedCN != null && selfSignedCN.contains(urlObj.getHost()))?true:false;
 
-        LOG.warn("SSL factory building using:\n\tisExtendedSelfsignedTrustCheck: {}\n\toverrideSslChecks: {}\n\tisTrustSelfSignedCNHandling: {}", isExtendedSelfsignedTrustCheck, overrideSslChecks, isTrustSelfSignedCNHandling);
+        if (LOG.isTraceEnabled()) {
+            LOG.trace("SSL factory building values: isExtendedSelfsignedTrustCheck - {}  ::: overrideSslChecks - {} ::: isTrustSelfSignedCNHandling - {}", isExtendedSelfsignedTrustCheck, overrideSslChecks, isTrustSelfSignedCNHandling);
+        }
         // Find a keystore to verify the self signed certs against if required
         // Even if TrustSelfSignedCN is passed, use the custom keystore if it is defined
         KeyStore selfsignedCertsKeystore = null;
@@ -447,7 +449,9 @@ private static SSLConnectionSocketFactory buildSslFactory(URL urlObj, Map<String
             try {
                 // Trust own CA and all self-signed certs
                 sslcontext = SSLContexts.custom().loadTrustMaterial(selfsignedCertsKeystore, new TrustSelfSignedStrategy()).build();
-                LOG.debug("SSL context built using self signed trust store...");
+                if (LOG.isTraceEnabled()) {
+                    LOG.trace("SSL context built using self signed trust store...");
+                }
             } catch (Exception e) {
                 throw new OpenAS2Exception("Attempted connection using self-signed manager failed connecting to : " + urlObj.toString(), e);
             }

changes.txt

@@ -1,6 +1,13 @@
 **IMPORTANT NOTE**: Please review upgrade notes in the RELEASE-NOTES.md if you are upgrading
 
-Version 4.7.0 - 2025-10-28
+Version 4.7.1 - 2025-10-20
+
+This is a minor enhancement release.
+1. Fix boolean return values from processMDN method causing wrong log message.
+2. Fix logging WARN message that should have been a TRACE log.
+
+
+Version 4.7.0 - 2025-10-18
 
 This is a minor enhancement release.
 1. Enhance MDN processing to extract possible responses from partner that provide information on why the partner rejected the AS2 transaction.

docs/OpenAS2HowTo.odt

@@ -5,7 +5,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>net.sf.openas2</groupId>
     <artifactId>OpenAS2</artifactId>
-    <version>4.7.0</version>
+    <version>4.7.1</version>
     <name>OpenAS2</name>
     <packaging>pom</packaging>