Skip to content

Add connection profile API and storage#222

Merged
smithaldon1 merged 1 commit into
mainfrom
feat/issue-208-connection-profile-api
May 23, 2026
Merged

Add connection profile API and storage#222
smithaldon1 merged 1 commit into
mainfrom
feat/issue-208-connection-profile-api

Conversation

@smithaldon1
Copy link
Copy Markdown
Member

Closes #208

Summary

  • Add local JSON-backed connection profile storage for the API service.
  • Add CRUD-style profile endpoints: create, list, detail, update, disable, and delete.
  • Validate requests with the shared ProtocolConnectionProfile schema before storage.
  • Redact secret and certificate reference names in browser-facing responses and sanitize request-validation errors so rejected raw secret-shaped inputs are not echoed.
  • Keep profile management separate from protocol ingestion; creating a profile does not start polling or subscriptions.

Test Evidence

  • .venv/bin/python -m pytest services/api/tests/test_connection_profiles_api.py - passed, 9 tests.
  • make test-integration - passed, 60 tests. First sandboxed run failed because the existing OPC UA worker test could not bind 127.0.0.1; rerun with loopback permission passed.
  • make test - passed, 232 tests.
  • make lint - passed.
  • make typecheck - passed.
  • make docs - passed placeholder docs target: "Docs are Markdown-only in the MVP skeleton; no docs checker is configured yet."
  • git diff --check and git diff --cached --check - passed.

Docs Impact

  • Updated services/api/README.md with endpoints and FACTORY_CONNECTION_PROFILES_STORE.
  • Updated docs/DATA_CONTRACTS.md with API contract notes.
  • Updated docs/LEARNING_LOG.md.

Follow-up Work

Copy link
Copy Markdown
Member Author

@smithaldon1 smithaldon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved for merge

@smithaldon1 smithaldon1 merged commit baa03a5 into main May 23, 2026
3 checks passed
@smithaldon1 smithaldon1 deleted the feat/issue-208-connection-profile-api branch May 23, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3. Feature: Add connection profile API and storage

1 participant