Skip to content

Add production protocol connector ADR#220

Merged
smithaldon1 merged 1 commit into
mainfrom
docs/issue-210-connector-adr
May 23, 2026
Merged

Add production protocol connector ADR#220
smithaldon1 merged 1 commit into
mainfrom
docs/issue-210-connector-adr

Conversation

@smithaldon1
Copy link
Copy Markdown
Member

Closes #210

Summary

  • Add ADR 0002 defining the read-only production connector boundary for OPC-UA, MQTT, and BACnet.
  • Document connection profile ownership, storage expectations, lifecycle states, secret/certificate references, test-connection behavior, and audit/logging expectations.
  • Add focused documentation tests plus a learning-log entry for the connector decision.

Test Evidence

  • .venv/bin/python -m pytest services/simulator/tests/test_production_connector_adr_docs.py - passed, 4 tests.
  • make lint - passed.
  • make typecheck - passed.
  • make test - passed, 213 tests.
  • make docs - passed placeholder docs target: "Docs are Markdown-only in the MVP skeleton; no docs checker is configured yet."
  • git diff --check - passed.

Docs Impact

  • Added docs/decisions/0002-production-protocol-connector-architecture.md.
  • Linked ADR 0002 from docs/decisions/README.md.
  • Updated docs/LEARNING_LOG.md.

Follow-up Work

Copy link
Copy Markdown
Member Author

@smithaldon1 smithaldon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved for merge

@smithaldon1 smithaldon1 self-assigned this May 23, 2026
@smithaldon1 smithaldon1 marked this pull request as ready for review May 23, 2026 18:32
@smithaldon1 smithaldon1 merged commit eb07eae into main May 23, 2026
3 checks passed
@smithaldon1 smithaldon1 deleted the docs/issue-210-connector-adr branch May 23, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1. ADR: Define production protocol connector architecture and safety boundary

1 participant