- Max size: 100 MB + Max size: {MAX_UPLOAD_MB} MB
diff --git a/src/components/sources-panel.test.ts b/src/components/sources-panel.test.ts index bf6daae..068d509 100644 --- a/src/components/sources-panel.test.ts +++ b/src/components/sources-panel.test.ts @@ -24,6 +24,9 @@ import { SourcesPanel } from "./sources-panel"; const C = SourcesPanel as React.FC>; const originalResizeObserver = globalThis.ResizeObserver; +const fileTooLargeMessage = + "File is too large. Upload a document up to 300 MB. " + + "For larger files, contact team@knowhereto.ai or open an issue at https://github.com/Ontos-AI/knowhere/issues."; describe("SourcesPanel", () => { beforeEach(() => { @@ -131,10 +134,10 @@ describe("SourcesPanel", () => { expect( screen.getByText( - /Notebook accepts PDF, DOC, DOCX, TXT, MD, XLS, XLSX, PPTX, images, and more files up to 100 MB/, + /Notebook accepts PDF, DOC, DOCX, TXT, MD, XLS, XLSX, PPTX, images, and more files up to 300 MB/, ), ).toBeTruthy(); - expect(screen.getByText("Max size: 100 MB")).toBeTruthy(); + expect(screen.getByText("Max size: 300 MB")).toBeTruthy(); expect(opened.container.textContent).not.toMatch(/Knowhere|parsing|indexing/i); }); @@ -383,7 +386,7 @@ describe("SourcesPanel", () => { } return Response.json( - { message: "File is too large. Upload a document up to 100 MB." }, + { message: fileTooLargeMessage }, { status: 400 }, ); }); @@ -407,11 +410,7 @@ describe("SourcesPanel", () => { } fireEvent.submit(form); - expect( - await screen.findByText( - "File is too large. Upload a document up to 100 MB.", - ), - ).toBeTruthy(); + expect(await screen.findByText(fileTooLargeMessage)).toBeTruthy(); expect(screen.getByRole("button", { name: "Confirm" })).toBeTruthy(); }); }); diff --git a/src/domains/chat/contracts.ts b/src/domains/chat/contracts.ts index bc11b77..49d8bc1 100644 --- a/src/domains/chat/contracts.ts +++ b/src/domains/chat/contracts.ts @@ -1,10 +1,10 @@ -import type { RetrievalQueryParams, RetrievalResult } from "@ontos-ai/knowhere-sdk" +import type { RetrievalQueryParams, RetrievalQueryResponse } from "@ontos-ai/knowhere-sdk" import type { Source } from "@/infrastructure/db/schema" import type { ChatCitationView } from "@/domains/chat/types" export type RetrievalClient = { - query(params: RetrievalQueryParams): Promise<{ results: RetrievalResult[] }> + query(params: RetrievalQueryParams): Promise } export type ChatHistoryMessage = { @@ -24,7 +24,7 @@ export type GenerateAnswer = (input: { question: string retrievalQuery: string messages: readonly ChatHistoryMessage[] - results: readonly RetrievalResult[] + evidenceText: string }) => Promise export type AnswerQuestionInput = { @@ -42,3 +42,4 @@ export type AnswerQuestionResult = { answer: string citations: ChatCitationView[] } + diff --git a/src/domains/chat/index.test.ts b/src/domains/chat/index.test.ts index d886ce4..ba7a4bd 100644 --- a/src/domains/chat/index.test.ts +++ b/src/domains/chat/index.test.ts @@ -27,6 +27,12 @@ describe("answerQuestionWithRetrieval", () => { const retrieval = { query: vi.fn().mockResolvedValue({ results: [makeRetrievalResult()], + evidenceText: "Grounding content from evidence tree", + referencedChunks: [], + namespace: "notebook-workspace", + query: "What does the document say?", + routerUsed: "workflow_single_step", + answerText: null, }), }; const generateAnswer = vi.fn().mockResolvedValue("The answer is grounded."); @@ -54,13 +60,14 @@ describe("answerQuestionWithRetrieval", () => { namespace: "notebook-workspace", query: "What does the document say?", topK: 8, + useAgentic: true, excludeDocumentIds: ["doc_excluded"], }); expect(generateAnswer).toHaveBeenCalledWith({ question: "What does the document say?", retrievalQuery: "What does the document say?", messages: [], - results: [makeRetrievalResult()], + evidenceText: "Grounding content from evidence tree", }); expect(answer).toEqual({ answer: "The answer is grounded.", @@ -87,6 +94,12 @@ describe("answerQuestionWithRetrieval", () => { const retrieval = { query: vi.fn().mockResolvedValue({ results: [firstResult, secondResult], + evidenceText: "Revenue grew. Gross margin improved.", + referencedChunks: [], + namespace: "notebook-workspace", + query: "What improved?", + routerUsed: "workflow_single_step", + answerText: null, }), }; const generateAnswer = vi @@ -124,7 +137,15 @@ describe("answerQuestionWithRetrieval", () => { }, }); const retrieval = { - query: vi.fn().mockResolvedValue({ results: [result] }), + query: vi.fn().mockResolvedValue({ + results: [result], + evidenceText: "Tesla invested in xAI.", + referencedChunks: [], + namespace: "notebook-workspace", + query: "Tesla xAI investment", + routerUsed: "workflow_single_step", + answerText: null, + }), }; const generateAnswer = vi .fn() @@ -149,6 +170,12 @@ describe("answerQuestionWithRetrieval", () => { }), ); + expect(generateAnswer).toHaveBeenCalledWith({ + question: "What does the document say about xAI?", + retrievalQuery: "Tesla xAI investment", + messages: [], + evidenceText: "Tesla invested in xAI.", + }); const expectedResult = { ...result, source: { @@ -156,12 +183,6 @@ describe("answerQuestionWithRetrieval", () => { sourceFileName: "TSLA-Q4-2025-Update.pdf", }, }; - expect(generateAnswer).toHaveBeenCalledWith({ - question: "What does the document say about xAI?", - retrievalQuery: "Tesla xAI investment", - messages: [], - results: [expectedResult], - }); expect(answer.citations).toEqual([ { ...expectedResult, description: "xAI investment" }, ]); @@ -169,7 +190,15 @@ describe("answerQuestionWithRetrieval", () => { it("returns a deterministic no-results answer without calling the model", async () => { const retrieval = { - query: vi.fn().mockResolvedValue({ results: [] }), + query: vi.fn().mockResolvedValue({ + results: [], + evidenceText: "", + referencedChunks: [], + namespace: "notebook-workspace", + query: "Missing fact?", + routerUsed: "workflow_single_step", + answerText: null, + }), }; const generateAnswer = vi.fn(); const generateRetrievalQuery = vi.fn().mockResolvedValue("Missing fact?"); @@ -198,6 +227,12 @@ describe("answerQuestionWithRetrieval", () => { const retrieval = { query: vi.fn().mockResolvedValue({ results: [makeRetrievalResult()], + evidenceText: "Energy storage deployments grew significantly.", + referencedChunks: [], + namespace: "notebook-workspace", + query: "Tesla Q4 2025 Update energy generation and storage deployments", + routerUsed: "workflow_single_step", + answerText: null, }), }; const generateRetrievalQuery = vi @@ -234,21 +269,14 @@ describe("answerQuestionWithRetrieval", () => { namespace: "notebook-workspace", query: "Tesla Q4 2025 Update energy generation and storage deployments", topK: 8, + useAgentic: true, }); expect(generateAnswer).toHaveBeenCalledWith({ question: "What about energy storage in this document?", retrievalQuery: "Tesla Q4 2025 Update energy generation and storage deployments", messages, - results: [ - makeRetrievalResult({ - source: { - documentId: "doc_included", - sourceFileName: "TSLA-Q4-2025-Update.pdf", - sectionPath: "Intro", - }, - }), - ], + evidenceText: "Energy storage deployments grew significantly.", }); }); }); @@ -303,11 +331,7 @@ describe("generateGroundedAnswer", () => { question: "What is PR-E?", retrievalQuery: "PR-E retrieval", messages: [], - results: [ - makeRetrievalResult({ - content: "PR-E wires chat to Knowhere retrieval.", - }), - ], + evidenceText: "PR-E wires chat to Knowhere retrieval.", }); expect(generateText).toHaveBeenCalledWith({ @@ -319,19 +343,10 @@ describe("generateGroundedAnswer", () => { }); describe("buildGroundedPrompt", () => { - it("includes retrieved source content and forbids unsupported answers", () => { + it("includes evidence text and uses evidence-based citation format", () => { const prompt = buildGroundedPrompt({ question: "What is PR-E?", - results: [ - makeRetrievalResult({ - content: "PR-E wires chat to Knowhere retrieval.", - source: { - documentId: "doc_1", - sourceFileName: "requirements.txt", - sectionPath: "N-005", - }, - }), - ], + evidenceText: "PR-E wires chat to Knowhere retrieval.\n[Document] requirements.txt\n▸ [L1] N-005", }); expect(prompt).toContain("What is PR-E?"); @@ -339,19 +354,16 @@ describe("buildGroundedPrompt", () => { expect(prompt).toContain("PR-E wires chat to Knowhere retrieval."); expect(prompt).toContain("requirements.txt"); expect(prompt).toContain( - "Use the retrieved source excerpts as helpful context, not as the only allowed information.", + "Use the retrieved evidence as your primary context.", ); - expect(prompt).not.toContain("grounded only in the sources"); + expect(prompt).toContain("Retrieved evidence:"); + expect(prompt).not.toContain("Source excerpts:"); }); it("asks the model to answer naturally and directly", () => { const prompt = buildGroundedPrompt({ question: "How about the TBD?", - results: [ - makeRetrievalResult({ - content: "Roadster location: TBD. Status: Design development.", - }), - ], + evidenceText: "Roadster location: TBD. Status: Design development.", }); expect(prompt).toContain("Answer in a natural, friendly, and direct tone."); diff --git a/src/domains/chat/index.ts b/src/domains/chat/index.ts index 527374d..eea0889 100644 --- a/src/domains/chat/index.ts +++ b/src/domains/chat/index.ts @@ -55,11 +55,13 @@ export const answerQuestionWithRetrieval = ( namespace: input.namespace, query, topK: DEFAULT_TOP_K, + useAgentic: true, ...excludeDocuments(input.sources, input.excludedSourceIds), }), ) - if (response.results.length === 0) { + const evidenceText = response.evidenceText ?? "" + if (response.results.length === 0 && !evidenceText) { return { answer: NO_RESULTS_ANSWER, citations: [] as ChatCitationView[] } } @@ -69,7 +71,7 @@ export const answerQuestionWithRetrieval = ( question, retrievalQuery: query, messages: input.messages, - results, + evidenceText, }), ) return { @@ -77,3 +79,4 @@ export const answerQuestionWithRetrieval = ( citations: toChatCitationViews(results, answer), } }) + diff --git a/src/domains/chat/prompt.ts b/src/domains/chat/prompt.ts index b711c78..cec9fa6 100644 --- a/src/domains/chat/prompt.ts +++ b/src/domains/chat/prompt.ts @@ -1,4 +1,3 @@ -import type { RetrievalResult } from "@ontos-ai/knowhere-sdk" import { generateText } from "ai" import { Effect } from "effect" @@ -23,14 +22,14 @@ type GenerateGroundedAnswerInput = { question: string retrievalQuery: string messages: readonly ChatHistoryMessage[] - results: readonly RetrievalResult[] + evidenceText: string } type BuildGroundedPromptInput = { question: string retrievalQuery?: string messages?: readonly ChatHistoryMessage[] - results: readonly RetrievalResult[] + evidenceText: string } export const generateContextualRetrievalQueryEffect = ( @@ -127,23 +126,11 @@ export function buildRetrievalQueryPrompt( export function buildGroundedPrompt(input: BuildGroundedPromptInput): string { const retrievalQuery = input.retrievalQuery?.trim() || input.question const conversationContext = formatConversationContext(input.messages ?? []) - const sources = input.results - .map((result, index) => { - const sourceName = result.source.sourceFileName ?? "Unknown source" - const section = result.source.sectionPath - ? ` (${result.source.sectionPath})` - : "" - return [ - `[${index + 1}] ${sourceName}${section}`, - result.content, - ].join("\n") - }) - .join("\n\n") return [ "You answer user questions.", - "Use the retrieved source excerpts as helpful context, not as the only allowed information.", - "Cite a source when it supports a claim.", + "Use the retrieved evidence as your primary context.", + "Cite document sections (e.g. [文档名 / 章节名]) when they support a claim.", "If the sources are related but incomplete, answer what you can and briefly say what is not covered.", "Do not invent document-specific facts that are not in the sources.", "Use the recent conversation only to resolve references like \"this document\"; do not use it as factual evidence.", @@ -151,7 +138,7 @@ export function buildGroundedPrompt(input: BuildGroundedPromptInput): string { "Start with the answer first. Avoid meta phrases like \"Based on the sources\" or \"Based on the source excerpts\" unless the user asks how you know.", "Use plain language.", "Keep answers concise by default: 1-3 short paragraphs unless the user asks for detail.", - "CITATION FORMAT: After each sourced statement include a brief citation label like [Source N: what the source says]. Use only the provided source numbers.", + "CITATION FORMAT: Cite evidence by document and section path, e.g. [文档名 / 章节名].", "", `Question: ${input.question}`, `Retrieval query used: ${retrievalQuery}`, @@ -159,8 +146,8 @@ export function buildGroundedPrompt(input: BuildGroundedPromptInput): string { "Recent conversation:", conversationContext, "", - "Source excerpts:", - sources, + "Retrieved evidence:", + input.evidenceText, ].join("\n") } diff --git a/src/domains/chat/service.test.ts b/src/domains/chat/service.test.ts index ae2036a..4aea9a5 100644 --- a/src/domains/chat/service.test.ts +++ b/src/domains/chat/service.test.ts @@ -10,6 +10,12 @@ describe("handleChatTurn", () => { const retrieval = { query: vi.fn().mockResolvedValue({ results: [makeRetrievalResult()], + evidenceText: "Grounding content", + referencedChunks: [], + namespace: "notebook-namespace", + query: "What does the document say?", + routerUsed: "workflow_single_step", + answerText: null, }), }; const repository = makeRepository(); @@ -50,6 +56,7 @@ describe("handleChatTurn", () => { namespace: "notebook-namespace", query: "What does the document say?", topK: 8, + useAgentic: true, excludeDocumentIds: ["doc_excluded"], }); expect(generateRetrievalQuery).toHaveBeenCalledWith({ @@ -65,7 +72,7 @@ describe("handleChatTurn", () => { question: "What does the document say?", retrievalQuery: "What does the document say?", messages: [], - results: [makeRetrievalResult()], + evidenceText: "Grounding content", }); expect(repository.appendMessageToThread).toHaveBeenNthCalledWith(1, "workspace_1", { threadId: "thread_1", @@ -137,6 +144,12 @@ describe("handleChatTurn", () => { const retrieval = { query: vi.fn().mockResolvedValue({ results: [makeRetrievalResult()], + evidenceText: "Grounding content", + referencedChunks: [], + namespace: "notebook-namespace", + query: "Tesla Q4 2025 Update energy generation and storage deployments", + routerUsed: "workflow_single_step", + answerText: null, }), }; const previousMessages = [ @@ -214,6 +227,7 @@ describe("handleChatTurn", () => { namespace: "notebook-namespace", query: "Tesla Q4 2025 Update energy generation and storage deployments", topK: 8, + useAgentic: true, }); }); }); diff --git a/src/domains/chat/types.ts b/src/domains/chat/types.ts index a26dadd..c0920e7 100644 --- a/src/domains/chat/types.ts +++ b/src/domains/chat/types.ts @@ -5,12 +5,12 @@ export type RetrievalResultView = { readonly content: string readonly chunkType: string - readonly score: number + readonly score: number | null readonly assetUrl?: string readonly source: { - readonly documentId?: string - readonly sourceFileName?: string - readonly sectionPath?: string + readonly documentId?: string | null + readonly sourceFileName?: string | null + readonly sectionPath?: string | null } } diff --git a/src/domains/chunks/normalization.ts b/src/domains/chunks/normalization.ts index 1568dd6..4bdaa51 100644 --- a/src/domains/chunks/normalization.ts +++ b/src/domains/chunks/normalization.ts @@ -144,7 +144,7 @@ function getConnectionPosition( function findUniqueBySectionPath( chunks: readonly ParsedChunkView[], - sectionPath: string | undefined, + sectionPath: string | null | undefined, ): ParsedChunkView | null { if (!sectionPath) return null const normalized = normalizeText(sectionPath) diff --git a/src/domains/sources/blob-upload.test.ts b/src/domains/sources/blob-upload.test.ts index e5addf4..b80374e 100644 --- a/src/domains/sources/blob-upload.test.ts +++ b/src/domains/sources/blob-upload.test.ts @@ -4,6 +4,7 @@ import { getSourceUploadBlobPathname, validateSourceBlobUploadInput, } from "./blob-upload"; +import { FILE_TOO_LARGE_MESSAGE, MAX_UPLOAD_BYTES } from "./validation"; describe("source Blob upload metadata", () => { afterEach(() => { @@ -62,4 +63,19 @@ describe("source Blob upload metadata", () => { message: "Invalid upload URL. Choose the document again.", }); }); + + it("rejects staged upload metadata larger than the upload limit", () => { + const result = validateSourceBlobUploadInput({ + pathname: "source-uploads/upload_1/document.pdf", + url: "https://store.public.blob.vercel-storage.com/source-uploads/upload_1/document.pdf", + fileName: "oversized.pdf", + mimeType: "application/pdf", + sizeBytes: MAX_UPLOAD_BYTES + 1, + }); + + expect(result).toEqual({ + ok: false, + message: FILE_TOO_LARGE_MESSAGE, + }); + }); }); diff --git a/src/domains/sources/blob-upload.ts b/src/domains/sources/blob-upload.ts index 309bd7c..4390c19 100644 --- a/src/domains/sources/blob-upload.ts +++ b/src/domains/sources/blob-upload.ts @@ -1,4 +1,5 @@ import { + FILE_TOO_LARGE_MESSAGE, MAX_UPLOAD_BYTES, validateUploadFile, type UploadValidationResult, @@ -123,7 +124,7 @@ export function validateSourceBlobUploadMetadata( if (input.sizeBytes > MAX_UPLOAD_BYTES) { return { ok: false, - message: "File is too large. Upload a document up to 100 MB.", + message: FILE_TOO_LARGE_MESSAGE, }; } diff --git a/src/domains/sources/validation.test.ts b/src/domains/sources/validation.test.ts index 8b82eb2..bbe3c37 100644 --- a/src/domains/sources/validation.test.ts +++ b/src/domains/sources/validation.test.ts @@ -1,12 +1,14 @@ import { describe, expect, it } from "vitest"; import { + FILE_TOO_LARGE_MESSAGE, MAX_UPLOAD_BYTES, + MAX_UPLOAD_MB, validateUploadFile, } from "./validation"; describe("validateUploadFile", () => { - it("accepts supported document extensions within 100 MB", () => { + it("accepts supported document extensions within the upload limit", () => { const result = validateUploadFile({ name: "lecture-notes.PDF", type: "application/pdf", @@ -70,7 +72,7 @@ describe("validateUploadFile", () => { }); }); - it("rejects files larger than the 100 MB limit", () => { + it("rejects files larger than the upload limit", () => { const result = validateUploadFile({ name: "large.pdf", type: "application/pdf", @@ -79,7 +81,8 @@ describe("validateUploadFile", () => { expect(result).toEqual({ ok: false, - message: "File is too large. Upload a document up to 100 MB.", + message: FILE_TOO_LARGE_MESSAGE, }); + expect(MAX_UPLOAD_MB).toBe(300); }); }); diff --git a/src/domains/sources/validation.ts b/src/domains/sources/validation.ts index 8fa0b92..bdeda20 100644 --- a/src/domains/sources/validation.ts +++ b/src/domains/sources/validation.ts @@ -1,4 +1,10 @@ -export const MAX_UPLOAD_BYTES = 100 * 1024 * 1024; +export const MAX_UPLOAD_MB = 300; +export const MAX_UPLOAD_BYTES = MAX_UPLOAD_MB * 1024 * 1024; +export const SUPPORT_EMAIL = "team@knowhereto.ai"; +export const KNOWHERE_ISSUES_URL = "https://github.com/Ontos-AI/knowhere/issues"; +export const FILE_TOO_LARGE_MESSAGE = + `File is too large. Upload a document up to ${MAX_UPLOAD_MB} MB. ` + + `For larger files, contact ${SUPPORT_EMAIL} or open an issue at ${KNOWHERE_ISSUES_URL}.`; const SUPPORTED_EXTENSIONS = new Set([ "doc", @@ -36,7 +42,7 @@ export function validateUploadFile(file: UploadFileInfo): UploadValidationResult if (file.size > MAX_UPLOAD_BYTES) { return { ok: false, - message: "File is too large. Upload a document up to 100 MB.", + message: FILE_TOO_LARGE_MESSAGE, }; }