- Max size: 100 MB + Max size: {MAX_UPLOAD_MB} MB
diff --git a/src/components/sources-panel.test.ts b/src/components/sources-panel.test.ts index bf6daae..068d509 100644 --- a/src/components/sources-panel.test.ts +++ b/src/components/sources-panel.test.ts @@ -24,6 +24,9 @@ import { SourcesPanel } from "./sources-panel"; const C = SourcesPanel as React.FC>; const originalResizeObserver = globalThis.ResizeObserver; +const fileTooLargeMessage = + "File is too large. Upload a document up to 300 MB. " + + "For larger files, contact team@knowhereto.ai or open an issue at https://github.com/Ontos-AI/knowhere/issues."; describe("SourcesPanel", () => { beforeEach(() => { @@ -131,10 +134,10 @@ describe("SourcesPanel", () => { expect( screen.getByText( - /Notebook accepts PDF, DOC, DOCX, TXT, MD, XLS, XLSX, PPTX, images, and more files up to 100 MB/, + /Notebook accepts PDF, DOC, DOCX, TXT, MD, XLS, XLSX, PPTX, images, and more files up to 300 MB/, ), ).toBeTruthy(); - expect(screen.getByText("Max size: 100 MB")).toBeTruthy(); + expect(screen.getByText("Max size: 300 MB")).toBeTruthy(); expect(opened.container.textContent).not.toMatch(/Knowhere|parsing|indexing/i); }); @@ -383,7 +386,7 @@ describe("SourcesPanel", () => { } return Response.json( - { message: "File is too large. Upload a document up to 100 MB." }, + { message: fileTooLargeMessage }, { status: 400 }, ); }); @@ -407,11 +410,7 @@ describe("SourcesPanel", () => { } fireEvent.submit(form); - expect( - await screen.findByText( - "File is too large. Upload a document up to 100 MB.", - ), - ).toBeTruthy(); + expect(await screen.findByText(fileTooLargeMessage)).toBeTruthy(); expect(screen.getByRole("button", { name: "Confirm" })).toBeTruthy(); }); }); diff --git a/src/domains/sources/blob-upload.test.ts b/src/domains/sources/blob-upload.test.ts index e5addf4..b80374e 100644 --- a/src/domains/sources/blob-upload.test.ts +++ b/src/domains/sources/blob-upload.test.ts @@ -4,6 +4,7 @@ import { getSourceUploadBlobPathname, validateSourceBlobUploadInput, } from "./blob-upload"; +import { FILE_TOO_LARGE_MESSAGE, MAX_UPLOAD_BYTES } from "./validation"; describe("source Blob upload metadata", () => { afterEach(() => { @@ -62,4 +63,19 @@ describe("source Blob upload metadata", () => { message: "Invalid upload URL. Choose the document again.", }); }); + + it("rejects staged upload metadata larger than the upload limit", () => { + const result = validateSourceBlobUploadInput({ + pathname: "source-uploads/upload_1/document.pdf", + url: "https://store.public.blob.vercel-storage.com/source-uploads/upload_1/document.pdf", + fileName: "oversized.pdf", + mimeType: "application/pdf", + sizeBytes: MAX_UPLOAD_BYTES + 1, + }); + + expect(result).toEqual({ + ok: false, + message: FILE_TOO_LARGE_MESSAGE, + }); + }); }); diff --git a/src/domains/sources/blob-upload.ts b/src/domains/sources/blob-upload.ts index 309bd7c..4390c19 100644 --- a/src/domains/sources/blob-upload.ts +++ b/src/domains/sources/blob-upload.ts @@ -1,4 +1,5 @@ import { + FILE_TOO_LARGE_MESSAGE, MAX_UPLOAD_BYTES, validateUploadFile, type UploadValidationResult, @@ -123,7 +124,7 @@ export function validateSourceBlobUploadMetadata( if (input.sizeBytes > MAX_UPLOAD_BYTES) { return { ok: false, - message: "File is too large. Upload a document up to 100 MB.", + message: FILE_TOO_LARGE_MESSAGE, }; } diff --git a/src/domains/sources/validation.test.ts b/src/domains/sources/validation.test.ts index 8b82eb2..bbe3c37 100644 --- a/src/domains/sources/validation.test.ts +++ b/src/domains/sources/validation.test.ts @@ -1,12 +1,14 @@ import { describe, expect, it } from "vitest"; import { + FILE_TOO_LARGE_MESSAGE, MAX_UPLOAD_BYTES, + MAX_UPLOAD_MB, validateUploadFile, } from "./validation"; describe("validateUploadFile", () => { - it("accepts supported document extensions within 100 MB", () => { + it("accepts supported document extensions within the upload limit", () => { const result = validateUploadFile({ name: "lecture-notes.PDF", type: "application/pdf", @@ -70,7 +72,7 @@ describe("validateUploadFile", () => { }); }); - it("rejects files larger than the 100 MB limit", () => { + it("rejects files larger than the upload limit", () => { const result = validateUploadFile({ name: "large.pdf", type: "application/pdf", @@ -79,7 +81,8 @@ describe("validateUploadFile", () => { expect(result).toEqual({ ok: false, - message: "File is too large. Upload a document up to 100 MB.", + message: FILE_TOO_LARGE_MESSAGE, }); + expect(MAX_UPLOAD_MB).toBe(300); }); }); diff --git a/src/domains/sources/validation.ts b/src/domains/sources/validation.ts index 8fa0b92..bdeda20 100644 --- a/src/domains/sources/validation.ts +++ b/src/domains/sources/validation.ts @@ -1,4 +1,10 @@ -export const MAX_UPLOAD_BYTES = 100 * 1024 * 1024; +export const MAX_UPLOAD_MB = 300; +export const MAX_UPLOAD_BYTES = MAX_UPLOAD_MB * 1024 * 1024; +export const SUPPORT_EMAIL = "team@knowhereto.ai"; +export const KNOWHERE_ISSUES_URL = "https://github.com/Ontos-AI/knowhere/issues"; +export const FILE_TOO_LARGE_MESSAGE = + `File is too large. Upload a document up to ${MAX_UPLOAD_MB} MB. ` + + `For larger files, contact ${SUPPORT_EMAIL} or open an issue at ${KNOWHERE_ISSUES_URL}.`; const SUPPORTED_EXTENSIONS = new Set([ "doc", @@ -36,7 +42,7 @@ export function validateUploadFile(file: UploadFileInfo): UploadValidationResult if (file.size > MAX_UPLOAD_BYTES) { return { ok: false, - message: "File is too large. Upload a document up to 100 MB.", + message: FILE_TOO_LARGE_MESSAGE, }; }