NullReferenceException in GetPackage() when apiSettings and IntegrationFrameworkWorkflows is initialized as empty list

[TGrigor]

We are experiencing a NullReferenceException when calling GetPackage() after creating a package.

1. Create a DocumentPackage with the following settings:
   DocumentPackage package = PackageBuilder.NewPackageNamed("Test Package") .WithSettings(DocumentPackageSettingsBuilder.NewDocumentPackageSettings() .Build()) .WithSigner(SignerBuilder.NewSignerWithEmail("test@example.com") .WithFirstName("Test") .WithLastName("User") .WithCustomId("SIGNER_123")) .WithDocument(DocumentBuilder.NewDocumentNamed("test.pdf") .FromStream(documentStream, DocumentType.PDF) .WithSignature(SignatureBuilder.SignatureFor("test@example.com") .OnPage(0) .AtPosition(350, 50))) .Build();

2. Create the package successfully:
   PackageId packageId = client.CreatePackage(package);

3.Attempt to retrieve the package:
DocumentPackage retrievedPackage = client.GetPackage(packageId); // NullReferenceException here

Expected Behavior:
The GetPackage() method should successfully retrieve the package without throwing a NullReferenceException.

Actual Behavior:
A NullReferenceException is thrown when accessing the IntegrationFrameworkWorkflows field during package retrieval.

[TGrigor]

Potential fix.

File to Change:
OneSpanSign.Sdk/DocumentPackageSettingsConverter.cs
Change 1: Lines 233-242 (ToSDKPackage method)

BEFORE (causes NullReferenceException):
documentPackageSettingsBuilder.WithCeremonyLayoutSettings(new CeremonyLayoutSettingsConverter(apiSettings.Ceremony.Layout).ToSDKCeremonyLayoutSettings()); foreach (OneSpanSign.API.IntegrationFrameworkWorkflow integrationFrameworkWorkflow in apiSettings.IntegrationFrameworkWorkflows) { documentPackageSettingsBuilder.WithIfWorkflow(IntegrationFrameworkWorkflowConverter.ToSDK(integrationFrameworkWorkflow)); }

AFTER (safe null handling):

`documentPackageSettingsBuilder.WithCeremonyLayoutSettings(new CeremonyLayoutSettingsConverter(apiSettings.Ceremony.Layout).ToSDKCeremonyLayoutSettings());

// Process IntegrationFrameworkWorkflows with null check
if (apiSettings.IntegrationFrameworkWorkflows != null)
{
foreach (OneSpanSign.API.IntegrationFrameworkWorkflow integrationFrameworkWorkflow in apiSettings.IntegrationFrameworkWorkflows)
{
if (integrationFrameworkWorkflow != null)
{
documentPackageSettingsBuilder.WithIfWorkflow(IntegrationFrameworkWorkflowConverter.ToSDK(integrationFrameworkWorkflow));
}
}
}`

Change 2: Lines 94-103 (ToAPIPackage method)
BEFORE (causes NullReferenceException):

IList<OneSpanSign.API.IntegrationFrameworkWorkflow> list = new List<OneSpanSign.API.IntegrationFrameworkWorkflow>(); foreach (IntegrationFrameworkWorkflow integrationFrameworkWorkflow in sdkSettings.IntegrationFrameworkWorkflows) { list.Add(IntegrationFrameworkWorkflowConverter.ToAPI(integrationFrameworkWorkflow)); }

AFTER (safe null handling):

IList<OneSpanSign.API.IntegrationFrameworkWorkflow> list = new List<OneSpanSign.API.IntegrationFrameworkWorkflow>(); if (sdkSettings.IntegrationFrameworkWorkflows != null) { foreach (IntegrationFrameworkWorkflow integrationFrameworkWorkflow in sdkSettings.IntegrationFrameworkWorkflows) { if (integrationFrameworkWorkflow != null) { list.Add(IntegrationFrameworkWorkflowConverter.ToAPI(integrationFrameworkWorkflow)); } } }

[houjianyu]

Thanks @TGrigor , we have created an internal ticket PB-120104 to handle the issue and the potential fix you suggested. We will review and make changes in our next release.