Skip to content

Commit fc0d830

Browse files
committed
fix: update HTTP headers sent to otel endpoints
1 parent 38ba6fb commit fc0d830

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/http/impl/HttpClient.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ import java.net.UnknownHostException
2626
import java.util.Scanner
2727
import javax.net.ssl.HttpsURLConnection
2828

29+
internal const val HTTP_SDK_VERSION_HEADER_KEY = "SDK-Version"
30+
internal val HTTP_SDK_VERSION_HEADER_VALUE = "onesignal/android/${OneSignalUtils.sdkVersion}"
31+
2932
internal class HttpClient(
3033
private val _connectionFactory: IHttpConnectionFactory,
3134
private val _prefs: IPreferencesService,
@@ -131,7 +134,7 @@ internal class HttpClient(
131134
con.useCaches = false
132135
con.connectTimeout = timeout
133136
con.readTimeout = timeout
134-
con.setRequestProperty("SDK-Version", "onesignal/android/" + OneSignalUtils.sdkVersion)
137+
con.setRequestProperty(HTTP_SDK_VERSION_HEADER_KEY, HTTP_SDK_VERSION_HEADER_VALUE)
135138

136139
if (OneSignalWrapper.sdkType != null && OneSignalWrapper.sdkVersion != null) {
137140
con.setRequestProperty("SDK-Wrapper", "onesignal/${OneSignalWrapper.sdkType}/${OneSignalWrapper.sdkVersion}")

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/otel/OneSignalOpenTelemetry.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package com.onesignal.debug.internal.logging.otel
33
import android.os.Build
44
import androidx.annotation.RequiresApi
55
import com.onesignal.core.internal.config.ConfigModelStore
6+
import com.onesignal.core.internal.http.impl.HTTP_SDK_VERSION_HEADER_KEY
7+
import com.onesignal.core.internal.http.impl.HTTP_SDK_VERSION_HEADER_VALUE
68
import com.onesignal.debug.internal.logging.otel.attributes.OneSignalOtelFieldsPerEvent
79
import com.onesignal.debug.internal.logging.otel.attributes.OneSignalOtelFieldsTopLevel
810
import com.onesignal.debug.internal.logging.otel.config.OtelConfigCrashFile
@@ -71,7 +73,8 @@ internal class OneSignalOpenTelemetryRemote(
7173
IOneSignalOpenTelemetryRemote {
7274
val extraHttpHeaders by lazy {
7375
mapOf(
74-
"OS-App-Id" to _configModelStore.model.appId,
76+
"X-OneSignal-App-Id" to _configModelStore.model.appId,
77+
HTTP_SDK_VERSION_HEADER_KEY to HTTP_SDK_VERSION_HEADER_VALUE,
7578
"x-honeycomb-team" to "", // TODO: REMOVE
7679
)
7780
}

0 commit comments

Comments
 (0)