Skip to content

Commit da3517c

Browse files
authored
chore: Bump firebase-messaging to 24.0.0 (#2149)
1 parent f13f150 commit da3517c

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

OneSignalSDK/onesignal/notifications/build.gradle

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,22 @@ dependencies {
7474

7575
compileOnly('com.amazon.device:amazon-appstore-sdk:[3.0.1, 3.0.99]')
7676

77-
// firebase-messaging:21.0.0 introduces FirebaseMessaging.getToken API
78-
// firebase-messaging:23.0.0 incoporates fix for SecurityException: Not allowed to bind to service
77+
// NOTE: firebase-messaging:24.0.0 requires customer's project to use
78+
// compileSdkVersion 34 or higher.
7979
api('com.google.firebase:firebase-messaging') {
8080
version {
81-
require '[21.0.0, 23.4.99]'
82-
prefer '23.4.0'
81+
require '[23.0.8, 24.0.99]'
82+
prefer '24.0.0'
8383
}
8484
}
85+
// Needed for GoogleApiAvailability
86+
// Using compileOnly as firebase-messaging already includes this as a
87+
// runtime dependency and we don't want to change what version is used in
88+
// the customer's app. (firebase-messaging:24.0.0 is when this dependency
89+
// changed to runtime)
90+
// NOTE: If you change the firebase-messaging version you may need to
91+
// bump this version if you get a compile error when building the SDK.
92+
compileOnly('com.google.android.gms:play-services-base:18.0.1')
8593

8694
// Huawei PushKit
8795
// KEEP as "compileOnly", so OneSignal isn't a direct dependency in the POM file.

0 commit comments

Comments
 (0)