Spec review: route-ids-for-agency

[burma-shave]

What to review

Read the wiki spec and compare the full Maglev implementation of this endpoint against it. Look for:

• Request parameters: all params supported with correct types, defaults, and validation
• Response structure: all fields present with correct names, types, and nesting
• Error handling: error cases match the spec (404, 400, etc.)
• Behaviour: the endpoint behaves as the spec describes, including edge cases
• Test coverage: main scenarios and edge cases from the spec are covered by tests

Workflow

1. Compare the implementation against the wiki spec. If no gaps found, move this card to Done.
2. For each gap or bug, file a GitHub issue labelled spec-gap, link it to this card, and assign it to yourself.
3. Move this card to Issues Filed.
4. Work on the issues you filed.
5. Once all linked issues are closed, move this card back to In Review and repeat from step 1.

Deeper analysis

The skills at https://github.com/burma-shave/maglev-workspace can help when the spec or implementation behaviour is not clear. They analyse the Java OBA reference implementation by downloading, building, and running the server — enabling both static and runtime analysis.

Install them into your coding agent (e.g. Claude Code). Key capabilities:

• Q&A mode: ask arbitrary questions about this endpoint and get answers grounded in the Java source and live server behaviour
• Spec generation: regenerate or cross-check the spec directly from the Java source

Requirements: Docker and Git
Note: the skills are token-intensive and trigger many permission prompts — a VM or sandbox environment is recommended