Fix with pattern matching and fresh game reloads

Author: khushal-winner

copi.owasp.org/lib/copi_web/live/player_live/show.ex

@@ -124,53 +124,62 @@ defmodule CopiWeb.PlayerLive.Show do
           end
         end
 
-        CopiWeb.Endpoint.broadcast(topic(game.id), "game:updated", game)
+        # Reload fresh game record after continue vote mutations
+        {:ok, updated_game} = Copi.Cornucopia.Game.find(game_id)
 
-        {:noreply, assign(socket, :game, game)}
+        CopiWeb.Endpoint.broadcast(topic(updated_game.id), "game:updated", updated_game)
+
+        {:noreply, assign(socket, :game, updated_game)}
       end
     else
-      {:noreply, socket}
+      {:error, _reason} -> {:noreply, socket}
     end
   end
 
   @impl true
   def handle_event("toggle_vote", %{"dealt_card_id" => dealt_card_id}, socket) do
-    game = socket.assigns.game
     player = socket.assigns.player
-
-    # Validate game lifecycle - voting only allowed during active games
-    unless Copi.Cornucopia.Game.game_active?(game) do
-      Logger.warning("Voting attempt on inactive game: player_id: #{player.id}, game_id: #{game.id}, started_at: #{game.started_at}, finished_at: #{game.finished_at}")
-      {:noreply, socket}
-    else
-      {:ok, dealt_card} = DealtCard.find(dealt_card_id)
-      
-      # Validate that dealt card belongs to current game
-      unless dealt_card_belongs_to_game?(dealt_card, game) do
-        Logger.warning("Unauthorized voting attempt: player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
+    game_id = socket.assigns.player.game_id
+    
+    # Load fresh game record from DB to avoid stale socket assigns
+    with {:ok, game} <- Copi.Cornucopia.Game.find(game_id) do
+      # Validate game lifecycle - voting only allowed during active games
+      unless Copi.Cornucopia.Game.game_active?(game) do
+        Logger.warning("Voting attempt on inactive game: player_id: #{player.id}, game_id: #{game.id}, started_at: #{game.started_at}, finished_at: #{game.finished_at}")
         {:noreply, socket}
       else
-        vote = get_vote(dealt_card, player)
-
-        if vote do
-          Logger.debug("Player has voted: player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
-          Copi.Repo.delete!(vote)
+        {:ok, dealt_card} = DealtCard.find(dealt_card_id)
+        
+        # Validate that dealt card belongs to current game
+        unless dealt_card_belongs_to_game?(dealt_card, game) do
+          Logger.warning("Unauthorized voting attempt: player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
+          {:noreply, socket}
         else
-          Logger.debug("Player has not voted: player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
-          case Copi.Repo.insert(%Copi.Cornucopia.Vote{dealt_card_id: String.to_integer(dealt_card_id), player_id: player.id}) do
-            {:ok, _vote} ->
-              Logger.debug("Vote added successfully for player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
-            {:error, changeset} ->
-              Logger.warning("Voting failed for player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}, errors: #{inspect(changeset.errors)}")
+          vote = get_vote(dealt_card, player)
+
+          if vote do
+            Logger.debug("Player has voted: player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
+            Copi.Repo.delete!(vote)
+          else
+            Logger.debug("Player has not voted: player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
+            case Copi.Repo.insert(%Copi.Cornucopia.Vote{dealt_card_id: String.to_integer(dealt_card_id), player_id: player.id}) do
+              {:ok, _vote} ->
+                Logger.debug("Vote added successfully for player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}")
+              {:error, changeset} ->
+                Logger.warning("Voting failed for player_id: #{player.id}, dealt_card_id: #{dealt_card_id}, game_id: #{game.id}, errors: #{inspect(changeset.errors)}")
+            end
           end
-        end
 
-        {:ok, updated_game} = Game.find(game.id)
+          # Reload fresh game record after vote mutations
+          {:ok, updated_game} = Copi.Cornucopia.Game.find(game_id)
 
-        CopiWeb.Endpoint.broadcast(topic(updated_game.id), "game:updated", updated_game)
+          CopiWeb.Endpoint.broadcast(topic(updated_game.id), "game:updated", updated_game)
 
-        {:noreply, assign(socket, :game, updated_game)}
+          {:noreply, assign(socket, :game, updated_game)}
+        end
       end
+    else
+      {:error, _reason} -> {:noreply, socket}
     end
   end