Skip to content

Commit fecbdde

Browse files
ginbergschuemieAdmin_mschuemi
authored
Release v3.12.0 (#317)
* fix setting of continous covariates in case of multiple settings and add a test * update test * Optimizing tidyCovariates for large data. Fixes #308 (#309) Co-authored-by: ginberg <ginberg@gmail.com> Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com> * cran submission file * add params to getDBCovariateData (#312) * #292 add function to replace cohort schema and table * #292 add params * add test * doc * v3.11.0 * update news * Making removal of redundant covariates reproducible (with unit test). Fixes #315 (#316) Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com> * version update * prepare release * CRAN file --------- Co-authored-by: Martijn Schuemie <schuemie@ohdsi.org> Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>
1 parent 0773972 commit fecbdde

61 files changed

Lines changed: 176 additions & 131 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CRAN-SUBMISSION

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
Version: 3.11.0
2-
Date: 2025-09-01 15:11:02 UTC
3-
SHA: 784c4a8dcda6fc0301c8b0823efdfccb1291745e
1+
Version: 3.12.0
2+
Date: 2025-10-28 09:25:00 UTC
3+
SHA: 0fb802cd699b4e4ec12b59f3d7f232c5d236cecf

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Package: FeatureExtraction
22
Type: Package
33
Title: Generating Features for a Cohort
4-
Version: 3.11.0
5-
Date: 2025-09-01
4+
Version: 3.12.0
5+
Date: 2025-10-28
66
Authors@R: c(
77
person("Martijn", "Schuemie", , "schuemie@ohdsi.org", role = c("aut")),
88
person("Marc", "Suchard", role = c("aut")),

NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
FeatureExtraction 3.12.0
2+
=======================
3+
4+
- Fix non reproducible behavior in removing redundant covariates when they are equally prevalent (#315)
5+
16
FeatureExtraction 3.11.0
27
=======================
38

R/Normalization.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ tidyCovariateData <- function(covariateData,
159159
inner_join(covariateData$valueCounts, by = "covariateId") %>%
160160
select(.data$analysisId, .data$covariateId, n) %>%
161161
collect()
162-
valueCounts <- valueCounts[order(valueCounts$analysisId, -valueCounts$n), ]
162+
valueCounts <- valueCounts[order(valueCounts$analysisId, -valueCounts$n, valueCounts$covariateId), ]
163163
deleteCovariateIds <- c(deleteCovariateIds, valueCounts$covariateId[!duplicated(valueCounts$analysisId)])
164164
ignoreCovariateIds <- valueCounts$covariateId
165165
ParallelLogger::logInfo("Removing ", length(deleteCovariateIds), " redundant covariates")

docs/404.html

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/articles/CreatingCovariatesBasedOnOtherCohorts.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/articles/CreatingCovariatesUsingCohortAttributes.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/articles/CreatingCustomCovariateBuilders.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/articles/CreatingCustomCovariateBuildersKorean.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/articles/UsingFeatureExtraction.html

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)