Skip to content

[17.0] password_security: do_signup() got an unexpected keyword argument 'validate_email' #939

@tgaullier

Description

@tgaullier

Module

password_security

Describe the bug

When a user clicks on the password reset link received by email and submits the form, the request crashes with:

TypeError: PasswordSecurityHome.do_signup() got an unexpected keyword argument 'validate_email'

This happens because Odoo 17's standard auth_signup module calls do_signup(qcontext, validate_email=False) (see odoo/addons/auth_signup/controllers/main.py), but password_security's override of do_signup does not accept this keyword argument.

Note: this bug is reproducible with password_security alone, no other OCA auth module needs to be installed.

To Reproduce

Affected versions: 17.0

Steps to reproduce the behavior:

  1. Install password_security on an Odoo 17 instance
  2. Trigger a password reset for any user (e.g. via "Send Password Reset Instructions" on the user form)
  3. Click on the reset link received by email
  4. Fill in the new password and submit the form

Expected behavior
The password should be reset successfully and the user should be redirected to the login page (or logged in).

Additional context
A PR with the fix will follow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions