[MIG] sql_request_abstract: Migration to 19.0

Author: lef-adhoc

sql_request_abstract/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 ====================
 SQL Request Abstract
 ====================
@@ -13,44 +17,44 @@ SQL Request Abstract
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Freporting--engine-lightgray.png?logo=github
-    :target: https://github.com/OCA/reporting-engine/tree/18.0/sql_request_abstract
+    :target: https://github.com/OCA/reporting-engine/tree/19.0/sql_request_abstract
     :alt: OCA/reporting-engine
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-sql_request_abstract
+    :target: https://translation.odoo-community.org/projects/reporting-engine-19-0/reporting-engine-19-0-sql_request_abstract
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/reporting-engine&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/reporting-engine&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
 This module provides an abstract model to manage SQL Select requests on
-database. It is not usefull for itself. You can see an exemple of
+database. It is not usefull for itself. You can see an example of
 implementation in the 'sql_export' module. (same repository).
 
 Implemented features
 --------------------
 
--  Add some restrictions in the sql request:
+- Add some restrictions in the sql request:
 
-   -  you can only read datas. No update, deletion or creation are
-      possible.
-   -  some tables are not allowed, because they could contains clear
-      password or keys. For the time being ('ir_config_parameter').
+  - you can only read datas. No update, deletion or creation are
+    possible.
+  - some tables are not allowed, because they could contains clear
+    password or keys. For the time being ('ir_config_parameter').
 
--  The request can be in a 'draft' or a 'SQL Valid' status. To be valid,
-   the request has to be cleaned, checked and tested. All of this
-   operations can be disabled in the inherited modules.
+- The request can be in a 'draft' or a 'SQL Valid' status. To be valid,
+  the request has to be cleaned, checked and tested. All of this
+  operations can be disabled in the inherited modules.
 
--  This module two new groups:
+- This module adds two new groups:
 
-   -  SQL Request / User : Can see all the sql requests by default and
-      execute them, if they are valid.
-   -  SQL Request / Manager : has full access on sql requests.
+  - SQL Request / User : Can see all the sql requests by default and
+    execute them, if they are valid.
+  - SQL Request / Manager : has full access on sql requests.
 
 **Table of contents**
 
@@ -103,7 +107,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/reporting-engine/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/reporting-engine/issues/new?body=module:%20sql_request_abstract%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/reporting-engine/issues/new?body=module:%20sql_request_abstract%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -119,18 +123,12 @@ Authors
 Contributors
 ------------
 
--  Florian da Costa <florian.dacosta@akretion.com>
--  Sylvain LE GAL (https://twitter.com/legalsylvain)
--  Alfadil Tabar (alfadil.tabar@gmail.com)
--  Helly kapatel <helly.kapatel@initos.com>
--  Nguyen Minh Chien <chien@trobz.com>
--  Vo Hong Thien <thienvh@trobz.com>
-
-Other credits
--------------
-
-The migration of this module from 17.0 to 18.0 was financially supported
-by Camptocamp.
+- Florian da Costa <florian.dacosta@akretion.com>
+- Sylvain LE GAL (https://twitter.com/legalsylvain)
+- Alfadil Tabar (alfadil.tabar@gmail.com)
+- Helly kapatel <helly.kapatel@initos.com>
+- Nguyen Minh Chien <chien@trobz.com>
+- Vo Hong Thien <thienvh@trobz.com>
 
 Maintainers
 -----------
@@ -153,6 +151,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-legalsylvain| 
 
-This module is part of the `OCA/reporting-engine <https://github.com/OCA/reporting-engine/tree/18.0/sql_request_abstract>`_ project on GitHub.
+This module is part of the `OCA/reporting-engine <https://github.com/OCA/reporting-engine/tree/19.0/sql_request_abstract>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sql_request_abstract/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "SQL Request Abstract",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "author": "GRAP,Akretion,Odoo Community Association (OCA)",
     "maintainers": ["legalsylvain"],
     "website": "https://github.com/OCA/reporting-engine",

sql_request_abstract/models/sql_request_mixin.py

@@ -12,7 +12,7 @@
 from psycopg2 import ProgrammingError
 from psycopg2.sql import SQL
 
-from odoo import _, api, fields, models, tools
+from odoo import api, fields, models, tools
 from odoo.exceptions import UserError, ValidationError
 
 from ..sql_db import get_external_cursor
@@ -87,7 +87,7 @@ def _default_user_ids(self):
         relation=_sql_request_groups_relation,
         column1="sql_id",
         column2="group_id",
-        default=_default_group_ids,
+        default=lambda self: self._default_group_ids(),
     )
 
     user_ids = fields.Many2many(
@@ -96,7 +96,7 @@ def _default_user_ids(self):
         relation=_sql_request_users_relation,
         column1="sql_id",
         column2="user_id",
-        default=_default_user_ids,
+        default=lambda self: self._default_user_ids(),
     )
     use_external_database = fields.Boolean(
         help=(
@@ -112,7 +112,7 @@ def check_external_config(self):
             external_db_name = tools.config.get("external_db_name")
             if not external_db_name:
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "You can't use an external database as there are no such "
                         "configuration about this. Please contact "
                         "your Odoo administrator to solve this issue."
@@ -200,7 +200,9 @@ def _execute_sql_request(
         res = False
         # Check if the request is in a valid state
         if self.state == "draft":
-            raise UserError(_("It is not allowed to execute a not checked request."))
+            raise UserError(
+                self.env._("It is not allowed to execute a not checked request.")
+            )
 
         # Disable rollback if a creation of a view is asked
         if mode in ("view", "materialized_view"):
@@ -222,7 +224,7 @@ def _execute_sql_request(
                 SQL(query), SQL(view_name)
             )
         else:
-            raise UserError(_("Unimplemented mode : '%s'") % mode)
+            raise UserError(self.env._("Unimplemented mode : '%s'", mode))
 
         query_cr = self._get_cr_for_query()
 
@@ -280,11 +282,11 @@ def _check_materialized_view_available(self):
         minor_version = float(".".join(res[:2]))
         if minor_version < 9.3:
             raise UserError(
-                _(
+                self.env._(
                     "Materialized View requires PostgreSQL 9.3 or greater but"
-                    " PostgreSQL %s is currently installed."
+                    " PostgreSQL %s is currently installed.",
+                    minor_version,
                 )
-                % (minor_version)
             )
 
     def _clean_query(self):
@@ -304,8 +306,10 @@ def _check_prohibited_words(self):
             is_not_safe = re.search(expr, query)
             if is_not_safe:
                 raise UserError(
-                    _("The query is not allowed because it contains unsafe word '%s'")
-                    % (word)
+                    self.env._(
+                        "The query is not allowed because it contains unsafe word '%s'",
+                        word,
+                    )
                 )
 
     def _check_execution(self):
@@ -321,7 +325,7 @@ def _check_execution(self):
             res = self._hook_executed_request()
         except ProgrammingError as e:
             logger.exception("Failed query: %s", query)
-            raise UserError(_("The SQL query is not valid:\n\n %s") % e) from e
+            raise UserError(self.env._("The SQL query is not valid:\n\n %s", e)) from e
         finally:
             self._rollback_savepoint(rollback_name, query_cr)
         return res

sql_request_abstract/readme/CREDITS.md

@@ -1,5 +1,5 @@
 This module provides an abstract model to manage SQL Select requests on
-database. It is not usefull for itself. You can see an exemple of
+database. It is not usefull for itself. You can see an example of
 implementation in the 'sql_export' module. (same repository).
 
 ## Implemented features
@@ -14,7 +14,7 @@ implementation in the 'sql_export' module. (same repository).
   the request has to be cleaned, checked and tested. All of this
   operations can be disabled in the inherited modules.
 
-- This module two new groups:  
+- This module adds two new groups:  
   - SQL Request / User : Can see all the sql requests by default and
     execute them, if they are valid.
   - SQL Request / Manager : has full access on sql requests.

sql_request_abstract/readme/DESCRIPTION.md

@@ -3,4 +3,9 @@
     <record model="ir.module.category" id="category_sql_abstract">
         <field name="name">SQL Request</field>
     </record>
+
+    <record model="res.groups.privilege" id="privilege_sql_request">
+        <field name="name">SQL Request</field>
+        <field name="category_id" ref="category_sql_abstract" />
+    </record>
 </odoo>

sql_request_abstract/security/ir_module_category.xml

@@ -7,12 +7,15 @@ License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 <odoo>
     <record model="res.groups" id="group_sql_request_user">
         <field name="name">User</field>
-        <field name="category_id" ref="category_sql_abstract" />
+        <field name="privilege_id" ref="privilege_sql_request" />
     </record>
     <record model="res.groups" id="group_sql_request_manager">
         <field name="name">Manager</field>
-        <field name="category_id" ref="category_sql_abstract" />
-        <field name="users" eval="[(4, ref('base.user_admin'))]" />
-        <field name="implied_ids" eval="[(4, ref('group_sql_request_user'))]" />
+        <field name="privilege_id" ref="privilege_sql_request" />
+        <field name="user_ids" eval="[Command.link(ref('base.user_admin'))]" />
+        <field
+            name="implied_ids"
+            eval="[Command.link(ref('group_sql_request_user'))]"
+        />
     </record>
 </odoo>