Support for logging libraries other than Logback

[iljakorneckis]

I tried using this library in my project at work. Alas, the project uses Log4j as the logging library - which leads to an exception in the constructor of the LogRecorder (a NoClassDefFound in case of the test project attached below):

public LogRecorder(Class<?> type) {
    this.logger = (Logger) LoggerFactory.getLogger(type);
}

I tried changing the Logger type from the Logback (ch.qos.logback.classic.Logger) one to the SLF4J interface (org.slf4j.Logger), but that doesn't have the addAppender method :/

Since this could be quite an undertaking, I suggest adding to the Readme that only Logback is supported for now, to avoid confusion.

I have attached an example project that uses Log4j2 below.
Log4j2Project.zip

[Nylle]

I was afraid of that. I'll have a look.

[akutschera]

When I look at the actual error, it is a
java.lang.NoClassDefFoundError: org/slf4j/spi/LoggingEventAware. That is not a problem with Logsert using logback, it is a problem with Logsert using slf4j-api:2.0.7 That library contains the LoggingEventAware while version 1.7.36 (the one you are using in your project) does not (and maven uses 1.7.36 as an override in the dependency management).
Now you could update that version and make the test green, but then your application won't log because your log4j-bindings still need slfj4 version 1.7.x.
So until Logsert can handle slf4j-api:1.7.x as well, I am afraid you cannot use it.

So I looked at MessageAssert. Except for a ch.qos.logback.classic.Level (log level), which could easily be changed to an org.slf4j.event.Level, the interface is already logging-library-agnostic.

What we could do is create a class e.g.

public class ListAppender implements org.slf4j.spi.LocationAwareLogger {

    public List<LoggingEvent> getLoggedEvents() {
        return events;
    }
}

and implement the interfaces so we have our own in-memory slf4j implementation. Then we can get rid of the logback dependencies of logsert altogether.

[jk-idealo]

Unfortunately, we're not so agnostic any longer. With the recent updates, Logsert is now depending on

• ch.qos.logback.classic.Level
• ch.qos.logback.classic.Logger
• ch.qos.logback.classic.spi.ILoggingEvent
• ch.qos.logback.classic.spi.IThrowableProxy

I'll see if we can move away to a more abstract implementation based on org.slf4j.