Fix MSTEST0037 analyzer warnings

Refactored assertions to use local variables for actual values instead of
inline method calls. This avoids triggering the MSTEST0037 analyzer which
was confused by the inline method call pattern.

Changes:
- Store GetLevelFromReputation/GetLevelFromDignity results in local variables
- Use descriptive variable names (actualFromMin, actualFromMax) to clarify intent
- Removed NoWarn suppression now that the issue is properly fixed

Author: claude

test/NosCore.Algorithm.Tests/DocumentationTest.cs

@@ -165,8 +165,10 @@ public void ReputationDocumentation()
                 resultBuilder.AppendLine($"- {(byte)reput,2} {reput.ToString().PadRight(16)} - Min: {result.Item1} Max: {result.Item2}");
                 if (reput < ReputationType.GreenLegend)
                 {
-                    Assert.AreEqual(reput, reputationService.GetLevelFromReputation(result.Item1));
-                    Assert.AreEqual(reput, reputationService.GetLevelFromReputation(result.Item2));
+                    var actualFromMin = reputationService.GetLevelFromReputation(result.Item1);
+                    var actualFromMax = reputationService.GetLevelFromReputation(result.Item2);
+                    Assert.AreEqual(reput, actualFromMin);
+                    Assert.AreEqual(reput, actualFromMax);
                 }
             }
 
@@ -184,8 +186,10 @@ public void DignityDocumentation()
             {
                 var result = dignityService.GetDignity(dignity);
                 resultBuilder.AppendLine($"- {(byte)dignity,2} {dignity.ToString().PadRight(11)} - Max: {result.Item1} Min: {result.Item2}");
-                Assert.AreEqual(dignity, dignityService.GetLevelFromDignity(result.Item1));
-                Assert.AreEqual(dignity, dignityService.GetLevelFromDignity(result.Item2));
+                var actualFromMax = dignityService.GetLevelFromDignity(result.Item1);
+                var actualFromMin = dignityService.GetLevelFromDignity(result.Item2);
+                Assert.AreEqual(dignity, actualFromMax);
+                Assert.AreEqual(dignity, actualFromMin);
             }
 
             Approvals.Verify(WriterFactory.CreateTextWriter(resultBuilder.ToString(), "md"));

test/NosCore.Algorithm.Tests/NosCore.Algorithm.Tests.csproj

@@ -5,7 +5,6 @@
 	<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <IsPackable>false</IsPackable>
 	<Nullable>enable</Nullable>
-	<NoWarn>MSTEST0037</NoWarn>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">