add plugin install feature, fix dependencies#14
Conversation
|
/cc @nuhakala |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR introduces a plugin installation feature for standalone IPA (Ironic Python Agent) python plugins and updates several dependencies and version references. The main additions include a new ipa-plugin-installer element that allows copying and installing custom hardware managers/plugins into the IPA image during the build process.
Changes:
- Adds new
ipa-plugin-installerelement with scripts to copy and install custom IPA plugins - Updates SLES version references from SP4/SP5 to SP6 throughout the codebase
- Modernizes nmstate build process with updated rust toolchain installation
- Corrects NetworkManager-ovs package download URL path
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| testenv.sh | Updates IPA branch references and SLES version to SP6 |
| ipa_builder_elements/sles-ipa-install/install.d/ironic-python-agent-ramdisk-source-install/60-ironic-python-agent-ramdisk-install | Updates nmstate build with rust toolchain setup and fixes NetworkManager-ovs URL |
| ipa_builder_elements/ipa-plugin-installer/root.d/99-cp-custom-reboot | New script to copy plugin directories from host to build environment |
| ipa_builder_elements/ipa-plugin-installer/install.d/99-install-hardware-managers | New script to install plugins into IPA virtual environment |
| ipa_builder_elements/ipa-plugin-installer/environment.d/10-hw-manager-defaults | Sets default environment variables for plugin installation |
| build_ipa_sles.sh | Integrates plugin installer element into build process |
| README.md | Updates SLES version references in documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nuhakala
left a comment
nuhakala
left a comment
There was a problem hiding this comment.
Should the new env variables that are used to configure plugins be documented in readme? They are easy to read from the code as well, but then the readme would become outdated.
DIB_IPA_PLUGINS-> comma separated list with no spacesINCLUDE_PLUGINSPLUGIN_INSTALLER
|
/hold |
I agree, I will add the new vars to the README. |
Rozzii
force-pushed
the
plugin_management
branch
2 times, most recently
from
d5aaf2e to
0955366
Compare
Rozzii
force-pushed
the
plugin_management
branch
from
0955366 to
a1ef3b7
Compare
|
/hold cancel |
This commit: - Introduces a new build element that will facilitate the installation of standalone IPA python plugins. - In some parts of the repo the SLES-15-SP5 and SP4 were referenced instead of SP6, this commit fixes the issue. - Nmstate build process was also deprecated, it is now updated to make sure rust build tool-chain is up to date to build new Nmstate version. - Network manager ovs plugin download url has changed, it is now updated in this commit Signed-off-by: Adam Rozman <adam.rozman@est.tech>
Rozzii
force-pushed
the
plugin_management
branch
from
a1ef3b7 to
96fc037
Compare
|
/lgtm |
This PR: