Doesn't work if extensions.webextensions.remote = true

[pintassilgo]

Firefox 56

[Noitidart]

Things changed a lot. Only hope now is the re-write as an electron app - https://github.com/Noitidart/NativeShotDesktop - i use this addon heavily so i badly need to finish this.

[pintassilgo]

My mistake, sorry. Native Shot is working fine here in 58.0b1 with extensions.webextensions.remote = true and I didn't change anything WebExt related, just basic things to fix 57+ compatibility.

[Noitidart]

Oh wow thanks for sharing this! I had no idea that worked! :)

[Noitidart]

@pintassilgo may you please share the things you changed to get NativeShot to work, I badly need to use it as well haha.

[pintassilgo]

@Noitidart hehe

resources\scripts\MainFramescript.js
Replace aURI.path by aURI.pathQueryRef (lines 340 and 341).

bootstrap.js
Replace Ci.nsILocalFile by Ci.nsIFile

resources\pages\editor.xhtml
Bug 863246, so I saved resource://gre/modules/Geometry.jsm in resources\scripts, then replaced
<script src="resource://gre/modules/Geometry.jsm"></script>
by
<script src="chrome://nativeshot/content/resources/scripts/Geometry.jsm"></script>
OR simply set security.all_resource_uri_content_accessible = true, but this is not recommended.

And there's the two required SDK files (clipboard and locale) that I inserted in bootstrap.js. Ugly, I know, but it works, I didn't bother to find a more elegant solution. The final bootstrap.js:
https://gist.github.com/pintassilgo/4deb9d0cbcba625a85aec1f1ed64f747

Tell me if it works for you. I tested some days ago on Nightly, but I use Dev Edition and it is working fine here.

PS.: I'm this one.

[pintassilgo]

Updated. Now Ctrl+C is working.

[pintassilgo]

With extensions.webextensions.remote = true, sometimes NativeShot works, sometimes not. There's no error log on the console. The definition occurs on Firefox startup. When it doesn't work at first, restarting the extension doesn't help. You must restart Firefox and hope for luck.

But with extensions.webextensions.remote = false, NativeShot always works flawlessly.

[Noitidart]

Holy moly thank you @pintassilgo - excuse my delay I missed those replies! I will definitely make those change I need this back so bad!

[Noitidart]

Nooo way you are tustamido! Thank you so much for your long time support!!!

[Noitidart]

@pintassilgo may you please upload your hacked version, I am sooo busy I couldn't get around to it. :(

[pintassilgo]

https://drive.google.com/open?id=1lOPOoKGcyso_kXYq0FqjxykvIEk2l6rD

Tested in Fx 58.0b10 64-bit (current Developer Edition), Windows 10.

[Noitidart]

So so much love thank you @pintassilgo!!!

[Noitidart]

Thanks so much @pintassilgo !

Reminder for self:

Need to set prefs:

• extensions.webextensions.remote to false
• extensions.legacy.enabled to true

I had to increase max version so I did that and attached it here:

NativeShot@jetpack.zip