QA: Fix non-interactive guards, logic fallthroughs, README, and docs

[naman485]

Context

5-agent parallel QA audit of PR #13 found 65 issues. This issue covers the 14 HIGH-priority items that require Bhautik's context on the interactive UX patterns, plus README/docs fixes.

These should be fixed before public launch (but don't block merging PR #13 — the CRITICALs in #14 block merge).

---

Part 1: Non-Interactive Guards (8 issues)

Every command using pterm.DefaultInteractiveSelect or pterm.DefaultInteractiveConfirm will crash or hang in CI/pipes/non-TTY environments. Each needs:

1. A terminal.IsInteractive() check before the interactive call
2. A --force flag (for destructive commands) or a clear error message telling users to pass flags

H4: domains delete — no --force flag

File: cmd/domains/domains_delete.go:32
Fix: Add --force flag. If !terminal.IsInteractive() && !c.Bool("force") → return error: "non-interactive mode: use --force to confirm deletion"

H5: domains add — pickEnvironment crashes in non-TTY

File: cmd/domains/helpers.go:85
Fix: If !terminal.IsInteractive() and --environment not set → return error: "non-interactive mode: use --environment flag"

H6: domains verify — pickDomain crashes in non-TTY

File: cmd/domains/helpers.go:32
Fix: If !terminal.IsInteractive() and no domain arg/flag → return error: "non-interactive mode: use --domain flag"

H7: open — multi-env/deployment selector crashes in non-TTY

File: cmd/open/open.go:96-129
Fix: If !terminal.IsInteractive() and multiple envs/deployments → use the first one (or error with suggestion to pass --project)

H8: init — project/env selector crashes in non-TTY

File: cmd/init/init.go:41-114
Fix: If !terminal.IsInteractive() and --project not set → return error: "non-interactive mode: use --project flag"

H9: deployments cancel — no --force flag

File: cmd/deployments/deployments_delete.go:31
Fix: Same pattern as H4 — add --force flag with non-interactive guard.

H10: deployments zero-args — pickDeployment crashes in non-TTY

File: cmd/deployments/helpers.go:20
Fix: If !terminal.IsInteractive() and no args → return error suggesting positional args or --deployment flag.

H-extra: environments delete — no --force flag (found by UX audit)

File: cmd/environments/environments_delete.go:32-42
Fix: Same pattern — add --force flag. NOTE: The README CI examples already reference --force on this command but the flag doesn't exist yet.

---

Part 2: Logic Fallthroughs (2 issues)

H11: env/helpers.go select-loop fallthrough

File: cmd/env/helpers.go:60-65
Problem: If the interactive select loop completes without matching (shouldn't happen normally), the function falls through with empty envID → API call with empty ID → confusing 404.
Fix: Add return "", nil, fmt.Errorf("no environment selected") after the select loop.

H12: scale.go same fallthrough

File: cmd/scale/scale.go:92-97
Problem: Same pattern — select loop fallthrough leaves envID empty.
Fix: Add return "", "", fmt.Errorf("no environment selected") after the select loop.

---

Part 3: README & Documentation (4 issues)

R1: Three broken CI examples in README

File: README.md — "Non-interactive / CI usage" section
Problem: These examples reference flags that don't exist on the commands:

• createos projects get --project <id> → projects get has no --project flag
• createos deployments logs --project <id> --deployment <id> → no such flags
• createos deployments retrigger --project <id> --deployment <id> → no such flags

Fix (choose one):

• A) Add --project and --deployment flags to these commands (preferred — matches other command groups)
• B) Change README examples to use positional args: createos projects get <id>

R2: Cronjobs section missing from README

Problem: 8 cronjob subcommands (list, get, create, update, delete, suspend, unsuspend, activities) are completely undocumented in the README.
Fix: Add a "Cron Jobs" section to README with all subcommands + CI examples.

R3: oauth-clients delete missing from README

Problem: The OAuth Clients table lists list, create, instructions but not delete.
Fix: Add createos oauth-clients delete | Delete an OAuth client row.

R4: Home screen me out of alphabetical order

File: cmd/root/root.go:138-139
Problem: me appears after templates. Should be between logout and oauth-clients.
Fix: Move the line.

---

Part 4: Cronjob-specific fixes (3 issues)

M11: --method GET explicit still triggers interactive prompt

File: cmd/cronjobs/cronjobs_create.go:127
Problem: Condition is if method == "GET" but GET is the default. If user explicitly passes --method GET, the prompt still shows.
Fix: Change to if !c.IsSet("method")

M12: cronjobs update silently ignores JSON unmarshal error

File: cmd/cronjobs/cronjobs_update.go:57
Problem: _ = json.Unmarshal(*existing.Settings, &currentSettings) — if settings JSON is malformed, zero values silently overwrite.
Fix: Check the error: if err := json.Unmarshal(...); err != nil { return fmt.Errorf("could not parse existing settings: %w", err) }

M-extra: cronjobs update — defaultMethod unused in interactive select

File: cmd/cronjobs/cronjobs_update.go:112
Problem: _ = defaultMethod — the current method is computed but not used as the default selection.
Fix: Use pterm.DefaultInteractiveSelect.WithDefaultOption(defaultMethod)

---

Acceptance Criteria

• All 8+1 interactive commands work correctly when piped: createos domains delete --project X --domain Y --force | cat
• env/helpers.go and scale.go select loops have fallthrough guards
• README CI examples either work or are corrected
• Cronjobs documented in README
• oauth-clients delete in README
• Home screen alphabetical
• Cronjob create/update interactive fixes applied
• go build ./... and go vet ./... pass

[naman485]

@BhautikChudasama — Nice work on the 12 fixes. 5 items remain from the original list:

HIGH — Logic Fallthroughs (2)

H11: cmd/env/helpers.go — select-loop fallthrough
After the interactive select loop (lines 63-66), if no match is found, execution falls through with empty envID → confusing "environment \"\" not found" error.
Fix: Add after the select loop:

return "", nil, fmt.Errorf("no environment selected")

H12: cmd/scale/scale.go — same fallthrough
After the select loop (lines 96-99), empty envID is returned to caller → downstream API error.
Fix: Add after the select loop:

return "", "", fmt.Errorf("no environment selected")

MEDIUM — Cronjob Fixes (3)

M11: cmd/cronjobs/create.go:136 — method selector condition
if method == "GET" should be if !c.IsSet("method") — currently, explicitly passing --method GET still triggers the interactive prompt.

M12: cmd/cronjobs/update.go:65 — unmarshal error discarded
_ = json.Unmarshal(...) silently fails on malformed JSON. Change to:

if err := json.Unmarshal(*existing.Settings, &currentSettings); err != nil {
    return fmt.Errorf("could not parse existing cron job settings: %w", err)
}

M-extra: cmd/cronjobs/update.go:119-124 — defaultMethod unused
_ = defaultMethod — should be passed to pterm.DefaultInteractiveSelect.WithDefaultOption(defaultMethod).

[BhautikChudasama]

@BhautikChudasama — Nice work on the 12 fixes. 5 items remain from the original list:

HIGH — Logic Fallthroughs (2)

H11: cmd/env/helpers.go — select-loop fallthrough After the interactive select loop (lines 63-66), if no match is found, execution falls through with empty envID → confusing "environment \"\" not found" error. Fix: Add after the select loop:

return "", nil, fmt.Errorf("no environment selected")
H12: cmd/scale/scale.go — same fallthrough After the select loop (lines 96-99), empty envID is returned to caller → downstream API error. Fix: Add after the select loop:

return "", "", fmt.Errorf("no environment selected")

MEDIUM — Cronjob Fixes (3)

M11: cmd/cronjobs/create.go:136 — method selector condition if method == "GET" should be if !c.IsSet("method") — currently, explicitly passing --method GET still triggers the interactive prompt.

M12: cmd/cronjobs/update.go:65 — unmarshal error discarded _ = json.Unmarshal(...) silently fails on malformed JSON. Change to:

if err := json.Unmarshal(*existing.Settings, &currentSettings); err != nil {
return fmt.Errorf("could not parse existing cron job settings: %w", err)
}
M-extra: cmd/cronjobs/update.go:119-124 — defaultMethod unused _ = defaultMethod — should be passed to pterm.DefaultInteractiveSelect.WithDefaultOption(defaultMethod).

@naman485 Addressed changes in 54dafac
Feel free to verify and close this issue.

[naman485]

All 17/17 items verified fixed. Build + vet clean. Closing.