Skip to content

Commit 9d273ae

Browse files
committed
the people want more clarity
1 parent 72b4e28 commit 9d273ae

3 files changed

Lines changed: 14 additions & 17 deletions

File tree

arm9/source/main.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2786,8 +2786,8 @@ void sampleDrawToggle(bool on)
27862786
sampledisplay->setDrawMode(on);
27872787
}
27882788

2789-
#define RIGHT_SIDE_BUTTON_WIDTH 28
2790-
#define RIGHT_SIDE_BUTTON_X 227
2789+
#define RIGHT_SIDE_BUTTON_WIDTH 30
2790+
#define RIGHT_SIDE_BUTTON_X 225
27912791

27922792
void setupGUI(bool dldi_enabled)
27932793
{

arm9/source/tobkit/patternview.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ void PatternView::draw(void)
348348
char numberstr[3];
349349
for(u16 i=0;i<getNumVisibleChannels();++i)
350350
{
351-
drawFullBox(PV_BORDER_WIDTH+i*getCellWidth()+1, 1, 14, 11, theme->col_bg);
351+
drawFullBox(PV_BORDER_WIDTH+i*getCellWidth()+1, 1, getCellWidth()-2, 11, theme->col_bg);
352352
snprintf(numberstr, sizeof(numberstr), "%-2x", (u8) (hscrollpos+i));
353353
drawString(numberstr, PV_BORDER_WIDTH+i*getCellWidth()+1, 1, theme->col_pv_lines, 255);
354354
}
@@ -373,7 +373,7 @@ void PatternView::draw(void)
373373
mute_col2 = theme->col_pv_cb_col2;
374374
}
375375
drawGradient(mute_col1, mute_col2, MUTE_X(i), MUTE_Y, MUTE_WIDTH, MUTE_HEIGHT);
376-
drawString("m", PV_BORDER_WIDTH+i*getCellWidth()+9, 0, theme->col_text, 255);
376+
drawString("m", PV_BORDER_WIDTH+i*getCellWidth()+MUTE_REL_X+1, 0, theme->col_text, 255);
377377
}
378378

379379
if(solo_channels[chn] == true)
@@ -388,7 +388,7 @@ void PatternView::draw(void)
388388
}
389389

390390
drawGradient(solo_col1, solo_col2, SOLO_X(i), SOLO_Y, SOLO_WIDTH, SOLO_HEIGHT);
391-
drawString("s", PV_BORDER_WIDTH+i*getCellWidth()+20, 0, theme->col_text, 255);
391+
drawString("s", PV_BORDER_WIDTH+i*getCellWidth()+SOLO_REL_X+2, 0, theme->col_text, 255);
392392
}
393393
}
394394

arm9/source/tobkit/patternview.h

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ namespace tobkit {
3939
#define PV_CHAR_WIDTH 4
4040
#define PV_CHAR_HEIGHT 8
4141

42-
#define MUTE_REL_X 8
42+
#define MUTE_REL_X 9
4343
#define MUTE_X(i) (PV_BORDER_WIDTH+(i)*getCellWidth()+MUTE_REL_X)
4444
#define MUTE_Y 1
4545
#define MUTE_WIDTH 10
4646
#define MUTE_HEIGHT 9
4747

48-
#define SOLO_REL_X 19
48+
#define SOLO_REL_X 20
4949
#define SOLO_X(i) (PV_BORDER_WIDTH+(i)*getCellWidth()+SOLO_REL_X)
5050
#define SOLO_Y MUTE_Y
5151
#define SOLO_WIDTH MUTE_WIDTH
@@ -228,16 +228,13 @@ class PatternView: public Widget {
228228

229229
u8 realx = PV_BORDER_WIDTH+1+px*getCellWidth();
230230
u8 realy = 2+py*PV_CELL_HEIGHT;
231-
231+
232232
// Check for empty note or stop-note
233233
if(cell->note == STOP_NOTE) {
234-
235234
drawChar(DOT, realx , realy, notecol);
236235
drawChar(MINUS, realx+1*PV_CHAR_WIDTH, realy, notecol);
237236
drawChar(DOT, realx+2*PV_CHAR_WIDTH, realy, notecol);
238-
239237
} else if(cell->note != EMPTY_NOTE) {
240-
241238
// Note
242239
drawChar(notes_chars[cell->note%12], realx, realy, notecol);
243240
if(notes_signs[cell->note%12]) {
@@ -258,11 +255,11 @@ class PatternView: public Widget {
258255

259256
if(effects_visible) {
260257
// Effect and effect parameter
261-
if (cell->effect != 0xff)
262-
drawChar(cell->effect, realx+7*PV_CHAR_WIDTH+3, realy, effectcol);
263-
264-
if (cell->effect_param != 0x00)
265-
drawHexByte(cell->effect_param, realx+8*PV_CHAR_WIDTH+3, realy, effectparamcol);
258+
if (cell->effect != 0xff)
259+
drawChar(cell->effect, realx+7*PV_CHAR_WIDTH+3, realy, effectcol);
260+
261+
if (cell->effect_param != 0x00)
262+
drawHexByte(cell->effect_param, realx+8*PV_CHAR_WIDTH+3, realy, effectparamcol);
266263
}
267264
}
268265

@@ -273,7 +270,7 @@ class PatternView: public Widget {
273270
if (effects_visible) {
274271
cell_width = 45;
275272
} else {
276-
cell_width = 31;
273+
cell_width = 32;
277274
}
278275
return cell_width;
279276
}

0 commit comments

Comments
 (0)