-
Notifications
You must be signed in to change notification settings - Fork 107
Expand file tree
/
Copy pathPrecisionRestorer.cpp
More file actions
290 lines (235 loc) · 10.8 KB
/
PrecisionRestorer.cpp
File metadata and controls
290 lines (235 loc) · 10.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
/********************* */
/*! \file PrecisionRestorer.cpp
** \verbatim
** Top contributors (to current version):
** Guy Katz
** This file is part of the Marabou project.
** Copyright (c) 2017-2019 by the authors listed in the file AUTHORS
** in the top-level source directory) and their institutional affiliations.
** All rights reserved. See the file COPYING in the top-level source
** directory for licensing information.\endverbatim
**
** [[ Add lengthier description here ]]
**/
#include "Debug.h"
#include "FloatUtils.h"
#include "MalformedBasisException.h"
#include "PrecisionRestorer.h"
#include "MarabouError.h"
#include "SmtCore.h"
void PrecisionRestorer::storeInitialEngineState( const IEngine &engine )
{
engine.storeState( _initialEngineState, true );
}
void PrecisionRestorer::restorePrecision( IEngine &engine,
ITableau &tableau,
SmtCore &smtCore,
RestoreBasics restoreBasics )
{
// Store the dimensions, bounds and basic variables in the current tableau, before restoring it
unsigned targetM = tableau.getM();
unsigned targetN = tableau.getN();
Set<unsigned> shouldBeBasic = tableau.getBasicVariables();
double *lowerBounds = new double[targetN];
double *upperBounds = new double[targetN];
memcpy( lowerBounds, tableau.getLowerBounds(), sizeof(double) * targetN );
memcpy( upperBounds, tableau.getUpperBounds(), sizeof(double) * targetN );
try
{
EngineState targetEngineState;
engine.storeState( targetEngineState, false );
// Store the case splits performed so far
List<PiecewiseLinearCaseSplit> targetSplits;
smtCore.allSplitsSoFar( targetSplits );
// Restore engine and tableau to their original form
engine.restoreState( _initialEngineState );
// Re-add all splits, which will restore variables and equations
for ( const auto &split : targetSplits )
engine.applySplit( split );
// At this point, the tableau has the appropriate dimensions. Restore the variable bounds
// and basic variables.
// Note that if column merging is enabled, the dimensions may not be precisely those before
// the resotration, because merging sometimes fails - in which case an equation is added. If
// we fail to restore the dimensions, we cannot restore the basics.
bool dimensionsRestored = ( tableau.getN() == targetN ) && ( tableau.getM() == targetM );
/* ASSERT( dimensionsRestored || GlobalConfiguration::USE_COLUMN_MERGING_EQUATIONS ); */
Set<unsigned> currentBasics = tableau.getBasicVariables();
if ( dimensionsRestored && restoreBasics == RESTORE_BASICS )
{
List<unsigned> shouldBeBasicList;
for ( const auto &basic : shouldBeBasic )
shouldBeBasicList.append( basic );
bool failed = false;
try
{
tableau.initializeTableau( shouldBeBasicList );
}
catch ( MalformedBasisException & )
{
failed = true;
}
if ( failed )
{
// The "restoreBasics" set leads to a malformed basis.
// Try again without this part of the restoration
shouldBeBasicList.clear();
for ( const auto &basic : currentBasics )
shouldBeBasicList.append( basic );
try
{
tableau.initializeTableau( shouldBeBasicList );
}
catch ( MalformedBasisException & )
{
throw MarabouError( MarabouError::RESTORATION_FAILED_TO_REFACTORIZE_BASIS,
"Precision restoration failed - could not refactorize basis after setting basics" );
}
}
}
// Tighten bounds if needed. The tableau will ignore these bounds if
// tighter bounds are already known, somehow.
for ( unsigned i = 0; i < tableau.getN(); ++i )
{
tableau.tightenLowerBound( i, lowerBounds[i] );
tableau.tightenUpperBound( i, upperBounds[i] );
}
// Restore constraint status
for ( const auto &pair : targetEngineState._plConstraintToState )
pair.first->setActiveConstraint( pair.second->isActive() );
engine.setNumPlConstraintsDisabledByValidSplits
( targetEngineState._numPlConstraintsDisabledByValidSplits );
/* DEBUG({
// Same dimensions
ASSERT( GlobalConfiguration::USE_COLUMN_MERGING_EQUATIONS || tableau.getN() == targetN );
ASSERT( GlobalConfiguration::USE_COLUMN_MERGING_EQUATIONS || tableau.getM() == targetM );
// Constraints should be in the same state before and after restoration
for ( const auto &pair : targetEngineState._plConstraintToState )
{
ASSERT( pair.second->isActive() == pair.first->isActive() );
ASSERT( pair.second->phaseFixed() == pair.first->phaseFixed() );
ASSERT( pair.second->constraintObsolete() == pair.first->constraintObsolete() );
}
EngineState currentEngineState;
engine.storeState( currentEngineState, false );
ASSERT( currentEngineState._numPlConstraintsDisabledByValidSplits ==
targetEngineState._numPlConstraintsDisabledByValidSplits );
tableau.verifyInvariants();
});*/
}
catch ( ... )
{
delete[] lowerBounds;
delete[] upperBounds;
throw;
}
delete[] lowerBounds;
delete[] upperBounds;
}
void PrecisionRestorer::restoreTableau( IEngine &engine,
ITableau &tableau,
SmtCore &smtCore,
RestoreBasics restoreBasics )
{
// Store the dimensions, bounds and basic variables in the current tableau, before restoring it
unsigned targetM = tableau.getM();
unsigned targetN = tableau.getN();
Set<unsigned> shouldBeBasic = tableau.getBasicVariables();
double *lowerBounds = new double[targetN];
double *upperBounds = new double[targetN];
memcpy( lowerBounds, tableau.getLowerBounds(), sizeof(double) * targetN );
memcpy( upperBounds, tableau.getUpperBounds(), sizeof(double) * targetN );
try
{
EngineState targetEngineState;
engine.storeState( targetEngineState, false );
// Store the case splits performed so far
List<PiecewiseLinearCaseSplit> targetSplits;
smtCore.allSplitsSoFar( targetSplits );
// Restore engine and tableau to their original form
engine.restoreState( _initialEngineState );
// At this point, the tableau has the appropriate dimensions. Restore the variable bounds
// and basic variables.
// Note that if column merging is enabled, the dimensions may not be precisely those before
// the resotration, because merging sometimes fails - in which case an equation is added. If
// we fail to restore the dimensions, we cannot restore the basics.
bool dimensionsRestored = ( tableau.getN() == targetN ) && ( tableau.getM() == targetM );
/* ASSERT( dimensionsRestored || GlobalConfiguration::USE_COLUMN_MERGING_EQUATIONS ); */
Set<unsigned> currentBasics = tableau.getBasicVariables();
if ( dimensionsRestored && restoreBasics == RESTORE_BASICS )
{
List<unsigned> shouldBeBasicList;
for ( const auto &basic : shouldBeBasic )
shouldBeBasicList.append( basic );
bool failed = false;
try
{
tableau.initializeTableau( shouldBeBasicList );
}
catch ( MalformedBasisException & )
{
failed = true;
}
if ( failed )
{
// The "restoreBasics" set leads to a malformed basis.
// Try again without this part of the restoration
shouldBeBasicList.clear();
for ( const auto &basic : currentBasics )
shouldBeBasicList.append( basic );
try
{
tableau.initializeTableau( shouldBeBasicList );
}
catch ( MalformedBasisException & )
{
throw MarabouError( MarabouError::RESTORATION_FAILED_TO_REFACTORIZE_BASIS,
"Precision restoration failed - could not refactorize basis after setting basics" );
}
}
}
// Tighten bounds if needed. The tableau will ignore these bounds if
// tighter bounds are already known, somehow.
for ( unsigned i = 0; i < tableau.getN(); ++i )
{
tableau.tightenLowerBound( i, lowerBounds[i] );
tableau.tightenUpperBound( i, upperBounds[i] );
}
// Restore constraint status
for ( const auto &pair : targetEngineState._plConstraintToState )
pair.first->setActiveConstraint( pair.second->isActive() );
engine.setNumPlConstraintsDisabledByValidSplits
( targetEngineState._numPlConstraintsDisabledByValidSplits );
/* DEBUG({
// Same dimensions
ASSERT( GlobalConfiguration::USE_COLUMN_MERGING_EQUATIONS || tableau.getN() == targetN );
ASSERT( GlobalConfiguration::USE_COLUMN_MERGING_EQUATIONS || tableau.getM() == targetM );
// Constraints should be in the same state before and after restoration
for ( const auto &pair : targetEngineState._plConstraintToState )
{
ASSERT( pair.second->isActive() == pair.first->isActive() );
ASSERT( pair.second->phaseFixed() == pair.first->phaseFixed() );
ASSERT( pair.second->constraintObsolete() == pair.first->constraintObsolete() );
}
EngineState currentEngineState;
engine.storeState( currentEngineState, false );
ASSERT( currentEngineState._numPlConstraintsDisabledByValidSplits ==
targetEngineState._numPlConstraintsDisabledByValidSplits );
tableau.verifyInvariants();
});*/
}
catch ( ... )
{
delete[] lowerBounds;
delete[] upperBounds;
throw;
}
delete[] lowerBounds;
delete[] upperBounds;
}
//
// Local Variables:
// compile-command: "make -C ../.. "
// tags-file-name: "../../TAGS"
// c-basic-offset: 4
// End:
//