Skip to content

Ensure manually triggered ACTool executions always appear in history logs#883

Closed
Copilot wants to merge 4 commits into
developfrom
copilot/always-persist-execution-log
Closed

Ensure manually triggered ACTool executions always appear in history logs#883
Copilot wants to merge 4 commits into
developfrom
copilot/always-persist-execution-log

Conversation

Copy link
Copy Markdown

Copilot AI commented May 19, 2026

Manual ACTool runs (Touch UI, web console, JMX) could be persisted but not always exposed in past execution logs. This PR now covers both identified causes:

  • execution entries with identical timestamps could collapse in sorted collections

  • no-change executions were being suppressed too broadly, including manual runs

  • History ordering stability

    • Updated execution comparison logic to use a deterministic tie-breaker when timestamps are equal.
    • Previous ordering compared only installationDate, which could collapse distinct executions in TreeSet-based collections.
  • Visibility rule for no-change executions

    • Updated history exposure logic so no-change executions are hidden only for automatic triggers (installhook, startup_hook*).
    • Manual executions (jmx, aem_admin_ui, webconsole) are now always exposed, even when 0 ACL/authorizable changes occurred.
  • Regression coverage

    • Added focused test ensuring two executions with identical timestamps are both retained.
    • Added assertion that tie-break ordering is stable and predictable by execution id.
    • Added focused tests for visibility behavior of no-change runs for manual vs automatic triggers.
@Override
public int compareTo(AcToolExecution otherExecution) {
    int compareByDate = -getInstallationDate().compareTo(otherExecution.getInstallationDate());
    if (compareByDate != 0) {
        return compareByDate;
    }
    return getId().compareTo(otherExecution.getId());
}

[!WARNING]

@sonarqubecloud
Copy link
Copy Markdown

Copilot AI changed the title [WIP] Always persist and expose execution log of installations Ensure manually triggered ACTool executions always appear in history logs May 19, 2026
Copilot AI requested a review from kwin May 19, 2026 19:30
Copilot finished work on behalf of kwin May 19, 2026 19:30
@kwin
Copy link
Copy Markdown
Member

kwin commented May 20, 2026

@copilot Manual executions also won't appear in the execution log if they haven't changed any ACLs/Authorizables. This should only happen for automatic installation (via Install Hook or Startup Hook). Fix that logic.

Copy link
Copy Markdown
Author

Copilot AI commented May 20, 2026

@copilot Manual executions also won't appear in the execution log if they haven't changed any ACLs/Authorizables. This should only happen for automatic installation (via Install Hook or Startup Hook)....

Updated in commit 00581fb: no-change executions are now filtered only for automatic triggers (installhook, startup_hook*), while manual triggers (jmx, aem_admin_ui, webconsole) are always exposed in execution logs. Added focused tests in HistoryUtilsTest for the new visibility logic.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • java.sun.com
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-8e0dfef8207e5db5/dbs/java/working/files-to-index2854868384429169621.list --sourceArchiveDir=/tmp/codeql-scratch-8e0dfef8207e5db5/dbs/java/src --outputDir=/tmp/codeql-scratch-8e0dfef8207e5db5/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of kwin May 20, 2026 07:34
@kwin kwin closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always persist and expose execution log of installations manually triggered

2 participants