Skip to content

Commit e707177

Browse files
committed
Undo CI changes as they are now in simpler isolated PRs
1 parent 45f5f63 commit e707177

3 files changed

Lines changed: 30 additions & 26 deletions

File tree

.github/workflows/lint_python.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,6 @@ jobs:
1717
python-version: "3.13"
1818

1919
- uses: actions/checkout@v4
20+
- run: uv sync
2021
- run: uv run ruff format --check --diff .
2122
- run: uv run ruff check

.github/workflows/test_and_deploy.yml

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,51 +42,53 @@ jobs:
4242
name: Test sdist on MacOS w/ Py3.10
4343
needs: test_repo
4444
runs-on: macos-latest
45-
steps:
46-
- name: Setup Python 3.10 env using uv
47-
uses: astral-sh/setup-uv@v5
45+
steps:
46+
- name: Setup Python 3.10 env
47+
uses: actions/setup-python@v5
4848
with:
4949
python-version: '3.10'
50+
- name: Ensure latest pip, wheel & setuptools
51+
run: python -m pip install -q --upgrade pip wheel setuptools
5052
- uses: actions/checkout@v4
5153
- name: Generate sdist
5254
run: |
53-
NLE_RELEASE_BUILD=1 uv build --sdist
55+
NLE_RELEASE_BUILD=1 python setup.py sdist
5456
- name: Install from sdist
5557
run: |
5658
SDISTNAME=$(ls dist/)
5759
MODE="[all]"
58-
uv venv
59-
uv pip install "dist/$SDISTNAME$MODE"
60+
pip install "dist/$SDISTNAME$MODE"
6061
- name: Run tests outside repo dir
6162
run: |
6263
REPONAME=$(basename $PWD)
6364
pushd ..
64-
uv run pytest --import-mode=append -svx $REPONAME/nle/tests
65+
python -m pytest --import-mode=append -svx $REPONAME/nle/tests
6566
popd
6667
test_sdist_3_13:
6768
name: Test sdist on MacOS w/ Py3.13
6869
needs: test_repo
6970
runs-on: macos-latest
7071
steps:
71-
- name: Setup Python 3.13 env using uv
72-
uses: astral-sh/setup-uv@v5
72+
- name: Setup Python 3.13 env
73+
uses: actions/setup-python@v5
7374
with:
74-
python-version: '3.13'
75+
python-version: 3.13
76+
- name: Ensure latest pip, wheel & setuptools
77+
run: python -m pip install -q --upgrade pip wheel setuptools
7578
- uses: actions/checkout@v4
7679
- name: Generate sdist
7780
run: |
78-
NLE_RELEASE_BUILD=1 uv build --sdist
81+
NLE_RELEASE_BUILD=1 python setup.py sdist
7982
- name: Install from sdist
8083
run: |
8184
SDISTNAME=$(ls dist/)
8285
MODE="[all]"
83-
uv venv
84-
uv pip install "dist/$SDISTNAME$MODE"
86+
pip install "dist/$SDISTNAME$MODE"
8587
- name: Run tests outside repo dir
8688
run: |
8789
REPONAME=$(basename $PWD)
8890
pushd ..
89-
uv run pytest --import-mode=append -svx $REPONAME/nle/tests
91+
python -m pytest --import-mode=append -svx $REPONAME/nle/tests
9092
popd
9193
- name: Save sdist
9294
if: ${{ always() }}
@@ -128,10 +130,12 @@ jobs:
128130
needs: build_wheels
129131
runs-on: ubuntu-latest
130132
steps:
131-
- name: Setup Python 3.13 env using uv
132-
uses: astral-sh/setup-uv@v5
133+
- name: Setup Python 3.13 env
134+
uses: actions/setup-python@v5
133135
with:
134-
python-version: '3.13'
136+
python-version: 3.13
137+
- name: Ensure latest pip, wheel & setuptools
138+
run: python -m pip install -q --upgrade pip wheel tools
135139
- uses: actions/checkout@v4
136140
- name: Get wheels artifacts
137141
uses: actions/download-artifact@v4
@@ -142,13 +146,12 @@ jobs:
142146
run: |
143147
WHEELNAME=$(ls dist/*313*manylinux*x86_64*.whl)
144148
MODE="[all]"
145-
uv venv
146-
uv pip install "$WHEELNAME$MODE"
149+
pip install "$WHEELNAME$MODE"
147150
- name: Run tests outside repo dir
148151
run: |
149152
REPONAME=$(basename $PWD)
150153
pushd ..
151-
uv run pytest --import-mode=append -svx $REPONAME/nle/tests
154+
python -m pytest --import-mode=append -svx $REPONAME/nle/tests
152155
popd
153156
154157
# Use prereleases to test publish the artefacts to testpypi

.github/workflows/test_package.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ jobs:
1515
python-version: ['3.10', '3.11', '3.12']
1616
fail-fast: false
1717
steps:
18-
- name: Setup Python env using uv
19-
uses: astral-sh/setup-uv@v5
18+
- name: Setup Python ${{ matrix.python-version }} env
19+
uses: actions/setup-python@v5
2020
with:
2121
python-version: ${{ matrix.python-version }}
22-
- name: Create an empty venv
23-
run: "uv venv"
22+
- name: Ensure latest pip, wheel & setuptools
23+
run: "python -m pip install -q --upgrade pip wheel setuptools"
2424
- name: Install nle via pip
25-
run: "uv pip install nle"
25+
run: "pip install nle"
2626
- name: Check nethack is installed
2727
run: |
28-
uv run python -c 'import nle; import gymnasium as gym; e = gym.make("NetHack-v0"); e.reset(); e.step(0)'
28+
python -c 'import nle; import gymnasium as gym; e = gym.make("NetHack-v0"); e.reset(); e.step(0)'
2929

0 commit comments

Comments
 (0)