Skip to content

Commit 8ea0e3e

Browse files
committed
Lock build-deps (again)
1 parent d00048b commit 8ea0e3e

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

CMakeLists.txt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.28)
2-
file(STRINGS "version.txt" NLE_VERSION)
2+
set(NLE_VERSION 1.2.0)
33
# Remove any rcXX suffix from the version number as CMake doesn't like it
44
string(REGEX REPLACE "rc[0-9+]$" "" CMAKE_NLE_VERSION ${NLE_VERSION})
55
project(nle VERSION ${CMAKE_NLE_VERSION})
@@ -36,13 +36,6 @@ message(STATUS "Building nle backend version: ${CMAKE_NLE_VERSION}")
3636

3737
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
3838

39-
# We use this to decide where the root of the nle/ package is. Normally it
40-
# shouldn't be needed, but sometimes (e.g. when using setuptools) we are
41-
# generating some of the files outside of the original package path.
42-
set(PYTHON_SRC_PARENT
43-
${nle_SOURCE_DIR}
44-
CACHE STRING "Directory containing the nle package files")
45-
4639
set(HACKDIR
4740
"$ENV{HOME}/nethackdir.nle"
4841
CACHE STRING "Configuration files for nethack")

pyproject.toml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ classifiers = [
2020
"Topic :: Scientific/Engineering :: Artificial Intelligence",
2121
"Topic :: Games/Entertainment",
2222
]
23-
dependencies = ["pybind11>=2.2", "numpy>=1.16", "gymnasium==1.2.0"]
23+
dependencies = [
24+
"pybind11>=2.2",
25+
"numpy>=1.16",
26+
"gymnasium==1.2.0",
27+
]
2428

2529
[project.license]
2630
file = "LICENSE"
@@ -30,14 +34,15 @@ Homepage = "https://github.com/NetHack-LE/nle"
3034

3135

3236
[build-system]
33-
requires = ["scikit-build-core>=0.10", "pybind11>=2.2", "setuptools-scm"]
37+
# Lock build-deps as uv does not yet support locking of build deps: astral-sh/uv#5190
38+
requires = ["scikit-build-core~=0.10", "pybind11~=2.2", "setuptools-scm~=9.2.2"]
3439
build-backend = "scikit_build_core.build"
3540

3641
[tool.scikit-build]
3742
cmake.build-type = "Release"
43+
cmake.args = ["-DHACKDIR=nle/nethackdir", "-DPYTHON_PACKAGE_NAME=nle"]
3844
minimum-version = "build-system.requires"
3945
wheel.license-files = []
40-
cmake.args = ["-DHACKDIR=nle/nethackdir", "-DPYTHON_PACKAGE_NAME=nle"]
4146

4247
[tool.scikit-build.metadata.version]
4348
provider = "scikit_build_core.metadata.setuptools_scm"

0 commit comments

Comments
 (0)