Skip to content

"hashesToSign" is incorrect naming #24

@PiVortex

Description

@PiVortex

In prepareTransactionForSigning we always return hashesToSign for what is passed to the sign function, regardless of the curve. In fact this is only true for secp256k1, where the hashes are actually what is passed to the mpc and signed, for ed25519 it is the message bytes that is signed thus calling these the hashesToSign is incorrect. We should just refer to this as the paylaod

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions