diff --git a/.changeset/lovely-hats-itch.md b/.changeset/lovely-hats-itch.md new file mode 100644 index 0000000..26d97ad --- /dev/null +++ b/.changeset/lovely-hats-itch.md @@ -0,0 +1,8 @@ +--- +"@naverpay/eslint-config": patch +"@naverpay/eslint-plugin": patch +--- + +🔧 Remove deprecated ESLint APIs and duplicate plugin registration + +PR: [🔧 Remove deprecated ESLint APIs and duplicate plugin registration](https://github.com/NaverPayDev/code-style/pull/152) diff --git a/packages/eslint-config/node/rules/style.js b/packages/eslint-config/node/rules/style.js index 3459e10..3bf6190 100644 --- a/packages/eslint-config/node/rules/style.js +++ b/packages/eslint-config/node/rules/style.js @@ -1,9 +1,4 @@ -import nodePlugin from 'eslint-plugin-n' - export default { - plugins: { - n: nodePlugin, - }, rules: { /** * Require the use of === and !== diff --git a/packages/eslint-config/react/rules/node.js b/packages/eslint-config/react/rules/node.js index a9f1c47..3f47307 100644 --- a/packages/eslint-config/react/rules/node.js +++ b/packages/eslint-config/react/rules/node.js @@ -1,9 +1,4 @@ -import nodePlugin from 'eslint-plugin-n' - export default { - plugins: { - n: nodePlugin, - }, rules: { /** * When a function is named cb or callback, then it must be invoked with a first argument that is undefined, null, an Error class, or a subclass or Error diff --git a/packages/eslint-plugin/lib/rules/import-server-only.js b/packages/eslint-plugin/lib/rules/import-server-only.js index 2631b5a..07d3791 100644 --- a/packages/eslint-plugin/lib/rules/import-server-only.js +++ b/packages/eslint-plugin/lib/rules/import-server-only.js @@ -31,7 +31,7 @@ export default { }, create(context) { const {include, exclude} = context.options[0] || {} - const filePath = path.relative(context.getCwd(), context.getFilename()) + const filePath = path.relative(context.cwd, context.filename) const isIncluded = micromatch.isMatch(filePath, include) const isExcluded = micromatch.isMatch(filePath, exclude) @@ -46,7 +46,7 @@ export default { (statement) => statement.type === 'ImportDeclaration' && statement.source.value === 'server-only', ) - const sourceCode = context.sourceCode ?? context.getSourceCode() + const sourceCode = context.sourceCode if (!hasServerOnlyImport) { context.report({ diff --git a/packages/eslint-plugin/lib/rules/memo-react-components.js b/packages/eslint-plugin/lib/rules/memo-react-components.js index 6484c27..7819290 100644 --- a/packages/eslint-plugin/lib/rules/memo-react-components.js +++ b/packages/eslint-plugin/lib/rules/memo-react-components.js @@ -31,7 +31,7 @@ export default { let isAlreadyMemoized = false - const sourceCode = context.sourceCode ?? context.getSourceCode() + const sourceCode = context.sourceCode /** * @type {import('eslint').Scope.Scope | undefined} @@ -48,7 +48,7 @@ export default { const reactImportDeclaration = importDeclarations.find(({source: {value}}) => value === 'react') - let isDefault = false + let isDefault let hasImportMemo = false let isDefaultOnly = false if (reactImportDeclaration) { @@ -88,7 +88,7 @@ export default { return { Program: function (node) { - globalScope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope() + globalScope = sourceCode.getScope(node) const exportDefaultDeclaration = getExportDefaultDeclaration(globalScope.block).declaration if ( diff --git a/packages/eslint-plugin/lib/rules/optimize-svg-components.js b/packages/eslint-plugin/lib/rules/optimize-svg-components.js index 76c2af4..fd97b83 100644 --- a/packages/eslint-plugin/lib/rules/optimize-svg-components.js +++ b/packages/eslint-plugin/lib/rules/optimize-svg-components.js @@ -139,7 +139,7 @@ export default { return {} } - const sourceCode = context.sourceCode ?? context.getSourceCode() + const sourceCode = context.sourceCode /** * @type {import('eslint').Scope.Scope | undefined} @@ -149,7 +149,7 @@ export default { return { Program: function (node) { - globalScope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope() + globalScope = sourceCode.getScope(node) canOptimize = svgValidator(context, globalScope) }, onCodePathEnd: function (_, code) { diff --git a/packages/eslint-plugin/lib/rules/peer-deps-in-dev-deps.js b/packages/eslint-plugin/lib/rules/peer-deps-in-dev-deps.js index 728a721..0efb2d4 100644 --- a/packages/eslint-plugin/lib/rules/peer-deps-in-dev-deps.js +++ b/packages/eslint-plugin/lib/rules/peer-deps-in-dev-deps.js @@ -28,7 +28,7 @@ export default { return } - const sourceCode = context.sourceCode ?? context.getSourceCode() + const sourceCode = context.sourceCode let json try { diff --git a/packages/eslint-plugin/lib/rules/sort-exports.js b/packages/eslint-plugin/lib/rules/sort-exports.js index ebf7415..ca68078 100644 --- a/packages/eslint-plugin/lib/rules/sort-exports.js +++ b/packages/eslint-plugin/lib/rules/sort-exports.js @@ -1,8 +1,8 @@ import {minimatch} from 'minimatch' function getCommentFromNode(context, node) { - const beforeComments = context.getSourceCode().getCommentsBefore(node) - const afterComments = context.getSourceCode().getCommentsAfter(node) + const beforeComments = context.sourceCode.getCommentsBefore(node) + const afterComments = context.sourceCode.getCommentsAfter(node) const result = {} const nodeStartLine = node.loc.start.line @@ -53,7 +53,7 @@ function getIdentifier(node) { exportKind, } = node - let wholeLine = '' + let wholeLine if (specifiers.length === 1) { if (specifiers[0].local.name === 'default') { diff --git a/packages/eslint-plugin/lib/rules/svg-unique-id.js b/packages/eslint-plugin/lib/rules/svg-unique-id.js index 483e5c8..db00d51 100644 --- a/packages/eslint-plugin/lib/rules/svg-unique-id.js +++ b/packages/eslint-plugin/lib/rules/svg-unique-id.js @@ -122,11 +122,11 @@ export default { * @type {import('eslint').Scope.Scope | undefined} */ let globalScope - const sourceCode = context.sourceCode ?? context.getSourceCode() + const sourceCode = context.sourceCode return { Program: function (node) { - globalScope = sourceCode.getScope ? sourceCode.getScope(node) : context.getScope() + globalScope = sourceCode.getScope(node) }, onCodePathEnd: function (_, code) { const svgElement = getJSXReturnStatement(globalScope)