Merge pull request #4022 from NativeScript/fatme/msg

Fatme · web-flow · commit cefa22f4a8aa · 2018-10-12T15:35:44.000+03:00
fix: show deviceIdentifier on installing and refreshing messages
diff --git a/lib/services/livesync/platform-livesync-service-base.ts b/lib/services/livesync/platform-livesync-service-base.ts
@@ -30,7 +30,7 @@ export abstract class PlatformLiveSyncServiceBase {
 	public async refreshApplication(projectData: IProjectData, liveSyncInfo: ILiveSyncResultInfo): Promise<void> {
 		if (liveSyncInfo.isFullSync || liveSyncInfo.modifiedFilesData.length) {
 			const deviceLiveSyncService = this.getDeviceLiveSyncService(liveSyncInfo.deviceAppData.device, projectData);
-			this.$logger.info("Refreshing application...");
+			this.$logger.info(`Refreshing application on device ${liveSyncInfo.deviceAppData.device.deviceInfo.identifier}...`);
 			await deviceLiveSyncService.refreshApplication(projectData, liveSyncInfo);
 		}
 	}
diff --git a/lib/services/platform-service.ts b/lib/services/platform-service.ts
@@ -481,7 +481,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {
 	}
 
 	public async installApplication(device: Mobile.IDevice, buildConfig: IBuildConfig, projectData: IProjectData, packageFile?: string, outputFilePath?: string): Promise<void> {
-		this.$logger.out("Installing...");
+		this.$logger.out(`Installing on device ${device.deviceInfo.identifier}...`);
 
 		await this.$analyticsService.trackEventActionInGoogleAnalytics({
 			action: constants.TrackActionNames.Deploy,

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ export abstract class PlatformLiveSyncServiceBase {`
`30`	`30`	`public async refreshApplication(projectData: IProjectData, liveSyncInfo: ILiveSyncResultInfo): Promise<void> {`
`31`	`31`	`if (liveSyncInfo.isFullSync \|\| liveSyncInfo.modifiedFilesData.length) {`
`32`	`32`	`const deviceLiveSyncService = this.getDeviceLiveSyncService(liveSyncInfo.deviceAppData.device, projectData);`
`33`		`- this.$logger.info("Refreshing application...");`
	`33`	+ this.$logger.info(`Refreshing application on device ${liveSyncInfo.deviceAppData.device.deviceInfo.identifier}...`);
`34`	`34`	`await deviceLiveSyncService.refreshApplication(projectData, liveSyncInfo);`
`35`	`35`	`}`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -481,7 +481,7 @@ export class PlatformService extends EventEmitter implements IPlatformService {`
`481`	`481`	`}`
`482`	`482`
`483`	`483`	`public async installApplication(device: Mobile.IDevice, buildConfig: IBuildConfig, projectData: IProjectData, packageFile?: string, outputFilePath?: string): Promise<void> {`
`484`		`- this.$logger.out("Installing...");`
	`484`	+ this.$logger.out(`Installing on device ${device.deviceInfo.identifier}...`);
`485`	`485`
`486`	`486`	`await this.$analyticsService.trackEventActionInGoogleAnalytics({`
`487`	`487`	`action: constants.TrackActionNames.Deploy,`