Merge pull request #3490 from NativeScript/fatme/plist

Fix (publish): Remove binary-plist and use simple-plist instead

Author: Fatme

lib/common

@@ -13,7 +13,6 @@ import * as plist from "plist";
 import { IOSProvisionService } from "./ios-provision-service";
 import { IOSEntitlementsService } from "./ios-entitlements-service";
 import { XCConfigService } from "./xcconfig-service";
-import * as simplePlist from "simple-plist";
 import * as mobileprovision from "ios-mobileprovision-finder";
 import { SpawnOptions } from "child_process";
 import { BUILD_XCCONFIG_FILE_NAME } from "../constants";
@@ -51,6 +50,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 		private $xcode: IXcode,
 		private $iOSEntitlementsService: IOSEntitlementsService,
 		private $platformEnvironmentRequirements: IPlatformEnvironmentRequirements,
+		private $plistParser: IPlistParser,
 		private $sysInfo: ISysInfo,
 		private $xCConfigService: XCConfigService) {
 			super($fs, $projectDataService);
@@ -1045,7 +1045,7 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 			this.$errors.failWithoutHelp("The bundle at %s does not contain an Info.plist file.", libraryPath);
 		}
 
-		const plistJson = simplePlist.readFileSync(infoPlistPath);
+		const plistJson = this.$plistParser.parseFileSync(infoPlistPath);
 		const packageType = plistJson["CFBundlePackageType"];
 
 		if (packageType !== "FMWK") {

lib/definitions/simple-plist.d.ts

@@ -10,7 +10,7 @@ export class ITMSTransporterService implements IITMSTransporterService {
 	private _itunesConnectApplications: IiTunesConnectApplication[] = null;
 	private _bundleIdentifier: string = null;
 
-	constructor(private $bplistParser: IBinaryPlistParser,
+	constructor(private $plistParser: IPlistParser,
 		private $childProcess: IChildProcess,
 		private $errors: IErrors,
 		private $fs: IFileSystem,
@@ -135,8 +135,8 @@ export class ITMSTransporterService implements IITMSTransporterService {
 				}
 				const appFile = path.join(payloadDir, allApps[0]);
 
-				const plistObject = await this.$bplistParser.parseFile(path.join(appFile, INFO_PLIST_FILE_NAME));
-				const bundleId = plistObject && plistObject[0] && plistObject[0].CFBundleIdentifier;
+				const plistObject = await this.$plistParser.parseFile(path.join(appFile, INFO_PLIST_FILE_NAME));
+				const bundleId = plistObject && plistObject.CFBundleIdentifier;
 				if (!bundleId) {
 					this.$errors.failWithoutHelp(`Unable to determine bundle identifier from ${ipaFileFullPath}.`);
 				}

lib/services/ios-project-service.ts

@@ -31,7 +31,6 @@
   ],
   "dependencies": {
     "@types/ora": "1.3.2",
-    "bplist-parser": "0.1.0",
     "bufferpack": "0.0.6",
     "byline": "4.2.1",
     "chalk": "1.1.0",

lib/services/itmstransporter-service.ts

@@ -120,6 +120,7 @@ function createTestInjector(projectPath: string, projectName: string): IInjector
 	testInjector.register("settingsService", SettingsService);
 	testInjector.register("httpClient", {});
 	testInjector.register("platformEnvironmentRequirements", {});
+	testInjector.register("plistParser", {});
 
 	return testInjector;
 }