Fix PR comments

Author: Fatme

lib/services/ios-project-service.ts

@@ -72,8 +72,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 				platformProjectService: this,
 				emulatorServices: this.$iOSEmulatorServices,
 				projectRoot: projectRoot,
-				deviceBuildOutputPath: path.join(projectRoot, "build", "device"),
-				emulatorBuildOutputPath: path.join(projectRoot, "build", "emulator"),
+				deviceBuildOutputPath: path.join(projectRoot, constants.BUILD_DIR, "device"),
+				emulatorBuildOutputPath: path.join(projectRoot, constants.BUILD_DIR, "emulator"),
 				getValidBuildOutputData: (buildOptions: IBuildOutputOptions): IValidBuildOutputData => {
 					if (buildOptions.isForDevice) {
 						return {

lib/services/platform-service.ts

@@ -779,10 +779,10 @@ export class PlatformService extends EventEmitter implements IPlatformService {
 		return packages.map(filepath => this.createApplicationPackage(filepath));
 	}
 
-	private createApplicationPackage(filepath: string): IApplicationPackage {
+	private createApplicationPackage(packageName: string): IApplicationPackage {
 		return {
-			packageName: filepath,
-			time: this.$fs.getFsStats(filepath).mtime
+			packageName,
+			time: this.$fs.getFsStats(packageName).mtime
 		};
 	}
 

test/stubs.ts

@@ -305,7 +305,7 @@ export class PlatformProjectServiceStub extends EventEmitter implements IPlatfor
 			emulatorServices: undefined,
 			projectRoot: "",
 			deviceBuildOutputPath: "",
-			getValidBuildOutputData: (buildOptions: { isForDevice?: boolean, isReleaseBuild?: boolean }) => ({ packageNames: [] }),
+			getValidBuildOutputData: (buildOptions: IBuildOutputOptions) => ({ packageNames: [] }),
 			frameworkFilesExtensions: [],
 			appDestinationDirectoryPath: "",
 			relativeToFrameworkConfigurationFilePath: "",
@@ -416,7 +416,7 @@ export class PlatformsDataStub extends EventEmitter implements IPlatformsData {
 			normalizedPlatformName: "",
 			appDestinationDirectoryPath: "",
 			deviceBuildOutputPath: "",
-			getValidBuildOutputData: (buildOptions: { isForDevice?: boolean, isReleaseBuild?: boolean }) => ({ packageNames: []}),
+			getValidBuildOutputData: (buildOptions: IBuildOutputOptions) => ({ packageNames: []}),
 			frameworkFilesExtensions: [],
 			relativeToFrameworkConfigurationFilePath: "",
 			fastLivesyncFileExtensions: []