Merge pull request #4 from ArthurMJ96/patch-1

triniwiz · web-flow · commit b6f348d95ac4 · 2021-10-12T05:14:33.000-07:00
Fix: Crash when suspending &amp; resuming App with active NativeAdView.
diff --git a/packages/firebase-admob/nativead/index.android.ts b/packages/firebase-admob/nativead/index.android.ts
@@ -28,7 +28,7 @@ export class NativeAdView extends NativeAdViewBase implements AddChildFromBuilde
 
 	onLoaded(){
 		super.onLoaded();
-		if(this.#child){
+		if(this.#child && this.#native.indexOfChild(this.#child.nativeView) === -1) {
 			(this.#native as any).addView(this.#child.nativeView);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export class NativeAdView extends NativeAdViewBase implements AddChildFromBuilde`
`28`	`28`
`29`	`29`	`onLoaded(){`
`30`	`30`	`super.onLoaded();`
`31`		`- if(this.#child){`
	`31`	`+ if(this.#child && this.#native.indexOfChild(this.#child.nativeView) === -1) {`
`32`	`32`	`(this.#native as any).addView(this.#child.nativeView);`
`33`	`33`	`}`
`34`	`34`	`}`