Commit 3945a0d
fix: coerce append/set arguments to USVStrings
Completes the review follow-up: append() and set() now run both
arguments through the same USVString coercion as the rest of the
binding, instead of casting them to strings blindly. A
number/boolean/object argument coerces via toString; a Symbol (or a
throwing toString) raises a TypeError before anything is appended or
replaced.1 parent 1a0ae12 commit 3945a0d
2 files changed
Lines changed: 40 additions & 10 deletions
File tree
- test-app
- app/src/main/assets/app/tests
- runtime/src/main/cpp
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
446 | 466 | | |
447 | 467 | | |
448 | 468 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
546 | | - | |
547 | | - | |
548 | | - | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
549 | 556 | | |
550 | 557 | | |
551 | 558 | | |
| |||
708 | 715 | | |
709 | 716 | | |
710 | 717 | | |
711 | | - | |
712 | | - | |
713 | | - | |
714 | | - | |
715 | | - | |
716 | | - | |
717 | | - | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
718 | 728 | | |
719 | 729 | | |
720 | 730 | | |
| |||
0 commit comments