Test failures in create_bar_from_building_type_ratios

[jmarrec]

You have failing tests in resources/create_bar_from_building_type_ratios with OS SDK 3.10.0

log_messages_to_runner from standards registers an error.

eg: ruby create_bar_from_building_type_ratios_test.rb -n test_building_shorter_than_neighbors

"Initial area of other surface 'Surface 176' 297.209 does not equal post intersection area 297.203"

https://github.com/NREL/openstudio-standards/blob/72ab197f5f3f84eda2456efa44cee6e9d264176f/lib/openstudio-standards/utilities/logging.rb#L1-L37

  1) Failure:
CreateBarFromBuildingTypeRatiosTest#test_building_taller_than_neighbors [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  2) Failure:
CreateBarFromBuildingTypeRatiosTest#test_t24_ofs [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  3) Failure:
CreateBarFromBuildingTypeRatiosTest#test_neighboring_buildings [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  4) Failure:
CreateBarFromBuildingTypeRatiosTest#test_building_shorter_than_neighbors [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

  5) Failure:
CreateBarFromBuildingTypeRatiosTest#test_rotation_45_party_wall_fraction [create_bar_from_building_type_ratios_test.rb:59]:
Expected: "Success"
  Actual: "Fail"

[jmarrec]

Here's an extract of the failures

Post intersection: @mdahlhausen perhaps that ought to be filtered out in log_message_to_runner ? Also, given your use of global variables, the list of exclusions should probably be global too, so one could manually add an exclusion text.

measure results for test_building_taller_than_neighbors
**ERROR MESSAGES**
[openstudio.model.Surface] Initial area of other surface 'Surface 176' 297.209 does not equal post intersection area 297.203

measure results for test_building_shorter_than_neighbors
**ERROR MESSAGES**
[openstudio.model.Surface] Initial area of other surface 'Surface 176' 297.209 does not equal post intersection area 297.203

measure results for test_neighboring_buildings
**ERROR MESSAGES**
[openstudio.model.Surface] Initial area of other surface 'Surface 176' 297.209 does not equal post intersection area 297.203

measure results for test_rotation_45_party_wall_fraction
**ERROR MESSAGES**
[openstudio.model.Surface] Initial area of other surface 'Surface 176' 297.209 does not equal post intersection area 297.203

---

measure results for test_t24_ofs
**ERROR MESSAGES**
[openstudio.standards.Geometry.Create] OfS Hall doesn't have the expected floor area (actual 0 ft^2, target 785 ft^2)
[openstudio.standards.Geometry.Create] OfS OfficeSmall doesn't have the expected floor area (actual 2,500 ft^2, target 1,715 ft^2)
[openstudio.standards.Geometry.Create] Sum of actual floor area is 2500.0000000000023 ft^2, sum of target floor area is 2500.0.

[DavidGoldwasser]

We didn't actively change anything with surface intersection from 3.9 to 3.10, but I guess something must of changed to through it off just over instead of just under the tolerance. If make_mid_story_surfaces_adiabatic isn't set to true changing it to true will avoid most of the intersections that happen, and you might avoid this. Otherwise we can adjust the tolerance more. I think that can just be done in standards gem but not 100% sure if there or in core OpenStudio.