Skip to content

Pick a single icon set if possible, and preload it #82

@floatplane

Description

@floatplane
  1. Right now we use a mixture of icons from five icon sets. This isn't good from a memory usage or a visual consistency standpoint. Designers have been using the AntDesign icons so we should probably follow suit.
❯ rg "import.*vector-icons"
components/AvalancheForecastZoneMap.tsx
20:import {FontAwesome5} from '@expo/vector-icons';
 
components/TelemetryStationMap.tsx
4:import {FontAwesome5} from '@expo/vector-icons';
 
components/icons/nac-icons.tsx
1:import {createIconSet} from '@expo/vector-icons';
 
components/content/Carousel.tsx
5:import {AntDesign, FontAwesome5} from '@expo/vector-icons';
 
components/content/Card.tsx
6:import {FontAwesome} from '@expo/vector-icons';
 
components/DangerScale.tsx
3:import {MaterialIcons} from '@expo/vector-icons';
 
components/Observations.tsx
8:import {FontAwesome, MaterialCommunityIcons} from '@expo/vector-icons';
 
components/Observation.tsx
5:import {FontAwesome5, MaterialCommunityIcons, Fontisto} from '@expo/vector-icons';
 
App.tsx
7:import {AntDesign} from '@expo/vector-icons';

  1. We should preload icons so they're ready to go when we need them - https://docs.expo.dev/archive/classic-updates/preloading-and-caching-assets/#pre-loading-and-caching-assets

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Medium PriorityenhancementNew feature or requestgood first issueGood for newcomersperformanceperformance related issuessomedayThings we're not ready to tackle yet, but will someday

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions