Skip to content

Commit e605170

Browse files
committed
Reply to Leo's comments
1 parent 86cd8c5 commit e605170

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cuda_core/cuda/core/experimental/_memory.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,10 +1089,10 @@ class _SynchronousMemoryResource(MemoryResource):
10891089
return self._dev_id
10901090

10911091

1092-
VirtualMemoryHandleTypeT = Literal["posix_fd", "generic", "none", "win32", "win32_kmt", "fabric"]
1092+
VirtualMemoryHandleTypeT = Union[Literal["posix_fd", "generic", "win32", "win32_kmt", "fabric"], None]
10931093
VirtualMemoryLocationTypeT = Literal["device", "host", "host_numa", "host_numa_current"]
10941094
VirtualMemoryGranularityT = Literal["minimum", "recommended"]
1095-
VirtualMemoryAccessTypeT = Literal["rw", "r", "none"]
1095+
VirtualMemoryAccessTypeT = Union[Literal["rw", "r"], None]
10961096
VirtualMemoryAllocationTypeT = Literal["pinned", "managed"]
10971097

10981098

@@ -1140,9 +1140,9 @@ class VirtualMemoryResourceOptions:
11401140
peer_access: VirtualMemoryAccessTypeT = "rw"
11411141

11421142
_a = driver.CUmemAccess_flags
1143-
_access_flags = {"rw": _a.CU_MEM_ACCESS_FLAGS_PROT_READWRITE, "r": _a.CU_MEM_ACCESS_FLAGS_PROT_READ, "none": 0}
1143+
_access_flags = {"rw": _a.CU_MEM_ACCESS_FLAGS_PROT_READWRITE, "r": _a.CU_MEM_ACCESS_FLAGS_PROT_READ, None: 0}
11441144
_h = driver.CUmemAllocationHandleType
1145-
_handle_types = {"none": _h.CU_MEM_HANDLE_TYPE_NONE, "posix_fd": _h.CU_MEM_HANDLE_TYPE_POSIX_FILE_DESCRIPTOR, "win32": _h.CU_MEM_HANDLE_TYPE_WIN32, "win32_kmt": _h.CU_MEM_HANDLE_TYPE_WIN32_KMT, "fabric": _h.CU_MEM_HANDLE_TYPE_FABRIC}
1145+
_handle_types = {None: _h.CU_MEM_HANDLE_TYPE_NONE, "posix_fd": _h.CU_MEM_HANDLE_TYPE_POSIX_FILE_DESCRIPTOR, "win32": _h.CU_MEM_HANDLE_TYPE_WIN32, "win32_kmt": _h.CU_MEM_HANDLE_TYPE_WIN32_KMT, "fabric": _h.CU_MEM_HANDLE_TYPE_FABRIC}
11461146
_g = driver.CUmemAllocationGranularity_flags
11471147
_granularity = {"recommended": _g.CU_MEM_ALLOC_GRANULARITY_RECOMMENDED, "minimum": _g.CU_MEM_ALLOC_GRANULARITY_MINIMUM}
11481148
_l = driver.CUmemLocationType

0 commit comments

Comments
 (0)