Skip to content

Commit 948af33

Browse files
committed
Use DeviceMemoryResourceOptions throughout tests.
1 parent e54cb5b commit 948af33

File tree

5 files changed

+21
-19
lines changed

5 files changed

+21
-19
lines changed

cuda_core/tests/memory_ipc/conftest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# SPDX-License-Identifier: Apache-2.0
33

44
import pytest
5-
from cuda.core.experimental import Device, DeviceMemoryResource
5+
from cuda.core.experimental import Device, DeviceMemoryResource, DeviceMemoryResourceOptions
66

77
POOL_SIZE = 2097152
88

@@ -27,6 +27,7 @@ def device():
2727

2828
@pytest.fixture
2929
def ipc_memory_resource(device):
30-
mr = DeviceMemoryResource(device, dict(max_size=POOL_SIZE, ipc_enabled=True))
30+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=True)
31+
mr = DeviceMemoryResource(device, options=options)
3132
assert mr.is_ipc_enabled
3233
return mr

cuda_core/tests/memory_ipc/test_errors.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import multiprocessing
55
import re
66

7-
from cuda.core.experimental import Buffer, Device, DeviceMemoryResource
7+
from cuda.core.experimental import Buffer, Device, DeviceMemoryResource, DeviceMemoryResourceOptions
88
from cuda.core.experimental._utils.cuda_utils import CUDAError
99

1010
CHILD_TIMEOUT_SEC = 4
@@ -71,7 +71,8 @@ class TestImportWrongMR(ChildErrorHarness):
7171
"""Error when importing a buffer from the wrong memory resource."""
7272

7373
def PARENT_ACTION(self, queue):
74-
mr2 = DeviceMemoryResource(self.device, dict(max_size=POOL_SIZE, ipc_enabled=True))
74+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=True)
75+
mr2 = DeviceMemoryResource(self.device, options=options)
7576
buffer = mr2.allocate(NBYTES)
7677
queue.put([self.mr, buffer.get_ipc_descriptor()]) # Note: mr does not own this buffer
7778

@@ -124,7 +125,8 @@ class TestDanglingBuffer(ChildErrorHarness):
124125
"""
125126

126127
def PARENT_ACTION(self, queue):
127-
mr2 = DeviceMemoryResource(self.device, dict(max_size=POOL_SIZE, ipc_enabled=True))
128+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=True)
129+
mr2 = DeviceMemoryResource(self.device, options=options)
128130
self.buffer = mr2.allocate(NBYTES)
129131
queue.put(self.buffer) # Note: mr2 not sent
130132

cuda_core/tests/memory_ipc/test_send_buffers.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import multiprocessing
55
from itertools import cycle
66

7-
from cuda.core.experimental import Device, DeviceMemoryResource
7+
from cuda.core.experimental import Device, DeviceMemoryResource, DeviceMemoryResourceOptions
88
from utility import IPCBufferTestHelper
99

1010
CHILD_TIMEOUT_SEC = 4
@@ -41,9 +41,8 @@ def test_ipc_send_buffers(device, ipc_memory_resource):
4141
def test_ipc_send_buffers_multi(device, ipc_memory_resource):
4242
"""Test passing buffers sourced from multiple memory resources."""
4343
# Set up several IPC-enabled memory pools.
44-
mrs = [ipc_memory_resource] + [
45-
DeviceMemoryResource(device, dict(max_size=POOL_SIZE, ipc_enabled=True)) for _ in range(NMRS - 1)
46-
]
44+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=True)
45+
mrs = [ipc_memory_resource] + [DeviceMemoryResource(device, options=options) for _ in range(NMRS - 1)]
4746

4847
# Allocate and fill memory.
4948
buffers = [mr.allocate(NBYTES) for mr, _ in zip(cycle(mrs), range(NTASKS))]

cuda_core/tests/memory_ipc/test_workerpool.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import multiprocessing
55
from itertools import cycle
66

7-
from cuda.core.experimental import Buffer, Device, DeviceMemoryResource
7+
from cuda.core.experimental import Buffer, Device, DeviceMemoryResource, DeviceMemoryResourceOptions
88
from utility import IPCBufferTestHelper
99

1010
CHILD_TIMEOUT_SEC = 4
@@ -43,9 +43,8 @@ def test_ipc_workerpool(self, device, ipc_memory_resource):
4343

4444
def test_ipc_workerpool_multi_mr(self, device, ipc_memory_resource):
4545
"""Test IPC with a worker pool using multiple memory resources."""
46-
mrs = [ipc_memory_resource] + [
47-
DeviceMemoryResource(device, dict(max_size=POOL_SIZE, ipc_enabled=True)) for _ in range(NMRS - 1)
48-
]
46+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=True)
47+
mrs = [ipc_memory_resource] + [DeviceMemoryResource(device, options=options) for _ in range(NMRS - 1)]
4948
buffers = [mr.allocate(NBYTES) for mr, _ in zip(cycle(mrs), range(NTASKS))]
5049
with multiprocessing.Pool(processes=NWORKERS, initializer=self.init_worker, initargs=(mrs,)) as pool:
5150
pool.starmap(
@@ -88,9 +87,8 @@ def test_ipc_workerpool(self, device, ipc_memory_resource):
8887

8988
def test_ipc_workerpool_multi_mr(self, device, ipc_memory_resource):
9089
"""Test IPC with a worker pool using multiple memory resources."""
91-
mrs = [ipc_memory_resource] + [
92-
DeviceMemoryResource(device, dict(max_size=POOL_SIZE, ipc_enabled=True)) for _ in range(NMRS - 1)
93-
]
90+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=True)
91+
mrs = [ipc_memory_resource] + [DeviceMemoryResource(device, options=options) for _ in range(NMRS - 1)]
9492
buffers = [mr.allocate(NBYTES) for mr, _ in zip(cycle(mrs), range(NTASKS))]
9593
with multiprocessing.Pool(processes=NWORKERS, initializer=self.init_worker, initargs=(mrs,)) as pool:
9694
pool.map(self.process_buffer, buffers)

cuda_core/tests/test_memory.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import platform
1111

1212
import pytest
13-
from cuda.core.experimental import Buffer, Device, DeviceMemoryResource, MemoryResource
13+
from cuda.core.experimental import Buffer, Device, DeviceMemoryResource, DeviceMemoryResourceOptions, MemoryResource
1414
from cuda.core.experimental._memory import DLDeviceType, IPCBufferDescriptor
1515
from cuda.core.experimental._utils.cuda_utils import handle_return
1616

@@ -304,7 +304,8 @@ def test_mempool(mempool_device):
304304
device = mempool_device
305305

306306
# Test basic pool creation
307-
mr = DeviceMemoryResource(device, dict(max_size=POOL_SIZE, ipc_enabled=False))
307+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=False)
308+
mr = DeviceMemoryResource(device, options=options)
308309
assert mr.device_id == device.device_id
309310
assert mr.is_device_accessible
310311
assert not mr.is_host_accessible
@@ -379,7 +380,8 @@ def test_mempool_attributes(ipc_enabled, mempool_device, property_name, expected
379380
if platform.system() == "Windows":
380381
return # IPC not implemented for Windows
381382

382-
mr = DeviceMemoryResource(device, dict(max_size=POOL_SIZE, ipc_enabled=ipc_enabled))
383+
options = DeviceMemoryResourceOptions(max_size=POOL_SIZE, ipc_enabled=ipc_enabled)
384+
mr = DeviceMemoryResource(device, options=options)
383385
assert mr.is_ipc_enabled == ipc_enabled
384386

385387
# Get the property value

0 commit comments

Comments
 (0)