Skip to content

Commit 64141b5

Browse files
Copilotleofang
andcommitted
Remove Git for Windows and gh CLI installation steps, add T4 GPU support to Windows matrix
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>
1 parent ae93e2b commit 64141b5

File tree

2 files changed

+2
-31
lines changed

2 files changed

+2
-31
lines changed

.github/workflows/test-wheel-windows.yml

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -90,20 +90,6 @@ jobs:
9090
- name: Ensure GPU is working
9191
run: nvidia-smi
9292

93-
- name: Install Git for Windows
94-
# the GPU runner image does not have Git Bash pre-installed...
95-
env:
96-
# doesn't seem there's an easy way to avoid hard-coding it?
97-
GFW_EXE_URL: https://github.com/git-for-windows/git/releases/download/v2.49.0.windows.1/PortableGit-2.49.0-64-bit.7z.exe
98-
run: |
99-
Invoke-WebRequest -Uri "$env:GFW_EXE_URL" -OutFile "PortableGit.7z.exe"
100-
# Self-extracting, see https://gitforwindows.org/zip-archives-extracting-the-released-archives.html
101-
Start-Process .\PortableGit.7z.exe -Wait -Verbose -ArgumentList '-y -gm2'
102-
ls -l PortableGit
103-
echo "$((Get-Location).Path)\\PortableGit\\bin" >> $env:GITHUB_PATH
104-
$env:Path += ";$((Get-Location).Path)\\PortableGit\\bin"
105-
bash --version
106-
10793
- name: Set environment variables
10894
env:
10995
BUILD_CUDA_VER: ${{ inputs.build-ctk-ver }}
@@ -135,21 +121,6 @@ jobs:
135121
name: ${{ env.CUDA_BINDINGS_ARTIFACT_NAME }}
136122
path: ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}
137123

138-
- name: Install gh cli
139-
# the GPU runner image does not have gh pre-installed...
140-
env:
141-
# doesn't seem there's an easy way to avoid hard-coding it?
142-
GH_MSI_URL: https://github.com/cli/cli/releases/download/v2.67.0/gh_2.67.0_windows_amd64.msi
143-
run: |
144-
Invoke-WebRequest -Uri "$env:GH_MSI_URL" -OutFile "gh_installer.msi"
145-
Start-Process msiexec.exe -Wait -Verbose -ArgumentList '/i "gh_installer.msi" /qn'
146-
$GH_POSSIBLE_PATHS = "C:\\Program Files\\GitHub CLI", "C:\\Program Files (x86)\\GitHub CLI"
147-
foreach ($p in $GH_POSSIBLE_PATHS) {
148-
echo "$p" >> $env:GITHUB_PATH
149-
$env:Path += ";$p"
150-
}
151-
gh --version
152-
153124
- name: Install zstd
154125
# the GPU runner image does not have zstd pre-installed... and it's needed by actions/cache
155126
if: ${{ matrix.LOCAL_CTK == '1' }}

ci/test-matrix.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@
8686
"windows": {
8787
"pull-request": [
8888
{ "ARCH": "amd64", "PY_VER": "3.12", "CUDA_VER": "12.9.0", "LOCAL_CTK": "0", "GPU": "a100", "DRIVER": "latest" },
89-
{ "ARCH": "amd64", "PY_VER": "3.12", "CUDA_VER": "12.9.0", "LOCAL_CTK": "1", "GPU": "a100", "DRIVER": "latest" },
90-
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "13.0.0", "LOCAL_CTK": "0", "GPU": "a100", "DRIVER": "latest" },
89+
{ "ARCH": "amd64", "PY_VER": "3.12", "CUDA_VER": "12.9.0", "LOCAL_CTK": "1", "GPU": "t4", "DRIVER": "latest" },
90+
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "13.0.0", "LOCAL_CTK": "0", "GPU": "t4", "DRIVER": "latest" },
9191
{ "ARCH": "amd64", "PY_VER": "3.13", "CUDA_VER": "13.0.0", "LOCAL_CTK": "1", "GPU": "a100", "DRIVER": "latest" }
9292
],
9393
"nightly": [

0 commit comments

Comments
 (0)