[PRM-495] Removed 'latest' tagging from ECR

Author: AndyFlintAnswerDigital

.github/workflows/base-java-service-jobs.yml

@@ -101,12 +101,12 @@ jobs:
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
+          TAG_ARG=""
           if [ -n "${REF_NAME:-}" ]; then
             REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
+            TAG_ARG="-t $REGISTRY/$REPOSITORY:$REF_TAG"
           fi
-          docker build "${TAG_ARGS[@]}" --build-arg BUILD_TAG="$IMAGE_TAG" .
+          docker build $TAG_ARG --build-arg BUILD_TAG="$IMAGE_TAG" .
 
       - name: Docker Publish
         if: ${{ inputs.is_deployment }}
@@ -117,14 +117,8 @@ jobs:
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
-          fi
           docker push "$REGISTRY/$REPOSITORY:$IMAGE_TAG"
-          docker push "$REGISTRY/$REPOSITORY:latest"
-
+          
           if [ -n "${REF_NAME:-}" ]; then
             REF_TAG="${REF_NAME//\//-}"
             docker push "$REGISTRY/$REPOSITORY:$REF_TAG"

.github/workflows/base-node-service-jobs.yml

@@ -134,12 +134,12 @@ jobs:
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
+          TAG_ARG=""
           if [ -n "${REF_NAME:-}" ]; then
             REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
+            TAG_ARG="-t $REGISTRY/$REPOSITORY:$REF_TAG"
           fi
-          docker build "${TAG_ARGS[@]}" --build-arg BUILD_TAG="$IMAGE_TAG" .
+          docker build $TAG_ARG --build-arg BUILD_TAG="$IMAGE_TAG" 
 
       - name: Docker Publish
         if: ${{ inputs.is_deployment }}
@@ -150,14 +150,8 @@ jobs:
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
-          fi
           docker push "$REGISTRY/$REPOSITORY:$IMAGE_TAG"
-          docker push "$REGISTRY/$REPOSITORY:latest"
-
+          
           if [ -n "${REF_NAME:-}" ]; then
             REF_TAG="${REF_NAME//\//-}"
             docker push "$REGISTRY/$REPOSITORY:$REF_TAG"

.github/workflows/base-python-service-jobs.yml

@@ -85,12 +85,12 @@ jobs:
           ECR_URI: ${{ steps.ecr-repo.outputs.uri }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
-          TAG_ARGS=(-t "$ECR_URI:$IMAGE_TAG" -t "$ECR_URI:latest")
+          TAG_ARG=""
           if [ -n "${REF_NAME:-}" ]; then
             REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$ECR_URI:$REF_TAG")
+            TAG_ARG="-t $ECR_URI:$REF_TAG"
           fi
-          docker build "${TAG_ARGS[@]}" --build-arg IMAGE_TAG="$IMAGE_TAG" --build-arg ENV=${{steps.auth.outputs.aws-account-id}} .
+          docker build $TAG_ARG --build-arg IMAGE_TAG="$IMAGE_TAG" --build-arg ENV=${{steps.auth.outputs.aws-account-id}} .
 
       - name: Push Docker Image
         if: ${{ inputs.is_deployment }}
@@ -100,9 +100,8 @@ jobs:
           IMAGE_TAG: ${{ github.sha }}
         run: |
           docker push "$ECR_URI:$IMAGE_TAG"
-          docker push "$ECR_URI:latest"
-          if [ -n "${GITHUB_REF_NAME:-}" ]; then
-            REF_TAG="${GITHUB_REF_NAME//\//-}"
+          if [ -n "${REF_NAME:-}" ]; then
+            REF_TAG="${REF_NAME//\//-}"
             docker push "$ECR_URI:$REF_TAG"
           fi