[PRM-495] Removed all health checks across JS services

Author: AndyFlintAnswerDigital

services/ehr-out-service/src/__tests__/app.integration.test.js

@@ -44,31 +44,6 @@ jest.mock('../services/gp2gp/send-core');
 jest.mock('../services/ehr-repo/get-fragment');
 jest.mock('../services/gp2gp/send-fragment');
 
-describe('GET /health', () => {
-  // ============ COMMON PROPERTIES ============
-  const HEALTH_ENDPOINT = '/health';
-  const { nhsEnvironment } = config();
-  // =================== END ===================
-
-  it('should return 200 and the response from getHealthCheck', async () => {
-    const expectedHealthCheckResponse = {
-      version: '1',
-      description: 'Health of ehr-out-service',
-      nhsEnvironment: nhsEnvironment,
-      details: {
-        database: {
-          type: 'dynamodb'
-        }
-      }
-    };
-
-    const response = await request(app).get(HEALTH_ENDPOINT);
-
-    expect(response.statusCode).toBe(200);
-    expect(response.body).toMatchObject(expectedHealthCheckResponse);
-  });
-});
-
 describe('Swagger Documentation', () => {
   // ============ COMMON PROPERTIES ============
   const SWAGGER_ENDPOINT_1 = '/swagger';

services/ehr-out-service/src/app.js

@@ -3,14 +3,12 @@ import swaggerUi from 'swagger-ui-express';
 
 import { middleware } from './middleware/logging';
 import { registrationRequests } from './api/registration-request';
-import { healthCheck } from './api/health-check/health-check';
 import swaggerDocument from './swagger.json';
 
 const app = express();
 app.use(express.json());
 
 app.use('/swagger', swaggerUi.serve, swaggerUi.setup(swaggerDocument));
-app.use('/health', middleware, healthCheck);
 app.use('/registration-requests', middleware, registrationRequests);
 
 // eslint-disable-next-line no-unused-vars

services/ehr-out-service/src/swagger.json

@@ -6,31 +6,6 @@
     "title": "ehr-out-service"
   },
   "paths": {
-    "/health": {
-      "get": {
-        "tags": [
-          "/health"
-        ],
-        "summary": "Checks health of api",
-        "produces": [
-          "application/json"
-        ],
-        "responses": {
-          "200": {
-            "description": "Successful retrieval",
-            "schema": {
-              "$ref": "#/definitions/healthCheckResponse"
-            }
-          },
-          "500": {
-            "description": "Error",
-            "schema": {
-              "$ref": "#/definitions/errorResponse"
-            }
-          }
-        }
-      }
-    },
     "/registration-requests/{conversationId}": {
       "get": {
         "tags": [
@@ -97,27 +72,6 @@
           }
         }
       }
-    },
-    "healthCheckResponse": {
-      "type": "object",
-      "properties": {
-        "version": {
-          "type": "string",
-          "description": "Version number"
-        },
-        "description": {
-          "type": "string",
-          "description": "Describes the component"
-        },
-        "status": {
-          "type": "string",
-          "description": "Tells you if the service is running"
-        },
-        "nhsEnvironment": {
-          "type": "string",
-          "description": "Environment - test, dev etc."
-        }
-      }
     }
   }
 }

services/ehr-repo/src/__tests__/app.test.js

@@ -3,7 +3,6 @@ import app from '../app';
 
 jest.mock('../middleware/logging');
 jest.mock('../middleware/auth');
-jest.mock('../services/health-check/get-health-check');
 
 describe('app', () => {
   describe('GET /', () => {

services/ehr-repo/src/api/health-check/__tests__/health-check.test.js

@@ -5,8 +5,6 @@ import swaggerUi from 'swagger-ui-express';
 import { messages } from './api/messages';
 import { patients } from './api/patients';
 import { fragments } from './api/fragments';
-
-import { healthCheck } from './api/health-check/health-check';
 import { options } from './config/logging';
 import * as logging from './middleware/logging';
 import swaggerDocument from './swagger.json';
@@ -30,7 +28,6 @@ app.use(requestLogger(options));
 app.use('/patients', logging.middleware, patients);
 app.use('/messages', logging.middleware, messages);
 app.use('/fragments', logging.middleware, fragments);
-app.use('/health', logging.middleware, healthCheck);
 app.use('/swagger', swaggerUi.serve, swaggerUi.setup(swaggerDocument));
 app.use(errorLogger(options));