[PRM-495-4] UUID dependency & removal of ECR latest tagging (#273)

* [PRM-495] Moved ehr-out uuid to prod dependency

* [PRM-495] Removed 'latest' tagging from ECR

* [PRM-495] reintroduced image tag to TAG_ARGS

* [PRM-495] reintroduced IMAGE_TAG for node & python workflows

* [PRM-495] Removed GIT_REF from ECR tagging

* [PRM-495] removed GIT_REF from ECR tagging on Node and Python

Author: AndyFlintAnswerDigital

.github/workflows/base-java-service-jobs.yml

@@ -95,40 +95,22 @@ jobs:
 
       - name: Docker Build and Tag
         env:
-          REF_NAME: ${{ github.ref_name }}
           REGISTRY: ${{ steps.ecr-login.outputs.registry }}
           REPOSITORY: ${{inputs.image_prefix}}${{ inputs.service }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
-          fi
-          docker build "${TAG_ARGS[@]}" --build-arg BUILD_TAG="$IMAGE_TAG" .
+          docker build -t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" --build-arg BUILD_TAG="$IMAGE_TAG" .
 
       - name: Docker Publish
         if: ${{ inputs.is_deployment }}
         env:
-          REF_NAME: ${{ github.ref_name }}
           REGISTRY: ${{ steps.ecr-login.outputs.registry }}
           REPOSITORY: ${{ inputs.image_prefix }}${{ inputs.service }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
-          fi
           docker push "$REGISTRY/$REPOSITORY:$IMAGE_TAG"
-          docker push "$REGISTRY/$REPOSITORY:latest"
-
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            docker push "$REGISTRY/$REPOSITORY:$REF_TAG"
-          fi
 
   deploy_infra:
     name: Deploy Infrastructure

.github/workflows/base-node-service-jobs.yml

@@ -128,40 +128,22 @@ jobs:
 
       - name: Docker Build and Tag
         env:
-          REF_NAME: ${{ github.ref_name }}
           REGISTRY: ${{ steps.ecr-login.outputs.registry }}
           REPOSITORY: deductions/${{ inputs.service }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
-          fi
-          docker build "${TAG_ARGS[@]}" --build-arg BUILD_TAG="$IMAGE_TAG" .
+          docker build -t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" --build-arg BUILD_TAG="$IMAGE_TAG" .
 
       - name: Docker Publish
         if: ${{ inputs.is_deployment }}
         env:
-          REF_NAME: ${{ github.ref_name }}
           REGISTRY: ${{ steps.ecr-login.outputs.registry }}
           REPOSITORY: deductions/${{ inputs.service }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
           set -euo pipefail
-          TAG_ARGS=(-t "$REGISTRY/$REPOSITORY:$IMAGE_TAG" -t "$REGISTRY/$REPOSITORY:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$REGISTRY/$REPOSITORY:$REF_TAG")
-          fi
           docker push "$REGISTRY/$REPOSITORY:$IMAGE_TAG"
-          docker push "$REGISTRY/$REPOSITORY:latest"
-
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            docker push "$REGISTRY/$REPOSITORY:$REF_TAG"
-          fi
 
   deploy_infra:
     name: Deploy Infrastructure

.github/workflows/base-python-service-jobs.yml

@@ -81,30 +81,18 @@ jobs:
 
       - name: Build Docker Image
         env:
-          REF_NAME: ${{ github.ref_name }}
           ECR_URI: ${{ steps.ecr-repo.outputs.uri }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
-          TAG_ARGS=(-t "$ECR_URI:$IMAGE_TAG" -t "$ECR_URI:latest")
-          if [ -n "${REF_NAME:-}" ]; then
-            REF_TAG="${REF_NAME//\//-}"
-            TAG_ARGS+=(-t "$ECR_URI:$REF_TAG")
-          fi
-          docker build "${TAG_ARGS[@]}" --build-arg IMAGE_TAG="$IMAGE_TAG" --build-arg ENV=${{steps.auth.outputs.aws-account-id}} .
+          docker build -t "$ECR_URI:$IMAGE_TAG" --build-arg IMAGE_TAG="$IMAGE_TAG" --build-arg ENV=${{steps.auth.outputs.aws-account-id}} .
 
       - name: Push Docker Image
         if: ${{ inputs.is_deployment }}
         env:
-          REF_NAME: ${{ github.ref_name }}
           ECR_URI: ${{ steps.ecr-repo.outputs.uri }}
           IMAGE_TAG: ${{ github.sha }}
         run: |
           docker push "$ECR_URI:$IMAGE_TAG"
-          docker push "$ECR_URI:latest"
-          if [ -n "${GITHUB_REF_NAME:-}" ]; then
-            REF_TAG="${GITHUB_REF_NAME//\//-}"
-            docker push "$ECR_URI:$REF_TAG"
-          fi
 
   deploy_infra:
     if: ${{ inputs.deploy_infra && inputs.is_deployment }}

services/ehr-out-service/package-lock.json

@@ -42,6 +42,7 @@
     "swagger-ui-express": "^4.3.0",
     "traverse": "^0.6.6",
     "utils-deep-clone": "^0.0.3",
+    "uuid": "^8.3.2",
     "winston": "^3.6.0",
     "xml2js": "^0.5.0"
   },
@@ -62,7 +63,6 @@
     "nodemon": "^2.0.19",
     "prettier": "2.6.0",
     "supertest": "^6.3.3",
-    "uuid": "^8.3.2",
     "wait-for-expect": "^3.0.2"
   },
   "overrides": {