Skip to content

Commit a991849

Browse files
Merge branch 'main' into PRM-691
2 parents 43b38c4 + afd9e8a commit a991849

File tree

64 files changed

+21199
-28907
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+21199
-28907
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* @NHSDigital/patient-record-management

.github/workflows/automated-sbom-repo-scan.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
name: SBOM Repo Scan
1616
runs-on: ubuntu-latest
1717
steps:
18-
- uses: actions/checkout@v5
18+
- uses: actions/checkout@v6
1919
with:
2020
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
2121

@@ -35,7 +35,7 @@ jobs:
3535
output-format: sarif
3636

3737
- name: Upload Anchore scan SARIF report
38-
uses: github/codeql-action/upload-sarif@v3
38+
uses: github/codeql-action/upload-sarif@v4
3939
if: always()
4040
with:
4141
sarif_file: ${{ steps.sbom-scan.outputs.sarif }}

.github/workflows/base-java-service-jobs.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ jobs:
4444
working-directory: "./services/${{ inputs.service }}"
4545
steps:
4646
- name: Checkout
47-
uses: actions/checkout@v5
47+
uses: actions/checkout@v6
4848

4949
- name: Set up JDK ${{ inputs.java_version }}
50-
uses: actions/setup-java@v3
50+
uses: actions/setup-java@v5
5151
with:
5252
distribution: "temurin"
5353
java-version: "${{ inputs.java_version }}"
@@ -73,17 +73,17 @@ jobs:
7373
working-directory: "./services/${{ inputs.service }}"
7474
steps:
7575
- name: Checkout
76-
uses: actions/checkout@v5
76+
uses: actions/checkout@v6
7777

7878
- name: Set up JDK ${{ inputs.java_version }}
79-
uses: actions/setup-java@v3
79+
uses: actions/setup-java@v5
8080
with:
8181
distribution: "temurin"
8282
java-version: "${{ inputs.java_version }}"
8383
cache: gradle
8484

8585
- name: Configure AWS Credentials (Read/Write)
86-
uses: aws-actions/configure-aws-credentials@v4
86+
uses: aws-actions/configure-aws-credentials@v6
8787
with:
8888
role-to-assume: ${{ secrets.IAM_ROLE }}
8989
aws-region: ${{ vars.AWS_REGION }}
@@ -137,11 +137,11 @@ jobs:
137137
deploy_infra:
138138
name: Deploy Infrastructure
139139
needs: [build_and_publish]
140-
uses: nhsconnect/orphaned-record-continuity-infrastructure/.github/workflows/deploy-stack.yml@v3
141-
140+
uses: NHSDigital/orphaned-record-continuity-infrastructure/.github/workflows/deploy-stack.yml@v3
142141
with:
143142
stack: ${{ inputs.service }}
144143
environment: ${{ inputs.environment }}
145144
is_deployment: ${{ inputs.is_deployment }}
146145
ecr_alias: ${{ inputs.ecr_alias }}
146+
git_ref: refs/tags/v3
147147
secrets: inherit

.github/workflows/base-node-service-jobs.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,19 @@ jobs:
4444
id: extract_branch
4545

4646
- name: Checkout
47-
uses: actions/checkout@v5
47+
uses: actions/checkout@v6
4848

4949
- name: Set up Node
50-
uses: actions/setup-node@v4
50+
uses: actions/setup-node@v6
5151
with:
52-
node-version: 22
52+
node-version: 24
5353

5454
- name: Install dependencies
5555
working-directory: ./services/${{ inputs.service }}
5656
run: npm install
5757

5858
- name: Start LocalStack
59-
uses: LocalStack/setup-localstack@v0.2.4
59+
uses: LocalStack/setup-localstack@v0.2.5
6060
with:
6161
install-awslocal: "true"
6262

@@ -106,16 +106,18 @@ jobs:
106106
working-directory: "./services/${{ inputs.service }}"
107107
steps:
108108
- name: Checkout
109-
uses: actions/checkout@v5
109+
uses: actions/checkout@v6
110110

111111
- name: Set up Node
112-
uses: actions/setup-node@v4
112+
uses: actions/setup-node@v6
113113
with:
114-
node-version: 22
114+
node-version: 24
115+
115116
- name: Install dependencies
116117
run: npm install
118+
117119
- name: Configure AWS Credentials (Read/Write)
118-
uses: aws-actions/configure-aws-credentials@v4
120+
uses: aws-actions/configure-aws-credentials@v6
119121
with:
120122
role-to-assume: ${{ secrets.IAM_ROLE }}
121123
aws-region: ${{ vars.AWS_REGION }}
@@ -169,10 +171,11 @@ jobs:
169171
deploy_infra:
170172
name: Deploy Infrastructure
171173
needs: [build_and_publish]
172-
uses: nhsconnect/orphaned-record-continuity-infrastructure/.github/workflows/deploy-stack.yml@v3
174+
uses: NHSDigital/orphaned-record-continuity-infrastructure/.github/workflows/deploy-stack.yml@v3
173175
with:
174176
stack: ${{ inputs.service }}
175177
environment: ${{ inputs.environment }}
176178
is_deployment: ${{ inputs.is_deployment }}
177179
ecr_alias: ${{ inputs.ecr_alias }}
180+
git_ref: refs/tags/v3
178181
secrets: inherit

.github/workflows/base-python-service-jobs.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ jobs:
3636
working-directory: "./services/${{ inputs.service }}"
3737
steps:
3838
- name: Checkout
39-
uses: actions/checkout@v5
39+
uses: actions/checkout@v6
4040

4141
- name: Set up Python
42-
uses: actions/setup-python@v5
42+
uses: actions/setup-python@v6
4343
with:
4444
python-version: 3.9
4545
- name: Run Unit tests
@@ -54,16 +54,16 @@ jobs:
5454
run:
5555
working-directory: ./services/${{ inputs.service }}
5656
steps:
57-
- uses: actions/checkout@v4
57+
- uses: actions/checkout@v6
5858

5959
- name: Set up Python 3.9
60-
uses: actions/setup-python@v5
60+
uses: actions/setup-python@v6
6161
with:
6262
python-version: 3.9
6363

6464
- name: Configure AWS credentials
6565
id: auth
66-
uses: aws-actions/configure-aws-credentials@v4
66+
uses: aws-actions/configure-aws-credentials@v6
6767
with:
6868
mask-aws-account-id: true
6969
role-to-assume: ${{ secrets.IAM_ROLE }}
@@ -120,10 +120,11 @@ jobs:
120120
if: ${{ inputs.deploy_infra && inputs.is_deployment }}
121121
name: Deploy Infrastructure
122122
needs: [build-and-publish-service]
123-
uses: nhsconnect/orphaned-record-continuity-infrastructure/.github/workflows/deploy-stack.yml@v3
123+
uses: NHSDigital/orphaned-record-continuity-infrastructure/.github/workflows/deploy-stack.yml@v3
124124
with:
125125
stack: ${{ inputs.service }}
126126
environment: ${{ inputs.environment }}
127127
is_deployment: ${{ inputs.is_deployment }}
128128
ecr_alias: ${{ inputs.ecr_alias }}
129+
git_ref: refs/tags/v3
129130
secrets: inherit

.github/workflows/build.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,34 @@
11
name: Build
2+
23
on:
34
push:
45
branches:
56
- main
7+
68
pull_request:
79
types: [opened, synchronize, reopened]
10+
811
jobs:
912
sonarcloud:
1013
name: SonarCloud
1114
runs-on: ubuntu-latest
1215
steps:
13-
- uses: actions/checkout@v3
16+
- uses: actions/checkout@v6
1417
with:
1518
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
1619

17-
- name: Use Node.js 22.x
18-
uses: actions/setup-node@v3
20+
- name: Use Node.js 24.x
21+
uses: actions/setup-node@v6
1922
with:
20-
node-version: 22.x
23+
node-version: 24.x
2124

2225
- name: Run test coverage
2326
run: |
2427
cd ./services/ehr-repo
2528
./tasks test_coverage-github-action
2629
2730
- name: SonarCloud Scan
28-
uses: SonarSource/sonarqube-scan-action@v4
31+
uses: SonarSource/sonarqube-scan-action@v7
2932
env:
3033
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
3134
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/e2e.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ jobs:
1818

1919
steps:
2020
- name: Checkout End to End
21-
uses: actions/checkout@v5
21+
uses: actions/checkout@v6
2222
with:
2323
repository: "nhsconnect/prm-repo-e2e-tests"
2424

2525
- name: Setup Java
26-
uses: actions/setup-java@v4
26+
uses: actions/setup-java@v5
2727
with:
2828
distribution: "adopt"
2929
java-version: "21"

.github/workflows/service-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ jobs:
4040
changed: ${{ steps.get_changes.outputs.changed }}
4141
steps:
4242
- name: Checkout
43-
uses: actions/checkout@v5
43+
uses: actions/checkout@v6
4444
with:
4545
fetch-depth: 0
4646

4747
- name: Get Changes
4848
id: get_changes
4949
run: |
50-
git fetch origin ${{ github.event.pull_request.base.ref }}
51-
changed=$(git diff --name-only origin/${{ github.event.pull_request.base.ref }}...HEAD | tr '\n' ' ')
50+
git fetch origin main
51+
changed=$(git diff --name-only origin/main... | tr '\n' ' ')
5252
echo "changed=$changed" >> $GITHUB_OUTPUT
5353
5454
ehr-repo:

CONTRIBUTING.md

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Welcome to the Orphaned Record Continuity contributors guide
2+
3+
Thank you for your interest in improving the codebase.
4+
5+
In this guide you will get an overview of the contribution workflow from creating a PR, reviewing, and merging the PR.
6+
7+
The codebase covers:
8+
9+
- The [Orphaned Record Continuity service](https://digital.nhs.uk/services/orphaned-record-continuity).
10+
11+
To raise an issue, please contact one of the [CODEOWNERS](.github/CODEOWNERS) directly, or raise a PR.
12+
13+
If you're new to GitHub and/or Markdown, GitHub's own [contributor's guide](https://github.com/github/docs/blob/main/.github/CONTRIBUTING.md) provides good signposting on these topics.
14+
15+
## Pull requests and merging
16+
17+
You can't push to the main branch. Therefore, for all changes you will need to create a new branch, and then a pull request to merge said branch into `main`. The [CODEOWNERS](.github/CODEOWNERS) will be nominated as reviewers of your PR by default, but feel free to add other people as well if you think they will have valuable input.
18+
19+
## Contributing guidelines and etiquette
20+
21+
- Preview your Markdown code to make sure the format is not broken.
22+
- Check grammar, spelling and punctuation - no-one wants to look pedantic by requesting changes due to typos or inconsistent grammar/syntax, but it's only fair to keep this tidy.
23+
- The codebase is open to the world. This has a few implications:
24+
- Nothing in it should be confidential, private to NHSE or include any personal data.
25+
- All links should be public.
26+
- Consider comments and README.md text: comments in open source repos such as this are not official communications and don't go through the normal approval process for public communication. They can however still be interpreted as official communication, even if not intended as such.
27+
- Use [inclusive language](https://github.com/NHSDigital/software-engineering-quality-framework/blob/main/inclusive-language.md): avoid terms which cause hurt and offence, including if they have historically been considered industry-standard terms.

services/ehr-out-service/.talismanrc

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)