[PRM-667] Removed refs and packages related to aws-sdk v2 (#302)

Author: oliverbeumkes-nhs

.github/workflows/base-node-service-jobs.yml

@@ -56,9 +56,13 @@ jobs:
         run: npm install
 
       - name: Start LocalStack
-        uses: LocalStack/setup-localstack@v0.2.5
+        uses: LocalStack/setup-localstack@v0.3.0
+        env:
+          LOCALSTACK_ACKNOWLEDGE_ACCOUNT_REQUIREMENT: "1" # https://github.com/localstack/setup-localstack/issues/65
         with:
           install-awslocal: "true"
+          use-pro: false
+          image-tag: "4.14.0"
 
       # https://docs.aws.amazon.com/cli/latest/reference/dynamodb/create-table.html
       - name: Create AWS resources

services/ehr-out-service/package-lock.json

@@ -31,7 +31,7 @@
     "expect": "^29.3.1",
     "express": "^5.2.1",
     "express-validator": "^7.3.1",
-    "fast-xml-parser": "^4.2.5",
+    "fast-xml-parser": "^5.5.9",
     "lodash.chunk": "^4.2.0",
     "lodash.clonedeep": "^4.5.0",
     "lodash.isequal": "^4.5.0",

services/ehr-out-service/package.json

@@ -51,9 +51,8 @@ describe('Database connection test', () => {
     // when
     await Promise.all(databaseOperationPromises);
 
-    const recordsAfterTransaction = await db.queryTableByInboundConversationId(
-      INBOUND_CONVERSATION_ID
-    );
+    const recordsAfterTransaction =
+      await db.queryTableByInboundConversationId(INBOUND_CONVERSATION_ID);
     const fragments = recordsAfterTransaction.filter(isFragment);
     // then
     fragments.forEach(fragment => {

services/ehr-out-service/src/__tests__/db.integration.test.js

@@ -21,11 +21,7 @@ export const authenticateRequest = (req, res, next) => {
   }
 
   if (!validAuthorizationKeys.includes(authorizationKey)) {
-    logWarning(
-      `Unsuccessful Request: ${req.method} ${
-        req.originalUrl
-      }, Invalid API Key presented`
-    );
+    logWarning(`Unsuccessful Request: ${req.method} ${req.originalUrl}, Invalid API Key presented`);
     res.status(403).json({
       error: `Authorization header is provided but not valid`
     });

services/ehr-out-service/src/middleware/auth.js

@@ -42,14 +42,12 @@ export async function transferOutFragmentsForRetriedContinueRequest({
 }) {
   setCurrentSpanAttributes({ conversationId });
   logInfo(`Retrying the EHR Fragment transfer.`);
-  const { inboundConversationId } = await getFragmentConversationAndMessageIdsFromEhrRepo(
-    nhsNumber
-  );
+  const { inboundConversationId } =
+    await getFragmentConversationAndMessageIdsFromEhrRepo(nhsNumber);
   logInfo('Retrieved all fragment Message IDs for transfer.');
 
-  const messageIdsWithReplacementsEligibleForSending = await getAllFragmentIdsToBeSent(
-    inboundConversationId
-  );
+  const messageIdsWithReplacementsEligibleForSending =
+    await getAllFragmentIdsToBeSent(inboundConversationId);
 
   logInfo(
     `Found ${messageIdsWithReplacementsEligibleForSending.length} Message ID replacements eligible to be sent.`

services/ehr-out-service/src/services/transfer/transfer-out-fragments.js

@@ -3,8 +3,8 @@ const AWS_ACCOUNT_NO = '000000000000';
 const LOCALSTACK_URL = 'http://localhost:4566';
 const AWS_REGION = 'eu-west-2';
 export const config = {
-  nhsEnvironment: "dev",
-  serviceUrl: "www.example.com",
+  nhsEnvironment: 'dev',
+  serviceUrl: 'www.example.com',
   localstackEndpointUrl: LOCALSTACK_URL,
   region: AWS_REGION,
   awsAccountNo: AWS_ACCOUNT_NO,