refactor(tests): replace 'kind' fields with 'id' in config store validation tests

Author: m-houston

packages/file-store/src/__tests__/config-store-validator.test.ts

@@ -10,30 +10,30 @@ jest.mock("@nhsdigital/nhs-notify-event-schemas-supplier-config", () => {
   return {
     $ChannelType: z.literal("LETTER"),
     $VolumeGroup: z.object({
-      kind: z.literal("volume-group"),
+      id: z.string(),
       name: z.string(),
     }),
     $LetterVariant: z.object({
-      kind: z.literal("letter-variant"),
+      id: z.string(),
       packSpecificationIds: z.array(z.string()).min(1),
     }),
     $PackSpecification: z.object({
-      kind: z.literal("pack-specification"),
+      id: z.string(),
       version: z.number().int(),
       postage: z.object({
         id: z.string(),
       }),
     }),
     $Supplier: z.object({
-      kind: z.literal("supplier"),
+      id: z.string(),
       dailyCapacity: z.number().int(),
     }),
     $SupplierAllocation: z.object({
-      kind: z.literal("supplier-allocation"),
+      id: z.string(),
       allocationPercentage: z.number().min(0).max(100),
     }),
     $SupplierPack: z.object({
-      kind: z.literal("supplier-pack"),
+      id: z.string(),
       approval: z.enum(["APPROVED", "DRAFT"]),
     }),
   };
@@ -59,28 +59,28 @@ describe("validateConfigStore", () => {
     const validRecords = [
       makeRecord("channel", "channel-1", "LETTER"),
       makeRecord("volume-group", "vg-1", {
-        kind: "volume-group",
+        id: "vg-1",
         name: "VG 1",
       }),
       makeRecord("letter-variant", "lv-1", {
-        kind: "letter-variant",
+        id: "lv-1",
         packSpecificationIds: ["pack-spec-1"],
       }),
       makeRecord("pack-specification", "pack-spec-1", {
-        kind: "pack-specification",
+        id: "pack-spec-1",
         version: 1,
         postage: { id: "postage-1" },
       }),
       makeRecord("supplier", "sup-1", {
-        kind: "supplier",
+        id: "sup-1",
         dailyCapacity: 100,
       }),
       makeRecord("supplier-allocation", "alloc-1", {
-        kind: "supplier-allocation",
+        id: "alloc-1",
         allocationPercentage: 100,
       }),
       makeRecord("supplier-pack", "sp-1", {
-        kind: "supplier-pack",
+        id: "sp-1",
         approval: "APPROVED",
       }),
     ];
@@ -92,6 +92,13 @@ describe("validateConfigStore", () => {
           ...record,
           id: `${record.id}-${i}`,
           sourceFilePath: record.sourceFilePath.replace(".json", `-${i}.json`),
+          data:
+            typeof record.data === "string"
+              ? record.data
+              : {
+                  ...(record.data as Record<string, unknown>),
+                  id: `${record.id}-${i}`,
+                },
         })),
       ).flat(),
     });
@@ -115,11 +122,11 @@ describe("validateConfigStore", () => {
       rootPath: "/tmp",
       records: [
         makeRecord("supplier", "sup-1", {
-          kind: "supplier",
+          id: "sup-1",
           dailyCapacity: "not-a-number",
         }),
         makeRecord("pack-specification", "pack-spec-1", {
-          kind: "pack-specification",
+          id: "pack-spec-1",
           version: "bad-version",
           postage: {},
         }),
@@ -146,7 +153,7 @@ describe("validateConfigStore", () => {
       rootPath: "/tmp",
       records: [
         makeRecord("letter-variant", "lv-1", {
-          kind: "letter-variant",
+          id: "lv-1",
           packSpecificationIds: [123],
         }),
       ],
@@ -161,7 +168,7 @@ describe("validateConfigStore", () => {
       rootPath: "/tmp",
       records: [
         makeRecord("supplier", "sup-1", {
-          kind: "supplier",
+          id: "sup-1",
           dailyCapacity: 100,
         }),
       ],