Simplify dry run in client put CLI command

Author: mjewildnhs

tools/client-subscriptions-management/src/__tests__/entrypoint/cli/clients-put.test.ts

@@ -170,7 +170,9 @@ describe("clients-put CLI", () => {
     expect(mockPutClientConfig).toHaveBeenCalledTimes(1);
   });
 
-  it("prints dry-run output without writing", async () => {
+  it("prints dry-run output and does not log success message", async () => {
+    mockPutClientConfig.mockResolvedValue(validConfig);
+
     await cli.main([
       "node",
       "script",
@@ -184,8 +186,15 @@ describe("clients-put CLI", () => {
       "true",
     ]);
 
-    expect(mockPutClientConfig).not.toHaveBeenCalled();
+    expect(mockPutClientConfig).toHaveBeenCalledWith(
+      "client-1",
+      validConfig,
+      true,
+    );
     expect(console.log).toHaveBeenCalledWith("Dry run: config is valid");
+    expect(console.log).toHaveBeenCalledWith(
+      JSON.stringify(validConfig, null, 2),
+    );
   });
 
   it("handles errors in runCli", async () => {

tools/client-subscriptions-management/src/entrypoint/cli/clients-put.ts

@@ -83,17 +83,22 @@ export async function main(args: string[] = process.argv) {
     return;
   }
 
+  const repository = await createRepository(argv);
+
+  const result = await repository.putClientConfig(
+    argv["client-id"],
+    config,
+    argv["dry-run"],
+  );
+
+  console.log(`Config written for client: ${argv["client-id"]}`);
+
   if (argv["dry-run"]) {
     console.log("Dry run: config is valid");
-    console.log(JSON.stringify(config, null, 2));
+    console.log(JSON.stringify(result, null, 2));
     return;
   }
 
-  const repository = await createRepository(argv);
-
-  await repository.putClientConfig(argv["client-id"], config, false);
-  console.log(`Config written for client: ${argv["client-id"]}`);
-
   if (argv["terraform-apply"]) {
     await runTerraformApply({
       environment: argv.environment,