Skip to content

Commit de15bf6

Browse files
readme update
1 parent 002b4b0 commit de15bf6

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

README.md

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,24 +108,15 @@ IMAGE_NAME and IMAGE_VERSION should be changed as appropriate.
108108
You should not need to add any features as these are already baked into the image
109109

110110
## Getting image name and version in GitHub Actions
111-
This job should be used in GitHub Actions wherever you need to get the dev container name or tag
111+
This shared workflow should be used in GitHub Actions wherever you need to get the dev container name or tag.
112+
113+
verify_published_from_main_image should be set to false for testing pull request images.
112114

113115
```
114116
get_config_values:
115-
runs-on: ubuntu-22.04
116-
outputs:
117-
devcontainer_image_name: ${{ steps.load-config.outputs.DEVCONTAINER_IMAGE_NAME }}
118-
devcontainer_image_version: ${{ steps.load-config.outputs.DEVCONTAINER_VERSION }}
119-
steps:
120-
- name: Checkout code
121-
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
122-
- name: Load config value
123-
id: load-config
124-
run: |
125-
DEVCONTAINER_IMAGE_NAME=$(jq -r '.build.args.IMAGE_NAME' .devcontainer/devcontainer.json)
126-
DEVCONTAINER_IMAGE_VERSION=$(jq -r '.build.args.IMAGE_VERSION' .devcontainer/devcontainer.json)
127-
echo "DEVCONTAINER_IMAGE_NAME=$DEVCONTAINER_IMAGE_NAME" >> "$GITHUB_OUTPUT"
128-
echo "DEVCONTAINER_IMAGE_VERSION=$DEVCONTAINER_VERSION" >> "$GITHUB_OUTPUT"
117+
uses: NHSDigital/eps-common-workflows/.github/workflows/get-repo-config.yml@8404cf6e3a61ac8de4d1644e175e288aa4965815
118+
with:
119+
verify_published_from_main_image: false
129120
```
130121
## Using images in GitHub Actions
131122
To use the image in GitHub Actions, you should first verify the attestation of the image and reference the image by the digest

0 commit comments

Comments
 (0)