Skip to content

Commit b63e260

Browse files
authored
Docs: [AEA-0000] - update readme to include github pages notes (#54)
## Summary - Routine Change ### Details - update readme.md to include github pages instructions - do not deploy to prod like environments to get a green build
1 parent 5aaad73 commit b63e260

File tree

2 files changed

+16
-44
lines changed

2 files changed

+16
-44
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -160,45 +160,3 @@ jobs:
160160
LOG_RETENTION_DAYS: 30
161161
secrets:
162162
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.QA_CLOUD_FORMATION_DEPLOY_ROLE }}
163-
164-
release_int:
165-
needs: [tag_release, release_qa, package_code, get_commit_id]
166-
uses: ./.github/workflows/sam_release_code.yml
167-
with:
168-
ARTIFACT_BUCKET_PREFIX: ${{needs.tag_release.outputs.spec_version}}
169-
STACK_NAME: fhir-validator
170-
TARGET_ENVIRONMENT: int
171-
BUILD_ARTIFACT: packaged_code
172-
VERSION_NUMBER: ${{needs.tag_release.outputs.spec_version}}
173-
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
174-
LOG_LEVEL: INFO
175-
LOG_RETENTION_DAYS: 30
176-
CREATE_INT_RELEASE_NOTES: true
177-
CREATE_INT_RC_RELEASE_NOTES: true
178-
secrets:
179-
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.INT_CLOUD_FORMATION_DEPLOY_ROLE }}
180-
DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
181-
INT_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.INT_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
182-
PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
183-
DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE }}
184-
185-
release_prod:
186-
needs: [tag_release, release_int, package_code, get_commit_id]
187-
uses: ./.github/workflows/sam_release_code.yml
188-
with:
189-
ARTIFACT_BUCKET_PREFIX: ${{needs.tag_release.outputs.spec_version}}
190-
STACK_NAME: fhir-validator
191-
TARGET_ENVIRONMENT: prod
192-
BUILD_ARTIFACT: packaged_code
193-
VERSION_NUMBER: ${{needs.tag_release.outputs.spec_version}}
194-
COMMIT_ID: ${{needs.get_commit_id.outputs.commit_id}}
195-
LOG_LEVEL: INFO
196-
LOG_RETENTION_DAYS: 731
197-
MARK_JIRA_RELEASED: true
198-
CREATE_PROD_RELEASE_NOTES: true
199-
secrets:
200-
CLOUD_FORMATION_DEPLOY_ROLE: ${{ secrets.PROD_CLOUD_FORMATION_DEPLOY_ROLE }}
201-
DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
202-
INT_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.INT_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
203-
PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE: ${{ secrets.PROD_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
204-
DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE: ${{ secrets.DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE }}

README.md

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
# eps-FHIR-validator-lambda
22

33
![Build](https://github.com/NHSDigital/eps-FHIR-validator-lambda/actions/workflows/ci.yml/badge.svg?branch=main)
4-
Release history can be found ot https://github.com/NHSDigital/eps-FHIR-validator-lambda/releases. Descriptions for the types of changes in a release can be found in the [contributing guidelines](./CONTRIBUTING.md)
4+
![Release](https://github.com/NHSDigital/eps-FHIR-validator-lambda/actions/workflows/release.yml/badge.svg?branch=main)
5+
6+
## Versions and deployments
7+
Version release history can be found ot https://github.com/NHSDigital/eps-FHIR-validator-lambda/releases.
8+
We use eslint convention for commit messages for commits to main branch. Descriptions for the types of changes in a release can be found in the [contributing guidelines](./CONTRIBUTING.md)
59
Deployment history can be found at https://nhsdigital.github.io/eps-FHIR-validator-lambda/
610

11+
## Introduction
712
This contains a cloud formation stack which contains a lambda which can be used to validate FHIR R4 messages against implementation guides on [Simplifier](https://simplifier.net/).
813

914
- `scripts/` Utilities helpful to developers of this specification.
@@ -149,6 +154,7 @@ There are `make` commands that are run as part of the CI pipeline and help alias
149154

150155
- `install-python` installs python dependencies
151156
- `install-hooks` installs git pre commit hooks
157+
- `install-node` installs node dependencies
152158
- `install` runs all install targets
153159

154160
#### SAM targets
@@ -207,4 +213,12 @@ A combination of these checks are also run in CI.
207213
### Github pages
208214

209215
We use github pages to display deployment information. The source for github pages is in the gh-pages branch.
210-
As part of the ci and release workflows, the release tag (either the short commit SHA or release tag) is appended to _data/{environment}_releases.csv so we have a history of releases and replaced in _data/{environment}_latest.csv so we now what the latest released version is
216+
As part of the ci and release workflows, the release tag (either the short commit SHA or release tag) is appended to _data/{environment}_releases.csv so we have a history of releases and replaced in _data/{environment}_latest.csv so we now what the latest released version is.
217+
There are different makefile targets in this branch. These are
218+
- `run-jekyll` - runs the site locally so changes can be previewed during development
219+
- `sync-main` - syncs common files from main branch to gh-pages branch. You must commit and push after running this
220+
- `install-python` installs python dependencies
221+
- `install-hooks` installs git pre commit hooks
222+
- `install-node` installs node dependencies
223+
- `install-jekyll` installs dependencies to be able to run jekyll locally
224+
- `install` runs all install targets

0 commit comments

Comments
 (0)