Fixing unit tests for ruff fixes

Author: ajmu1

application/pyproject.toml

@@ -16,5 +16,7 @@ ignore_names = [
   "metadata",
   "recipient_email_address",
   "recipient_id",
-  "unhandled_exception_logging_hidden_event"
+  "unhandled_exception_logging_hidden_event",
+  "creatorsname",
+  "email"
 ]

application/service_sync/reject_pending_changes/pending_changes.py

@@ -21,8 +21,8 @@ class PendingChange:
 
     id: str  # Id of the pending change from the change table
     value: str  # Value of the pending change as a JSON string
-    _creatorsname: str  # User name of the user who made the change #Reserved for future use if needed(retiring now)
-    _email: str  # Email address of the user who made the change #Reserved for future use if needed(retiring now)
+    creatorsname: str  # User name of the user who made the change
+    email: str  # Email address of the user who made the change
     typeid: str  # Type id of the service
     name: str  # Name of the service
     uid: str  # Uid of the service

build/automation/var/project.mk

@@ -120,9 +120,6 @@ TF_VAR_signing_key_alias := $(PROJECT_ID)-$(SHARED_ENVIRONMENT)-signing-key-alia
 TF_VAR_route53_health_check_alarm_region_signing_key_alias := $(PROJECT_ID)-$(SHARED_ENVIRONMENT)-alarm-region-signing-key-alias
 
 # S3
-SEND_EMAIL_BUCKET_NAME := $(PROJECT_ID)-$(SHARED_ENVIRONMENT)-send-email-bucket
-TF_VAR_send_email_bucket_name := $(SEND_EMAIL_BUCKET_NAME)
-TF_VAR_logs_bucket_name := $(PROJECT_ID)-$(SHARED_ENVIRONMENT)-logs-bucket
 
 # Cloudwatch monitoring dashboard
 TF_VAR_shared_resources_sns_topic_app_alerts_for_slack_default_region := $(PROJECT_ID)-$(SHARED_ENVIRONMENT)-shared-resources-topic-app-alerts-for-slack-default-region

infrastructure/stacks/application/variables.tf

@@ -133,11 +133,6 @@ variable "sns_topic_app_alerts_for_slack_route53_health_check_alarm_region" {
 # # S3
 # ##############
 
-variable "send_email_bucket_name" {
-  type        = string
-  description = "Name of the bucket to temporarily store emails to be sent"
-}
-
 # ##############
 # # FIREHOSE
 # ##############

infrastructure/stacks/shared-resources/variables.tf

@@ -115,11 +115,6 @@ variable "shared_resources_sns_topic_app_alerts_for_slack_route53_health_check_a
 # # S3
 # ##############
 
-variable "send_email_bucket_name" {
-  type        = string
-  description = "Name of the bucket to temporarily store emails to be sent"
-}
-
 variable "logs_bucket_name" {
   type        = string
   description = "Name of the bucket to store logs"