Skip to content

Merge dev into main#13

Merged
NHLOCAL merged 343 commits into
mainfrom
dev
May 16, 2026
Merged

Merge dev into main#13
NHLOCAL merged 343 commits into
mainfrom
dev

Conversation

@NHLOCAL
Copy link
Copy Markdown
Owner

@NHLOCAL NHLOCAL commented May 16, 2026

Summary

  • Merge the current dev branch into main.
  • Includes the album deduplicator desktop app work, API/backend services, documentation updates, release workflow, and similarity model assets currently on dev.

Branch comparison

  • origin/dev is 340 commits ahead of origin/main.
  • origin/main has 0 commits not present in origin/dev.

Validation

  • PR creation only; no local test suite was run for this merge request.

NHLOCAL added 30 commits May 25, 2025 23:38
שמירת הנתונים בקאש ללא דריסה שלהם בסריקה של תיקיה שונה
שמירת נתוני תוכן התיקיות בקאש ללא דריסה שלהם בסריקה של תיקיה שונה
שמירת רשימת תיקיות לאורך זמן
קטע הקוד היה מזהה אלבומים שאינם דומים בשם האלבום ומדלג על תהליך המיון. הוא הוסר כדי להבטיח בדיקה של אלבומים בכל מצב
שילוב של מודל ה-ml באופן אינטגרלי בתוך הקוד
- בחירת הפרמטרים הטובים ביותר אוטומטית
- שמירת גרסאות המודלים והמידע עליהם בצורה מסודרת
@NHLOCAL NHLOCAL linked an issue May 16, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive system for identifying and deduplicating music albums, featuring a desktop application built with Electron, React, and FastAPI. The core logic includes a sophisticated comparison engine that combines algorithmic scoring, a local machine learning model, and optional AI analysis via Gemini. Key backend components handle recursive folder scanning, metadata extraction, and quality assessment. The frontend provides a modern RTL interface for reviewing clusters and managing deletions safely. Feedback from the review identifies a logic error in the folder scanner that would skip directories containing subfolders and a structural issue in the dummy image processor used when Pillow is unavailable.

Comment thread album_deduplicator/music_dup_lib/core/folder_scanner.py
Comment thread album_deduplicator/music_dup_lib/core/file_processor.py Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78d738a86a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread album_deduplicator/frontend/electron-builder.config.cjs
@NHLOCAL NHLOCAL merged commit 8fb75e1 into main May 16, 2026
4 checks passed
@NHLOCAL NHLOCAL linked an issue May 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

שיפור שיטת מיזוג התיקיות שקלול ציון ג'מיני במחיקה ומיזוג

1 participant