Skip to content

Commit 1749dc7

Browse files
committed
Updated .nuspec file and build script
1 parent b341de4 commit 1749dc7

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

build.ps1

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
$configurationdefault = "Release"
22
$artifacts = "../../artifacts"
3-
$nugetartifacts = "artifacts"
43

54
$configuration = Read-Host 'Configuration to build [default: Release] ?'
65
if ($configuration -eq '') {
@@ -48,4 +47,4 @@ Write-Host "NuGet Packages creation"
4847
#dotnet pack ./src/NEventStore.Domain/NEventStore.Domain.Core.csproj --no-build -c $configuration -o $artifacts -p:NuspecFile="" -p:NuspecProperties="pippo=$configuration;version=$nugetversion"
4948

5049
#Write-Host nuget pack ./src/NEventStore.Domain/NEventStore.Domain.Core.csproj -properties "version=$nugetversion;configuration=$configuration"
51-
nuget pack ./src/.nuget/NEventStore.Domain.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $nugetartifacts
50+
nuget pack ./src/.nuget/NEventStore.Domain.nuspec -properties "version=$nugetversion;configuration=$configuration" -OutputDirectory $artifacts

readme.markdown

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ git submodule update
4646
To build the project locally on a Windows Machine:
4747

4848
- Install [Chocolatey](https://chocolatey.org/).
49+
- Optional: update `.\src\.nuget\NEventStore.Domain.nuspec` file if needed (before creating relase packages).
4950
- Open a Powershell console in Administrative mode and run the build script `build.ps1` in the root of the repository.
5051

5152
## How to contribute
@@ -88,6 +89,10 @@ You can leave all values as default. Now your repository is GitFlow enabled.
8889

8990
### Note on Nuget version on Nuspec
9091

92+
Remember to update `.\src\.nuget\NEventStore.Domain.nuspec` file if needed (before creating relase packages).
93+
94+
The .nuspec file is needed because the new `dotnet pack` command has problems dealing with ProjectReferences, submodules get the wrong version number.
95+
9196
While we are on develop branch, (suppose we just bumped major number so the driver version number is 6.0.0-unstablexxxx), we need to declare that this persistence driver depends from a version greater than the latest published. If the latest version of NEventStore 5.x.x wave iw 5.4.0 we need to declare this package dependency as
9297

9398
(5.4, 7)

src/.nuget/NEventStore.Domain.nuspec

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,16 @@
2121
-->
2222
<dependencies>
2323
<group targetFramework=".NETFramework4.6.1">
24-
<dependency id="NEventStore" version="[8.0.0, 9.0.0)" exclude="Build,Analyzers" />
24+
<dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
25+
</group>
26+
<group targetFramework="net6.0">
27+
<dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
2528
</group>
2629
<group targetFramework="net5.0">
27-
<dependency id="NEventStore" version="[8.0.0, 9.0.0)" exclude="Build,Analyzers" />
30+
<dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
2831
</group>
2932
<group targetFramework=".NETStandard2.0">
30-
<dependency id="NEventStore" version="[8.0.0, 9.0.0)" exclude="Build,Analyzers" />
33+
<dependency id="NEventStore" version="[9.0.0, 10.0.0)" exclude="Build,Analyzers" />
3134
</group>
3235
</dependencies>
3336
</metadata>

0 commit comments

Comments
 (0)