Fix current problems with molecule checks (#360)

There are two problems that both break tests. I try to solve them in a
single PR because one would block merging the other. Both are "new
problems" that arose through updates of tools being used. The checks
worked in the past.

* Having `become` only in tasks where needed might be good coding style
but it breaks tests with Rocky Linux and might have other unpredicted
side effects. So I'm removing it.
* Starting `rsyslog` on Rocky Linux fails with "Timeout". There' no
further information so I decided to replace it with reading journald
instead of rsyslog. This might have been a move to make in the future
anyway.

Author: widhalmt

molecule/elasticstack_default/converge.yml

@@ -20,8 +20,7 @@
     logstash_pipeline_unsafe_shutdown: true
     logstash_redis_password: "{{ lookup('ansible.builtin.password', '/tmp/redispassword', chars=['ascii_letters'], length=15) }}"
     redis_requirepass: "{{ logstash_redis_password }}"
-    beats_filebeat_syslog_udp: true
-    beats_filebeat_syslog_tcp: true
+    beats_filebeat_journald: true
     beats_filebeat_modules:
       - system
     beats_fields:
@@ -51,19 +50,3 @@
     - name: Include Beats
       ansible.builtin.include_role:
         name: beats
-    - name: Install rsyslog
-      ansible.builtin.package:
-        name: rsyslog
-    - name: Remove cache # noqa: risky-shell-pipe
-      ansible.builtin.shell: >
-        if test -n "$(ps -p $$ | grep bash)"; then set -o pipefail; fi;
-        rm -rf /var/cache/*
-      changed_when: false
-    - name: Configure rsyslog
-      ansible.builtin.lineinfile:
-        line: "*.* @@localhost:514"
-        path: /etc/rsyslog.conf
-    - name: Start rsyslog
-      ansible.builtin.service:
-        name: rsyslog
-        state: started

molecule/elasticstack_default/verify.yml

@@ -17,10 +17,6 @@
         port: 5044
       when: "'logstash' in group_names"
 
-    - name: Wait for syslog port to open
-      ansible.builtin.wait_for:
-        port: 514
-
     - name: Set elasticsearch_ca variable if not already done by user
       ansible.builtin.set_fact:
         elasticsearch_ca: "{{ groups[elasticstack_elasticsearch_group_name][0] }}"

molecule/logstash_full_stack-oss/converge.yml

@@ -19,22 +19,14 @@
     logstash_security: false
     logstash_pipeline_unsafe_shutdown: true
     elasticstack_security: false
-    beats_filebeat_syslog_udp: true
-    beats_filebeat_syslog_tcp: true
+    beats_filebeat_journald: true
     logstash_beats_tls: false
     elasticstack_release: 7
     elasticstack_no_log: false
   tasks:
     - name: "Include Elastics repos role"
       ansible.builtin.include_role:
         name: repos
-    - name: Install rsyslog
-      ansible.builtin.package:
-        name: rsyslog
-    - name: Start rsyslog
-      ansible.builtin.service:
-        name: rsyslog
-        state: started
     - name: "Include Elasticsearch role"
       ansible.builtin.include_role:
         name: elasticsearch
@@ -47,12 +39,3 @@
     - name: "Include Logstash"
       ansible.builtin.include_role:
         name: logstash
-    - name: Configure rsyslog
-      ansible.builtin.lineinfile:
-        line: "*.* @@localhost:514"
-        path: /etc/rsyslog.conf
-    - name: Restart rsyslog
-      ansible.builtin.service:
-        name: rsyslog
-        state: restarted
-      changed_when: false

molecule/logstash_full_stack-oss/verify.yml

@@ -13,10 +13,6 @@
   - name: Run syntax check
     ansible.builtin.command: "/usr/share/logstash/bin/logstash --path.settings=/etc/logstash -t"
     when: "'logstash' in group_names"
-  - name: Check for open port tcp {{ elasticstack_beats_port }}
-    ansible.builtin.wait_for:
-      port: "{{ elasticstack_beats_port }}"
-    when: "'logstash' in group_names"
   - name: Query for Logstasch indices
     ansible.builtin.shell: >
       curl -s http://localhost:{{ elasticstack_elasticsearch_http_port }}/_cat/indices |

roles/elasticsearch/tasks/main.yml

@@ -204,7 +204,6 @@
   when: elasticsearch_jna_workaround | bool
 
 - name: Set jvm heap size
-  become: yes
   ansible.builtin.template:
     src: "jvm.options.d/heap.options.j2"
     dest: "{{ elasticsearch_conf_dir }}/jvm.options.d/10-heap.options"
@@ -216,7 +215,6 @@
   when: (elasticsearch_heap)
 
 - name: Set jvm paths
-  become: yes
   ansible.builtin.template:
     src: "jvm.options.d/paths.options.j2"
     dest: "{{ elasticsearch_conf_dir }}/jvm.options.d/50-paths.options"
@@ -227,7 +225,6 @@
   notify: Restart Elasticsearch
 
 - name: Set jvm custom options
-  become: yes
   ansible.builtin.template:
     src: "jvm.options.d/custom.options.j2"
     dest: "{{ elasticsearch_conf_dir }}/jvm.options.d/90-custom.options"