address linter recommendations

Author: joswig

src/aerie_cli/commands/workspace.py

@@ -1,7 +1,6 @@
-from builtins import list as list_builtin
-from genericpath import isdir, isfile
+from genericpath import isdir
 from os import walk
-from posixpath import commonpath, join, normpath, relpath
+from posixpath import join, normpath, relpath
 from typing import Optional
 
 import typer
@@ -39,7 +38,7 @@ def create(
 @app.command()
 def list(
     workspace_id: Optional[int] = typer.Option(
-        None, "--workspace_id", "-w", help="The workspace id"
+        None, "--workspace_id", "-w", help="Workspace id to list"
     ),
     base_directory: Optional[str] = typer.Option(
         None, "--base_directory", "-b", help="Path of directory within workspace"
@@ -94,7 +93,7 @@ def list_workspace_contents(
 @app.command()
 def save(
     workspace_id: int = typer.Option(
-        ..., "--workspace_id", "-w", help="The workspace id"
+        ..., "--workspace_id", "-w", help="Id of workspace to save file to"
     ),
     workspace_path: str = typer.Option(
         ..., "--path", "-p", help="The relative path within the workspace"
@@ -132,7 +131,7 @@ def contained_files(path: str):
 @app.command()
 def get(
     workspace_id: int = typer.Option(
-        ..., "--workspace_id", "-w", help="The workspace id"
+        ..., "--workspace_id", "-w", help="Id of workspace to get file from"
     ),
     workspace_path: str = typer.Option(
         ..., "--path", "-p", help="The relative path within the workspace"

src/aerie_cli/persistent.py

@@ -23,6 +23,7 @@
 SESSION_FILE_DIRECTORY = Path(APP_DIRS.user_config_dir).resolve().absolute()
 SESSION_TIMESTAMP_FSTRING = r"%Y-%jT%H-%M-%S.%f"
 SESSION_TIMEOUT = timedelta(hours=12)
+SESSION_FILE_PATTERN = "*.aerie_cli.session"
 
 
 def delete_all_persistent_files():
@@ -127,7 +128,7 @@ def _load_active_session(cls) -> None:
 
         # Get any/all open sessions. List in chronological order, newest first
         session_files: List[Path] = [
-            f for f in SESSION_FILE_DIRECTORY.glob("*.aerie_cli.session")
+            f for f in SESSION_FILE_DIRECTORY.glob(SESSION_FILE_PATTERN)
         ]
         session_files.sort(reverse=True)
 
@@ -180,7 +181,7 @@ def set_active_session(cls, session: AerieHost) -> bool:
             return False
 
         session_files: List[Path] = [
-            f for f in SESSION_FILE_DIRECTORY.glob("*.aerie_cli.session")
+            f for f in SESSION_FILE_DIRECTORY.glob(SESSION_FILE_PATTERN)
         ]
         for session_file in session_files:
             session_file.unlink()
@@ -211,7 +212,7 @@ def unset_active_session(cls) -> str:
         except NoActiveSessionError:
             return None
 
-        fs: List[Path] = [f for f in SESSION_FILE_DIRECTORY.glob("*.aerie_cli.session")]
+        fs: List[Path] = [f for f in SESSION_FILE_DIRECTORY.glob(SESSION_FILE_PATTERN)]
         for fn in fs:
             fn.unlink()
 
@@ -224,7 +225,7 @@ def reset(cls) -> None:
         cls._active_session = None
 
         # Get any/all open sessions. List in chronological order, newest first
-        fs: List[Path] = [f for f in SESSION_FILE_DIRECTORY.glob("*.aerie_cli.session")]
+        fs: List[Path] = [f for f in SESSION_FILE_DIRECTORY.glob(SESSION_FILE_PATTERN)]
         if not len(fs):
             return
         # Delete all session files

src/aerie_cli/schemas/api.py

@@ -83,7 +83,7 @@ def __attrs_post_init__(self):
         if self.anchored_to_start is None:
             if self.anchor_id is not None:
                 raise ValueError(
-                    f"anchor_id was specified but anchored_to_start was not"
+                    "anchor_id was specified but anchored_to_start was not"
                 )
             self.anchored_to_start = True