Fix Tests (#36)

* add logs

* fix log

* For TestMSBuild tests, force debug build

Co-authored-by: Harry <harrypierson@outlook.com>

Author: devhawk

.github/workflows/release.yml

@@ -9,7 +9,6 @@ env:
 
 jobs:
   build:
-    if: startsWith(github.ref, 'refs/heads/release/')
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
@@ -36,6 +35,7 @@ jobs:
         name: packages
         path: ./out
     - name: Create Release
+      if: startsWith(github.ref, 'refs/heads/release/')
       uses: marvinpinto/action-automatic-releases@v1.1.1
       with:
         repo_token: "${{ secrets.GITHUB_TOKEN }}"
@@ -45,10 +45,14 @@ jobs:
         files: |
           ./out/*
     - name: Push to Nuget.org
+      if: startsWith(github.ref, 'refs/heads/release/')
       run: dotnet nuget push ${{ format('./out/Neo.Assertions.{0}.nupkg', steps.nbgv.outputs.NuGetPackageVersion) }} --api-key ${{ secrets.NUGET_ORG_TOKEN }} --source https://api.nuget.org/v3/index.json
     - name: Push to Nuget.org
+      if: startsWith(github.ref, 'refs/heads/release/')
       run: dotnet nuget push ${{ format('./out/Neo.BuildTasks.{0}.nupkg', steps.nbgv.outputs.NuGetPackageVersion) }} --api-key ${{ secrets.NUGET_ORG_TOKEN }} --source https://api.nuget.org/v3/index.json
     - name: Push to Nuget.org
+      if: startsWith(github.ref, 'refs/heads/release/')
       run: dotnet nuget push ${{ format('./out/Neo.Test.Harness.{0}.nupkg', steps.nbgv.outputs.NuGetPackageVersion) }} --api-key ${{ secrets.NUGET_ORG_TOKEN }} --source https://api.nuget.org/v3/index.json
     - name: Push to Nuget.org
+      if: startsWith(github.ref, 'refs/heads/release/')
       run: dotnet nuget push ${{ format('./out/Neo.Test.Runner.{0}.nupkg', steps.nbgv.outputs.NuGetPackageVersion) }} --api-key ${{ secrets.NUGET_ORG_TOKEN }} --source https://api.nuget.org/v3/index.json

test/test-build-tasks/Extensions.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using Microsoft.Build.Utilities.ProjectCreation;
@@ -53,7 +54,8 @@ public static void RunThrow(this IProcessRunner @this, string command, string ar
 
         public static ProjectCreator AssertBuild(this ProjectCreator @this, ITestOutputHelper? output = null)
         {
-            @this.TryBuild(restore: true, out bool result, out BuildOutput buildOutput);
+            var globalProperties = new Dictionary<string, string>() { ["Configuration"] = "Debug" };
+            @this.TryBuild(restore: true, globalProperties, out bool result, out BuildOutput buildOutput);
             if (!result)
             {
                 if (output != null)
@@ -77,7 +79,7 @@ public static ProjectCreator AssertBuild(this ProjectCreator @this, ITestOutputH
         public static ProjectCreator ImportNeoBuildTools(this ProjectCreator @this)
         {
             var buildTasksPath = typeof(NeoCsc).Assembly.Location;
-            var testBuildAssmblyDirectory = Path.GetDirectoryName(typeof(TestBuild).Assembly.Location)
+            var testBuildAssmblyDirectory = Path.GetDirectoryName(typeof(TestMSBuild).Assembly.Location)
                 ?? throw new Exception("Couldn't get directory name of TestBuild assembly");
             var targetsPath = Path.Combine(testBuildAssmblyDirectory, "build", "Neo.BuildTasks.targets");
 

…st-build-tasks/TestBuild.TestRootPath.cs …-build-tasks/TestMSBuild.TestRootPath.cstest/test-build-tasks/TestBuild.TestRootPath.cs renamed to test/test-build-tasks/TestMSBuild.TestRootPath.cs test/test-build-tasks/TestBuild.TestRootPath.cs renamed to test/test-build-tasks/TestMSBuild.TestRootPath.cs

@@ -3,7 +3,7 @@
 
 namespace build_tasks
 {
-    public partial class TestBuild
+    public partial class TestMSBuild
     {
         internal class TestRootPath : IDisposable
         {

test/test-build-tasks/TestBuild.cs test/test-build-tasks/TestMSBuild.cstest/test-build-tasks/TestBuild.cs renamed to test/test-build-tasks/TestMSBuild.cs

@@ -7,11 +7,11 @@
 
 namespace build_tasks
 {
-    public partial class TestBuild : MSBuildTestBase
+    public partial class TestMSBuild : MSBuildTestBase
     {
         readonly ITestOutputHelper output;
 
-        public TestBuild(ITestOutputHelper output)
+        public TestMSBuild(ITestOutputHelper output)
         {
             this.output = output;
         }
@@ -94,8 +94,7 @@ void test_NeoContractGeneration(string testRootPath, string manifest, string con
                 .ItemInclude("NeoContractGeneration", "registrar", metadata: metadata)
                 .AssertBuild(output);
 
-            var generatedCodePath = Path.Combine(testRootPath, "obj/Debug/net6.0/registrar.contract-interface.cs");
-            Assert.True(File.Exists(generatedCodePath), "contract interface not generated");
+            CheckGeneratedPath(testRootPath, "obj/Debug/net6.0/registrar.contract-interface.cs");
         }
 
         [Fact]
@@ -140,8 +139,20 @@ void test_NeoContractReference(string testRootPath, string source, string contra
                 .ItemInclude("NeoContractReference", srcCreator.FullPath, metadata: metadata)
                 .AssertBuild(output);
 
-            var generatedCodePath = Path.Combine(testRootPath, "test/obj/Debug/net6.0/registrar.contract-interface.cs");
-            Assert.True(File.Exists(generatedCodePath), "contract interface not generated");
+            CheckGeneratedPath(testRootPath, "test/obj/Debug/net6.0/registrar.contract-interface.cs");
+        }
+
+        void CheckGeneratedPath(string testRootPath, string relativeGeneratedPath)
+        {
+            var generatedCodePath = Path.Combine(testRootPath, relativeGeneratedPath);
+            if (!File.Exists(generatedCodePath))
+            {
+                foreach (var file in Directory.EnumerateFiles(testRootPath, "", SearchOption.AllDirectories))
+                {
+                    output.WriteLine(file);
+                }
+                throw new FileNotFoundException("contract interface not generated", generatedCodePath);
+            }
         }
 
         public static ProjectCreator CreateDotNetSixProject(string directory, string projectName = "project.csproj")